summaryrefslogtreecommitdiff
path: root/tests/backends/postgresql
diff options
context:
space:
mode:
authorJon Dufresne <jon.dufresne@gmail.com>2020-04-15 02:20:46 -0700
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2020-04-17 11:57:24 +0200
commit75410228dfd16e49eb3c0ea30b59b4c0d2ea6b03 (patch)
treecb9e6532b57cf60f8eaebcb3860241094e6a5588 /tests/backends/postgresql
parent8005829bb9d9e0a14d73c9375bb55eb05daa46e1 (diff)
downloaddjango-75410228dfd16e49eb3c0ea30b59b4c0d2ea6b03.tar.gz
Fixed #31473 -- Made sql_flush() use RESTART IDENTITY to reset sequences on PostgreSQL.
The sql_flush() positional argument sequences is replaced by the boolean keyword-only argument reset_sequences. This ensures that the old function signature can't be used by mistake when upgrading Django. When the new argument is True, the sequences of the truncated tables will reset. Using a single boolean value, rather than a list, allows making a binary yes/no choice as to whether to reset all sequences rather than a working on a completely different set.
Diffstat (limited to 'tests/backends/postgresql')
-rw-r--r--tests/backends/postgresql/test_operations.py42
1 files changed, 4 insertions, 38 deletions
diff --git a/tests/backends/postgresql/test_operations.py b/tests/backends/postgresql/test_operations.py
index b073f688f4..821bb29cee 100644
--- a/tests/backends/postgresql/test_operations.py
+++ b/tests/backends/postgresql/test_operations.py
@@ -14,7 +14,6 @@ class PostgreSQLOperationsTests(SimpleTestCase):
connection.ops.sql_flush(
no_style(),
[Person._meta.db_table, Tag._meta.db_table],
- [],
),
['TRUNCATE "backends_person", "backends_tag";'],
)
@@ -24,61 +23,28 @@ class PostgreSQLOperationsTests(SimpleTestCase):
connection.ops.sql_flush(
no_style(),
[Person._meta.db_table, Tag._meta.db_table],
- [],
allow_cascade=True,
),
['TRUNCATE "backends_person", "backends_tag" CASCADE;'],
)
def test_sql_flush_sequences(self):
- sequence_reset_sql = (
- "SELECT setval(pg_get_serial_sequence('%s','id'), 1, false);"
- )
self.assertEqual(
connection.ops.sql_flush(
no_style(),
[Person._meta.db_table, Tag._meta.db_table],
- [
- {
- 'table': Person._meta.db_table,
- 'column': Person._meta.pk.db_column,
- },
- {
- 'table': Tag._meta.db_table,
- 'column': Tag._meta.pk.db_column,
- },
- ],
+ reset_sequences=True,
),
- [
- 'TRUNCATE "backends_person", "backends_tag";',
- sequence_reset_sql % '"backends_person"',
- sequence_reset_sql % '"backends_tag"',
- ],
+ ['TRUNCATE "backends_person", "backends_tag" RESTART IDENTITY;'],
)
def test_sql_flush_sequences_allow_cascade(self):
- sequence_reset_sql = (
- "SELECT setval(pg_get_serial_sequence('%s','id'), 1, false);"
- )
self.assertEqual(
connection.ops.sql_flush(
no_style(),
[Person._meta.db_table, Tag._meta.db_table],
- [
- {
- 'table': Person._meta.db_table,
- 'column': Person._meta.pk.db_column,
- },
- {
- 'table': Tag._meta.db_table,
- 'column': Tag._meta.pk.db_column,
- },
- ],
+ reset_sequences=True,
allow_cascade=True,
),
- [
- 'TRUNCATE "backends_person", "backends_tag" CASCADE;',
- sequence_reset_sql % '"backends_person"',
- sequence_reset_sql % '"backends_tag"',
- ],
+ ['TRUNCATE "backends_person", "backends_tag" RESTART IDENTITY CASCADE;'],
)