summaryrefslogtreecommitdiff
path: root/tests/admin_widgets
diff options
context:
space:
mode:
authorJohannes Hoppe <info@johanneshoppe.com>2019-11-27 20:36:26 +0700
committerCarlton Gibson <carlton.gibson@noumenal.es>2019-11-27 14:36:26 +0100
commit69dbb6b7086699bea27609845b1cd89fd2f85e0b (patch)
tree26051bca648cce089d98327cce830f571bce7157 /tests/admin_widgets
parent8d322902799019908ec0ded3f08cc8c09425ee8e (diff)
downloaddjango-69dbb6b7086699bea27609845b1cd89fd2f85e0b.tar.gz
Fixed #30973 -- Converted selenium tests wait_page_loaded to context manager.
Diffstat (limited to 'tests/admin_widgets')
-rw-r--r--tests/admin_widgets/tests.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/tests/admin_widgets/tests.py b/tests/admin_widgets/tests.py
index 2bbf176ec3..aa81d187d8 100644
--- a/tests/admin_widgets/tests.py
+++ b/tests/admin_widgets/tests.py
@@ -940,8 +940,8 @@ class DateTimePickerShortcutsSeleniumTests(AdminWidgetSeleniumTestCase):
self.selenium.find_elements_by_css_selector('.field-birthdate .timezonewarning')
# Submit the form.
- self.selenium.find_element_by_tag_name('form').submit()
- self.wait_page_loaded()
+ with self.wait_page_loaded():
+ self.selenium.find_element_by_tag_name('form').submit()
# Make sure that "now" in javascript is within 10 seconds
# from "now" on the server side.
@@ -1128,13 +1128,13 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
self.admin_login(username='super', password='secret', login_url='/')
self.selenium.get(self.live_server_url + reverse('admin:admin_widgets_school_change', args=(self.school.id,)))
- self.wait_page_loaded()
+ self.wait_page_ready()
self.execute_basic_operations('vertical', 'students')
self.execute_basic_operations('horizontal', 'alumni')
# Save and check that everything is properly stored in the database ---
self.selenium.find_element_by_xpath('//input[@value="Save"]').click()
- self.wait_page_loaded()
+ self.wait_page_ready()
self.school = School.objects.get(id=self.school.id) # Reload from database
self.assertEqual(list(self.school.students.all()), [self.arthur, self.cliff, self.jason, self.john])
self.assertEqual(list(self.school.alumni.all()), [self.arthur, self.cliff, self.jason, self.john])
@@ -1218,8 +1218,8 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
input.send_keys([Keys.BACK_SPACE, Keys.BACK_SPACE])
# Save and check that everything is properly stored in the database ---
- self.selenium.find_element_by_xpath('//input[@value="Save"]').click()
- self.wait_page_loaded()
+ with self.wait_page_loaded():
+ self.selenium.find_element_by_xpath('//input[@value="Save"]').click()
self.school = School.objects.get(id=self.school.id) # Reload from database
self.assertEqual(list(self.school.students.all()), [self.jason, self.peter])
self.assertEqual(list(self.school.alumni.all()), [self.jason, self.peter])
@@ -1267,8 +1267,8 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
# self.selenium.refresh() or send_keys(Keys.F5) does hard reload and
# doesn't replicate what happens when a user clicks the browser's
# 'Refresh' button.
- self.selenium.execute_script("location.reload()")
- self.wait_page_loaded()
+ with self.wait_page_loaded():
+ self.selenium.execute_script("location.reload()")
options_len = len(self.selenium.find_elements_by_css_selector('#id_students_to > option'))
self.assertEqual(options_len, 2)