summaryrefslogtreecommitdiff
path: root/tests/admin_widgets
diff options
context:
space:
mode:
authorTim Graham <timograham@gmail.com>2018-01-31 13:43:05 -0500
committerTim Graham <timograham@gmail.com>2018-02-01 08:36:36 -0500
commit552abffab16cbdff571486b683e7e7ef12e46066 (patch)
treea0506e111db8f6e1e2fa1d0ec2274da39b692ce0 /tests/admin_widgets
parent9bcf73d788866bc93f8248cb2e9d601ecbc4b50c (diff)
downloaddjango-552abffab16cbdff571486b683e7e7ef12e46066.tar.gz
Fixed #29094 -- Fixed crash when entering an invalid uuid in ModelAdmin.raw_id_fields.
Regression in 2f9861d823620da7ecb291a8f005f53da12b1e89. Thanks Carel Burger for the report and fix.
Diffstat (limited to 'tests/admin_widgets')
-rw-r--r--tests/admin_widgets/models.py3
-rw-r--r--tests/admin_widgets/tests.py8
2 files changed, 10 insertions, 1 deletions
diff --git a/tests/admin_widgets/models.py b/tests/admin_widgets/models.py
index bd00b114d3..5fc9f13e96 100644
--- a/tests/admin_widgets/models.py
+++ b/tests/admin_widgets/models.py
@@ -1,3 +1,5 @@
+import uuid
+
from django.contrib.auth.models import User
from django.db import models
@@ -92,6 +94,7 @@ class CarTire(models.Model):
class Honeycomb(models.Model):
+ id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
location = models.CharField(max_length=20)
diff --git a/tests/admin_widgets/tests.py b/tests/admin_widgets/tests.py
index c0a9e1e844..43cf9f4182 100644
--- a/tests/admin_widgets/tests.py
+++ b/tests/admin_widgets/tests.py
@@ -14,7 +14,7 @@ from django.contrib.admin.tests import AdminSeleniumTestCase
from django.contrib.auth.models import User
from django.core.files.storage import default_storage
from django.core.files.uploadedfile import SimpleUploadedFile
-from django.db.models import CharField, DateField, DateTimeField
+from django.db.models import CharField, DateField, DateTimeField, UUIDField
from django.test import SimpleTestCase, TestCase, override_settings
from django.urls import reverse
from django.utils import translation
@@ -248,6 +248,12 @@ class AdminForeignKeyRawIdWidget(TestDataMixin, TestCase):
lookup2 = widgets.url_params_from_lookup_dict({'myfield': my_callable()})
self.assertEqual(lookup1, lookup2)
+ def test_label_and_url_for_value_invalid_uuid(self):
+ field = Bee._meta.get_field('honeycomb')
+ self.assertIsInstance(field.target_field, UUIDField)
+ widget = widgets.ForeignKeyRawIdWidget(field.remote_field, admin.site)
+ self.assertEqual(widget.label_and_url_for_value('invalid-uuid'), ('', ''))
+
class FilteredSelectMultipleWidgetTest(SimpleTestCase):
def test_render(self):