summaryrefslogtreecommitdiff
path: root/tests/admin_widgets/tests.py
diff options
context:
space:
mode:
authorza <za@python.or.id>2016-10-27 14:53:39 +0700
committerTim Graham <timograham@gmail.com>2016-11-10 21:30:21 -0500
commit321e94fa41b121f65c02119c02098df327bbd569 (patch)
treece5476c191d589aca4b124f841dfbccac8dd299f /tests/admin_widgets/tests.py
parent4bb70cbcc60794f515c9bfefeca87b8272d33c0c (diff)
downloaddjango-321e94fa41b121f65c02119c02098df327bbd569.tar.gz
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
Diffstat (limited to 'tests/admin_widgets/tests.py')
-rw-r--r--tests/admin_widgets/tests.py62
1 files changed, 21 insertions, 41 deletions
diff --git a/tests/admin_widgets/tests.py b/tests/admin_widgets/tests.py
index 443e6c6e18..447234209f 100644
--- a/tests/admin_widgets/tests.py
+++ b/tests/admin_widgets/tests.py
@@ -61,16 +61,7 @@ class AdminFormfieldForDBFieldTests(SimpleTestCase):
else:
widget = ff.widget
- # Check that we got a field of the right type
- self.assertTrue(
- isinstance(widget, widgetclass),
- "Wrong widget for %s.%s: expected %s, got %s" % (
- model.__class__.__name__,
- fieldname,
- widgetclass,
- type(widget),
- )
- )
+ self.assertIsInstance(widget, widgetclass)
# Return the formfield so that other tests can continue
return ff
@@ -131,7 +122,7 @@ class AdminFormfieldForDBFieldTests(SimpleTestCase):
def test_formfield_overrides_widget_instances(self):
"""
- Test that widget instances in formfield_overrides are not shared between
+ Widget instances in formfield_overrides are not shared between
different fields. (#19423)
"""
class BandAdmin(admin.ModelAdmin):
@@ -279,10 +270,6 @@ class FilteredSelectMultipleWidgetTest(SimpleTestCase):
class AdminDateWidgetTest(SimpleTestCase):
def test_attrs(self):
- """
- Ensure that user-supplied attrs are used.
- Refs #12073.
- """
w = widgets.AdminDateWidget()
self.assertHTMLEqual(
w.render('test', datetime(2007, 12, 1, 9, 30)),
@@ -298,10 +285,6 @@ class AdminDateWidgetTest(SimpleTestCase):
class AdminTimeWidgetTest(SimpleTestCase):
def test_attrs(self):
- """
- Ensure that user-supplied attrs are used.
- Refs #12073.
- """
w = widgets.AdminTimeWidget()
self.assertHTMLEqual(
w.render('test', datetime(2007, 12, 1, 9, 30)),
@@ -475,8 +458,8 @@ class ForeignKeyRawIdWidgetTest(TestCase):
)
def test_relations_to_non_primary_key(self):
- # Check that ForeignKeyRawIdWidget works with fields which aren't
- # related to the model's primary key.
+ # ForeignKeyRawIdWidget works with fields which aren't related to
+ # the model's primary key.
apple = models.Inventory.objects.create(barcode=86, name='Apple')
models.Inventory.objects.create(barcode=22, name='Pear')
core = models.Inventory.objects.create(
@@ -641,9 +624,7 @@ class DateTimePickerSeleniumTests(AdminWidgetSeleniumTestCase):
def test_show_hide_date_time_picker_widgets(self):
"""
- Ensure that pressing the ESC key closes the date and time picker
- widgets.
- Refs #17064.
+ Pressing the ESC key closes the date and time picker widgets.
"""
from selenium.webdriver.common.keys import Keys
@@ -652,23 +633,23 @@ class DateTimePickerSeleniumTests(AdminWidgetSeleniumTestCase):
self.selenium.get(self.live_server_url + reverse('admin:admin_widgets_member_add'))
# First, with the date picker widget ---------------------------------
- # Check that the date picker is hidden
+ # The date picker is hidden
self.assertEqual(self.get_css_value('#calendarbox0', 'display'), 'none')
# Click the calendar icon
self.selenium.find_element_by_id('calendarlink0').click()
- # Check that the date picker is visible
+ # The date picker is visible
self.assertEqual(self.get_css_value('#calendarbox0', 'display'), 'block')
# Press the ESC key
self.selenium.find_element_by_tag_name('body').send_keys([Keys.ESCAPE])
- # Check that the date picker is hidden again
+ # The date picker is hidden again
self.assertEqual(self.get_css_value('#calendarbox0', 'display'), 'none')
# Then, with the time picker widget ----------------------------------
- # Check that the time picker is hidden
+ # The time picker is hidden
self.assertEqual(self.get_css_value('#clockbox0', 'display'), 'none')
# Click the time icon
self.selenium.find_element_by_id('clocklink0').click()
- # Check that the time picker is visible
+ # The time picker is visible
self.assertEqual(self.get_css_value('#clockbox0', 'display'), 'block')
self.assertEqual(
[
@@ -679,7 +660,7 @@ class DateTimePickerSeleniumTests(AdminWidgetSeleniumTestCase):
)
# Press the ESC key
self.selenium.find_element_by_tag_name('body').send_keys([Keys.ESCAPE])
- # Check that the time picker is hidden again
+ # The time picker is hidden again
self.assertEqual(self.get_css_value('#clockbox0', 'display'), 'none')
def test_calendar_nonday_class(self):
@@ -753,8 +734,8 @@ class DateTimePickerSeleniumTests(AdminWidgetSeleniumTestCase):
def test_calendar_show_date_from_input(self):
"""
- Ensure that the calendar show the date from the input field for every
- locale supported by django.
+ The calendar shows the date from the input field for every locale
+ supported by Django.
"""
self.admin_login(username='super', password='secret', login_url='/')
@@ -795,7 +776,7 @@ class DateTimePickerShortcutsSeleniumTests(AdminWidgetSeleniumTestCase):
def test_date_time_picker_shortcuts(self):
"""
- Ensure that date/time/datetime picker shortcuts work in the current time zone.
+ date/time/datetime picker shortcuts work in the current time zone.
Refs #20663.
This test case is fairly tricky, it relies on selenium still running the browser
@@ -826,7 +807,7 @@ class DateTimePickerShortcutsSeleniumTests(AdminWidgetSeleniumTestCase):
for shortcut in shortcuts:
shortcut.find_element_by_tag_name('a').click()
- # Check that there is a time zone mismatch warning.
+ # There is a time zone mismatch warning.
# Warning: This would effectively fail if the TIME_ZONE defined in the
# settings has the same UTC offset as "Asia/Singapore" because the
# mismatch warning would be rightfully missing from the page.
@@ -1034,8 +1015,8 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
def test_filter(self):
"""
- Ensure that typing in the search box filters out options displayed in
- the 'from' box.
+ Typing in the search box filters out options displayed in the 'from'
+ box.
"""
from selenium.webdriver.common.keys import Keys
@@ -1076,8 +1057,7 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
])
# -----------------------------------------------------------------
- # Check that choosing a filtered option sends it properly to the
- # 'to' box.
+ # Choosing a filtered option sends it properly to the 'to' box.
input.send_keys('a')
self.assertSelectOptions(from_box, [str(self.arthur.id), str(self.jason.id)])
self.get_select_option(from_box, str(self.jason.id)).click()
@@ -1101,8 +1081,8 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
self.assertSelectOptions(to_box, [str(self.peter.id), str(self.jason.id)])
# -----------------------------------------------------------------
- # Check that pressing enter on a filtered option sends it properly
- # to the 'to' box.
+ # Pressing enter on a filtered option sends it properly to
+ # the 'to' box.
self.get_select_option(to_box, str(self.jason.id)).click()
self.selenium.find_element_by_id(remove_link).click()
input.send_keys('ja')
@@ -1137,7 +1117,7 @@ class HorizontalVerticalFilterSeleniumTests(AdminWidgetSeleniumTestCase):
str(self.jason.id), str(self.jenny.id), str(self.john.id),
]
expected_selected_values = [str(self.lisa.id), str(self.peter.id)]
- # Check that everything is still in place
+ # Everything is still in place
self.assertSelectOptions('#id_students_from', expected_unselected_values)
self.assertSelectOptions('#id_students_to', expected_selected_values)
self.assertSelectOptions('#id_alumni_from', expected_unselected_values)