diff options
| author | Erno Kuvaja <jokke@usr.fi> | 2022-08-26 12:46:20 +0100 |
|---|---|---|
| committer | Erno Kuvaja <jokke@usr.fi> | 2022-08-26 12:46:20 +0100 |
| commit | 219568c2a4b21c26ca4c160a7cf4d71cae524255 (patch) | |
| tree | c544f8091782f84742f2b2860e59ed8017374ace | |
| parent | 75218d289ed27b4eddd645436275b1e51aed0fab (diff) | |
| download | python-glanceclient-219568c2a4b21c26ca4c160a7cf4d71cae524255.tar.gz | |
Bump default pagesize
Bumping default pagesize to 200. With the previous
default value of 20 glanceclient was doing lots of
extra requests and schema validations.
Based on my tests no performance improvement was
seen over the pagesize of 200.
Change-Id: I6d740ca3a9b32bf5d064d3ea74273bb619b32ad4
Closes-Bug: #1987834
| -rw-r--r-- | glanceclient/tests/unit/test_shell.py | 2 | ||||
| -rw-r--r-- | glanceclient/tests/unit/v2/test_client_requests.py | 2 | ||||
| -rw-r--r-- | glanceclient/v2/images.py | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/glanceclient/tests/unit/test_shell.py b/glanceclient/tests/unit/test_shell.py index 6b9472e..fce8ce0 100644 --- a/glanceclient/tests/unit/test_shell.py +++ b/glanceclient/tests/unit/test_shell.py @@ -711,7 +711,7 @@ class ShellTestWithNoOSImageURLPublic(ShellTestWithKeystoneV3Auth): glance_shell = openstack_shell.OpenStackImagesShell() glance_shell.main(args.split()) self.assertEqual(self.requests.request_history[2].url, - self.image_url + "v2/images?limit=20&" + self.image_url + "v2/images?limit=200&" "sort_key=name&sort_dir=asc") diff --git a/glanceclient/tests/unit/v2/test_client_requests.py b/glanceclient/tests/unit/v2/test_client_requests.py index 5c97689..b1c32f2 100644 --- a/glanceclient/tests/unit/v2/test_client_requests.py +++ b/glanceclient/tests/unit/v2/test_client_requests.py @@ -35,7 +35,7 @@ class ClientTestRequests(testutils.TestCase): self.requests = self.useFixture(rm_fixture.Fixture()) self.requests.get('http://example.com/v2/schemas/image', json=schema_fixture) - self.requests.get('http://example.com/v2/images?limit=20', + self.requests.get('http://example.com/v2/images?limit=200', json=image_list_fixture) gc = client.Client(2.2, "http://example.com/v2.1") images = gc.images.list() diff --git a/glanceclient/v2/images.py b/glanceclient/v2/images.py index eeb5ee1..4bc98c5 100644 --- a/glanceclient/v2/images.py +++ b/glanceclient/v2/images.py @@ -24,7 +24,7 @@ from glanceclient.common import utils from glanceclient import exc from glanceclient.v2 import schemas -DEFAULT_PAGE_SIZE = 20 +DEFAULT_PAGE_SIZE = 200 SORT_DIR_VALUES = ('asc', 'desc') SORT_KEY_VALUES = ('name', 'status', 'container_format', 'disk_format', |