Revise aggregate functions per earlier discussions in pghackers.

There's now only one transition value and transition function.
NULL handling in aggregates is a lot cleaner.  Also, use Numeric
accumulators instead of integer accumulators for sum/avg on integer
datatypes --- this avoids overflow at the cost of being a little slower.
Implement VARIANCE() and STDDEV() aggregates in the standard backend.

Also, enable new LIKE selectivity estimators by default.  Unrelated
change, but as long as I had to force initdb anyway...

1 files changed, 26 insertions, 26 deletions

diff --git a/src/test/regress/expected/oidjoins.out b/src/test/regress/expected/oidjoins.out
index a42d3d89f0..a2b0ad9e3e 100644
--- a/src/test/regress/expected/oidjoins.out
+++ b/src/test/regress/expected/oidjoins.out
@@ -1,20 +1,12 @@
 --
 -- This is created by pgsql/contrib/findoidjoins/make_oidjoin_check
 --
-SELECT	oid, pg_aggregate.aggtransfn1 
+SELECT	oid, pg_aggregate.aggtransfn 
 FROM	pg_aggregate 
-WHERE	pg_aggregate.aggtransfn1 != 0 AND 
-	NOT EXISTS(SELECT * FROM pg_proc AS t1 WHERE t1.oid = pg_aggregate.aggtransfn1);
- oid | aggtransfn1 
------+-------------
-(0 rows)
-
-SELECT	oid, pg_aggregate.aggtransfn2 
-FROM	pg_aggregate 
-WHERE	pg_aggregate.aggtransfn2 != 0 AND 
-	NOT EXISTS(SELECT * FROM pg_proc AS t1 WHERE t1.oid = pg_aggregate.aggtransfn2);
- oid | aggtransfn2 
------+-------------
+WHERE	pg_aggregate.aggtransfn != 0 AND 
+	NOT EXISTS(SELECT * FROM pg_proc AS t1 WHERE t1.oid = pg_aggregate.aggtransfn);
+ oid | aggtransfn 
+-----+------------
 (0 rows)
 
 SELECT	oid, pg_aggregate.aggfinalfn 
@@ -33,20 +25,12 @@ WHERE	pg_aggregate.aggbasetype != 0 AND
 -----+-------------
 (0 rows)
 
-SELECT	oid, pg_aggregate.aggtranstype1 
-FROM	pg_aggregate 
-WHERE	pg_aggregate.aggtranstype1 != 0 AND 
-	NOT EXISTS(SELECT * FROM pg_type AS t1 WHERE t1.oid = pg_aggregate.aggtranstype1);
- oid | aggtranstype1 
------+---------------
-(0 rows)
-
-SELECT	oid, pg_aggregate.aggtranstype2 
+SELECT	oid, pg_aggregate.aggtranstype 
 FROM	pg_aggregate 
-WHERE	pg_aggregate.aggtranstype2 != 0 AND 
-	NOT EXISTS(SELECT * FROM pg_type AS t1 WHERE t1.oid = pg_aggregate.aggtranstype2);
- oid | aggtranstype2 
------+---------------
+WHERE	pg_aggregate.aggtranstype != 0 AND 
+	NOT EXISTS(SELECT * FROM pg_type AS t1 WHERE t1.oid = pg_aggregate.aggtranstype);
+ oid | aggtranstype 
+-----+--------------
 (0 rows)
 
 SELECT	oid, pg_aggregate.aggfinaltype 
@@ -217,6 +201,22 @@ WHERE	pg_class.relam != 0 AND
 -----+-------
 (0 rows)
 
+SELECT	oid, pg_class.reltoastrelid 
+FROM	pg_class 
+WHERE	pg_class.reltoastrelid != 0 AND 
+	NOT EXISTS(SELECT * FROM pg_class AS t1 WHERE t1.oid = pg_class.reltoastrelid);
+ oid | reltoastrelid 
+-----+---------------
+(0 rows)
+
+SELECT	oid, pg_class.reltoastidxid 
+FROM	pg_class 
+WHERE	pg_class.reltoastidxid != 0 AND 
+	NOT EXISTS(SELECT * FROM pg_class AS t1 WHERE t1.oid = pg_class.reltoastidxid);
+ oid | reltoastidxid 
+-----+---------------
+(0 rows)
+
 SELECT	oid, pg_index.indexrelid 
 FROM	pg_index 
 WHERE	pg_index.indexrelid != 0 AND