diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-12-08 08:51:38 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-12-08 08:58:15 +0100 |
| commit | 2d4f1ba6cfc2f0a977f1c30bda9848041343e248 (patch) | |
| tree | 8fdfef3464578531b8f83b4921fa3b3d5f6dd5dd /src/include/storage | |
| parent | 4b3e37993254ed098219e62ceffb1b32fac388cb (diff) | |
| download | postgresql-2d4f1ba6cfc2f0a977f1c30bda9848041343e248.tar.gz | |
Update types in File API
Make the argument types of the File API match stdio better:
- Change the data buffer to void *, from char *.
- Change FileWrite() data buffer to const on top of that.
- Change amounts to size_t, from int.
In passing, change the FilePrefetch() amount argument from int to
off_t, to match the underlying posix_fadvise().
Discussion: https://www.postgresql.org/message-id/flat/11dda853-bb5b-59ba-a746-e168b1ce4bdb%40enterprisedb.com
Diffstat (limited to 'src/include/storage')
| -rw-r--r-- | src/include/storage/fd.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/include/storage/fd.h b/src/include/storage/fd.h index c0a212487d..7144fc9f60 100644 --- a/src/include/storage/fd.h +++ b/src/include/storage/fd.h @@ -102,9 +102,9 @@ extern File PathNameOpenFile(const char *fileName, int fileFlags); extern File PathNameOpenFilePerm(const char *fileName, int fileFlags, mode_t fileMode); extern File OpenTemporaryFile(bool interXact); extern void FileClose(File file); -extern int FilePrefetch(File file, off_t offset, int amount, uint32 wait_event_info); -extern int FileRead(File file, char *buffer, int amount, off_t offset, uint32 wait_event_info); -extern int FileWrite(File file, char *buffer, int amount, off_t offset, uint32 wait_event_info); +extern int FilePrefetch(File file, off_t offset, off_t amount, uint32 wait_event_info); +extern int FileRead(File file, void *buffer, size_t amount, off_t offset, uint32 wait_event_info); +extern int FileWrite(File file, const void *buffer, size_t amount, off_t offset, uint32 wait_event_info); extern int FileSync(File file, uint32 wait_event_info); extern off_t FileSize(File file); extern int FileTruncate(File file, off_t offset, uint32 wait_event_info); |