diff options
| author | Robert Haas <rhaas@postgresql.org> | 2011-04-25 16:55:11 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2011-04-25 16:55:11 -0400 |
| commit | 68ef051f5cf16f82a5368067a40ffba3c340b0d3 (patch) | |
| tree | 6b8158651e981c35d3653f59114ef33ec9946a2f /src/include/catalog/namespace.h | |
| parent | be90032e0d1cf473bdd99aee94218218f59f29f1 (diff) | |
| download | postgresql-68ef051f5cf16f82a5368067a40ffba3c340b0d3.tar.gz | |
Refactor broken CREATE TABLE IF NOT EXISTS support.
Per bug #5988, reported by Marko Tiikkaja, and further analyzed by Tom
Lane, the previous coding was broken in several respects: even if the
target table already existed, a subsequent CREATE TABLE IF NOT EXISTS
might try to add additional constraints or sequences-for-serial
specified in the new CREATE TABLE statement.
In passing, this also fixes a minor information leak: it's no longer
possible to figure out whether a schema to which you don't have CREATE
access contains a sequence named like "x_y_seq" by attempting to create a
table in that schema called "x" with a serial column called "y".
Some more refactoring of this code in the future might be warranted,
but that will need to wait for a later major release.
Diffstat (limited to 'src/include/catalog/namespace.h')
| -rw-r--r-- | src/include/catalog/namespace.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/include/catalog/namespace.h b/src/include/catalog/namespace.h index f59beee80d..53600969ad 100644 --- a/src/include/catalog/namespace.h +++ b/src/include/catalog/namespace.h @@ -49,6 +49,7 @@ typedef struct OverrideSearchPath extern Oid RangeVarGetRelid(const RangeVar *relation, bool failOK); extern Oid RangeVarGetCreationNamespace(const RangeVar *newRelation); +extern Oid RangeVarGetAndCheckCreationNamespace(const RangeVar *newRelation); extern Oid RelnameGetRelid(const char *relname); extern bool RelationIsVisible(Oid relid); |