summaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/numeric.c
diff options
context:
space:
mode:
authorDean Rasheed <dean.a.rasheed@gmail.com>2021-01-05 11:02:46 +0000
committerDean Rasheed <dean.a.rasheed@gmail.com>2021-01-05 11:02:46 +0000
commit9a299dff25a5f945cc2ee0c00b705857f966e169 (patch)
tree1ae1202706b14ae57f89dbcb5718fca7c883904b /src/backend/utils/adt/numeric.c
parent0709b644239ea5beeb21a53220c5b8eceae9a317 (diff)
downloadpostgresql-9a299dff25a5f945cc2ee0c00b705857f966e169.tar.gz
Fix numeric_power() when the exponent is INT_MIN.
In power_var_int(), the computation of the number of significant digits to use in the computation used log(Abs(exp)), which isn't safe because Abs(exp) returns INT_MIN when exp is INT_MIN. Use fabs() instead of Abs(), so that the exponent is cast to a double before the absolute value is taken. Back-patch to 9.6, where this was introduced (by 7d9a4737c2). Discussion: https://postgr.es/m/CAEZATCVd6pMkz=BrZEgBKyqqJrt2xghr=fNc8+Z=5xC6cgWrWA@mail.gmail.com
Diffstat (limited to 'src/backend/utils/adt/numeric.c')
-rw-r--r--src/backend/utils/adt/numeric.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c
index 74335f76f5..f50da658a6 100644
--- a/src/backend/utils/adt/numeric.c
+++ b/src/backend/utils/adt/numeric.c
@@ -8182,7 +8182,7 @@ power_var_int(NumericVar *base, int exp, NumericVar *result, int rscale)
* to around log10(abs(exp)) digits, so work with this many extra digits
* of precision (plus a few more for good measure).
*/
- sig_digits += (int) log(Abs(exp)) + 8;
+ sig_digits += (int) log(fabs(exp)) + 8;
/*
* Now we can proceed with the multiplications.