diff options
| author | Peter Geoghegan <pg@bowt.ie> | 2022-09-21 13:21:36 -0700 |
|---|---|---|
| committer | Peter Geoghegan <pg@bowt.ie> | 2022-09-21 13:21:36 -0700 |
| commit | aab06442d488364f8861219cb8864a16b6d0d4e4 (patch) | |
| tree | c6a42bd9e8935409d0d43966834e32314e90861f | |
| parent | e59a67fb8fe1ac1408dc1858038f525a860d772b (diff) | |
| download | postgresql-aab06442d488364f8861219cb8864a16b6d0d4e4.tar.gz | |
Harmonize lexer adjacent function parameter names.
Make sure that function declarations use names that exactly match the
corresponding names from function definitions for several "lexer
adjacent" backend functions.
These functions were missed by recent commits because they were obscured
by clang-tidy warnings about functions whose signature is directly under
the control of the lexer (flex seems to always generate function
declarations with unnamed parameters). We probably can't fix most of
the warnings it generates for translation units that get built from .l
and .y files, but we can at least do this much.
Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com
| -rw-r--r-- | src/bin/pgbench/exprparse.y | 2 | ||||
| -rw-r--r-- | src/include/replication/syncrep.h | 2 | ||||
| -rw-r--r-- | src/include/replication/walsender_private.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/bin/pgbench/exprparse.y b/src/bin/pgbench/exprparse.y index f6387d4a3c..17b065a6bf 100644 --- a/src/bin/pgbench/exprparse.y +++ b/src/bin/pgbench/exprparse.y @@ -23,7 +23,7 @@ PgBenchExpr *expr_parse_result; -static PgBenchExprList *make_elist(PgBenchExpr *exp, PgBenchExprList *list); +static PgBenchExprList *make_elist(PgBenchExpr *expr, PgBenchExprList *list); static PgBenchExpr *make_null_constant(void); static PgBenchExpr *make_boolean_constant(bool bval); static PgBenchExpr *make_integer_constant(int64 ival); diff --git a/src/include/replication/syncrep.h b/src/include/replication/syncrep.h index b5446597b5..0f3b3a7955 100644 --- a/src/include/replication/syncrep.h +++ b/src/include/replication/syncrep.h @@ -103,7 +103,7 @@ extern void SyncRepUpdateSyncStandbysDefined(void); extern int syncrep_yyparse(void); extern int syncrep_yylex(void); extern void syncrep_yyerror(const char *str); -extern void syncrep_scanner_init(const char *query_string); +extern void syncrep_scanner_init(const char *str); extern void syncrep_scanner_finish(void); #endif /* _SYNCREP_H */ diff --git a/src/include/replication/walsender_private.h b/src/include/replication/walsender_private.h index 9c61f92c44..cb4da76a89 100644 --- a/src/include/replication/walsender_private.h +++ b/src/include/replication/walsender_private.h @@ -119,7 +119,7 @@ extern void WalSndSetState(WalSndState state); extern int replication_yyparse(void); extern int replication_yylex(void); extern void replication_yyerror(const char *str) pg_attribute_noreturn(); -extern void replication_scanner_init(const char *query_string); +extern void replication_scanner_init(const char *str); extern void replication_scanner_finish(void); extern bool replication_scanner_is_replication_command(void); |