diff options
| author | Andres Freund <andres@anarazel.de> | 2017-08-05 20:52:53 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2017-08-06 14:21:19 -0700 |
| commit | 32d7480e02eef139265ece8c2b8842c0b3cb1127 (patch) | |
| tree | 415377eccf495056b7130d93e67f11dd7e0510ea | |
| parent | f27449fcca947c5a7340a0e41d105584d6505adb (diff) | |
| download | postgresql-32d7480e02eef139265ece8c2b8842c0b3cb1127.tar.gz | |
Fix thinko introduced in 2bef06d516460 et al.
The callers for GetOldestSafeDecodingTransactionId() all inverted the
argument for the argument introduced in 2bef06d516460. Luckily this
appears to be inconsequential for the moment, as we wait for
concurrent in-progress transaction when assembling a
snapshot. Additionally this could only make a difference when adding a
second logical slot, because only a pre-existing slot could cause an
issue by lowering the returned xid dangerously much.
Reported-By: Antonin Houska
Discussion: https://postgr.es/m/32704.1496993134@localhost
Backport: 9.4-, where 2bef06d516460 was backpatched to.
| -rw-r--r-- | src/backend/replication/logical/logical.c | 2 | ||||
| -rw-r--r-- | src/backend/replication/logical/snapbuild.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 3ea80253d3..f44533eb7f 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -284,7 +284,7 @@ CreateInitDecodingContext(char *plugin, */ LWLockAcquire(ProcArrayLock, LW_EXCLUSIVE); - xmin_horizon = GetOldestSafeDecodingTransactionId(need_full_snapshot); + xmin_horizon = GetOldestSafeDecodingTransactionId(!need_full_snapshot); slot->effective_catalog_xmin = xmin_horizon; slot->data.catalog_xmin = xmin_horizon; diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 43ec8e4943..901e95ede4 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -592,7 +592,7 @@ SnapBuildExportSnapshot(SnapBuild *builder) TransactionId safeXid; LWLockAcquire(ProcArrayLock, LW_SHARED); - safeXid = GetOldestSafeDecodingTransactionId(true); + safeXid = GetOldestSafeDecodingTransactionId(false); LWLockRelease(ProcArrayLock); Assert(TransactionIdPrecedesOrEquals(safeXid, snap->xmin)); |