diff options
| author | Noah Misch <noah@leadboat.com> | 2017-11-05 18:51:08 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2017-11-05 18:54:52 -0800 |
| commit | 014c5cd8767161995278bc1f4e2fcfb1b703dad1 (patch) | |
| tree | 5ce7d26cd11c6133b0fa0ff4a78185069861f0a0 | |
| parent | 4dc03c8609b5a0ca725a3ee4d6077f23f81461b8 (diff) | |
| download | postgresql-014c5cd8767161995278bc1f4e2fcfb1b703dad1.tar.gz | |
Add a temp-install prerequisite to "check"-like targets not having one.
Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly. Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place. Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.
| -rw-r--r-- | src/interfaces/ecpg/test/Makefile | 2 | ||||
| -rw-r--r-- | src/test/locale/Makefile | 1 | ||||
| -rw-r--r-- | src/test/modules/brin/Makefile | 2 | ||||
| -rw-r--r-- | src/test/regress/GNUmakefile | 4 |
4 files changed, 5 insertions, 4 deletions
diff --git a/src/interfaces/ecpg/test/Makefile b/src/interfaces/ecpg/test/Makefile index a4ac02107c..d13742256e 100644 --- a/src/interfaces/ecpg/test/Makefile +++ b/src/interfaces/ecpg/test/Makefile @@ -81,7 +81,7 @@ check: all $(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule # the same options, but with --listen-on-tcp -checktcp: all +checktcp: all | temp-install $(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule_tcp --host=localhost installcheck: all diff --git a/src/test/locale/Makefile b/src/test/locale/Makefile index 26ec5c9a90..22a45b65f2 100644 --- a/src/test/locale/Makefile +++ b/src/test/locale/Makefile @@ -16,5 +16,6 @@ clean distclean maintainer-clean: $(MAKE) -C $$d clean || exit; \ done +# These behave like installcheck targets. check-%: all @$(MAKE) -C `echo $@ | sed 's/^check-//'` test diff --git a/src/test/modules/brin/Makefile b/src/test/modules/brin/Makefile index dda84c23c7..2c51c66924 100644 --- a/src/test/modules/brin/Makefile +++ b/src/test/modules/brin/Makefile @@ -18,7 +18,7 @@ endif check: isolation-check -isolation-check: | submake-isolation +isolation-check: | submake-isolation temp-install $(MKDIR_P) isolation_output $(pg_isolation_regress_check) \ --outputdir=./isolation_output \ diff --git a/src/test/regress/GNUmakefile b/src/test/regress/GNUmakefile index 4d6849e34e..487d6589b4 100644 --- a/src/test/regress/GNUmakefile +++ b/src/test/regress/GNUmakefile @@ -133,7 +133,7 @@ REGRESS_OPTS = --dlpath=. $(EXTRA_REGRESS_OPTS) check: all tablespace-setup $(pg_regress_check) $(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule $(MAXCONNOPT) $(TEMP_CONF) $(EXTRA_TESTS) -check-tests: all tablespace-setup +check-tests: all tablespace-setup | temp-install $(pg_regress_check) $(REGRESS_OPTS) $(MAXCONNOPT) $(TEMP_CONF) $(TESTS) $(EXTRA_TESTS) installcheck: all tablespace-setup @@ -157,7 +157,7 @@ runtest-parallel: installcheck-parallel bigtest: all tablespace-setup $(pg_regress_installcheck) $(REGRESS_OPTS) --schedule=$(srcdir)/serial_schedule numeric_big -bigcheck: all tablespace-setup +bigcheck: all tablespace-setup | temp-install $(pg_regress_check) $(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule $(MAXCONNOPT) numeric_big |