summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2023-01-17 16:00:39 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2023-01-17 16:01:20 -0500
commitc18c12c983a84d55e58b176969782c7ffac3272b (patch)
tree0b40c76f0578e13eefde4aeb9d4865e320103e46
parentddd89df26b9779e1b6415cdf3617563072bfa716 (diff)
downloadpostgresql-REL_10_STABLE.tar.gz
AdjustUpgrade.pm should zap test_ext_cine, too.REL_10_STABLE
test_extensions' test_ext_cine extension has the same upgrade hazard as test_ext7: the regression test leaves it in an updated state from which no downgrade path to default is provided. This causes the update_extensions.sql script helpfully provided by pg_upgrade to fail. So drop it in cross-version-upgrade testing. Not entirely sure how come I didn't hit this in testing yesterday; possibly I'd built the upgrade reference databases with testmodules-install-check disabled. Backpatch to v10 where this module was introduced.
-rw-r--r--src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
index 2a19287aa3..0d9d549da4 100644
--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
@@ -88,12 +88,13 @@ sub adjust_database_contents
}
}
- # avoid version number issues with test_ext7
+ # avoid no-path-to-downgrade-extension-version issues
if ($dbnames{contrib_regression_test_extensions})
{
_add_st(
$result,
'contrib_regression_test_extensions',
+ 'drop extension if exists test_ext_cine',
'drop extension if exists test_ext7');
}