diff options
| author | David Zeuthen <davidz@redhat.com> | 2011-04-01 12:12:27 -0400 |
|---|---|---|
| committer | David Zeuthen <davidz@redhat.com> | 2011-04-01 12:12:27 -0400 |
| commit | c23d74447c7615dc74dae259f0fc3688ec988867 (patch) | |
| tree | 8d15c7623c26394f57d5670924f3e1d324e152d0 | |
| parent | 129b6223a19e7fb2753f8cad7957ac5402394076 (diff) | |
| download | polkit-c23d74447c7615dc74dae259f0fc3688ec988867.tar.gz | |
Use polkit_unix_process_get_uid() to get the owner of a process
This avoids a TOCTTOU problem.
Signed-off-by: David Zeuthen <davidz@redhat.com>
| -rw-r--r-- | src/polkitbackend/polkitbackendsessionmonitor.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/polkitbackend/polkitbackendsessionmonitor.c b/src/polkitbackend/polkitbackendsessionmonitor.c index 495f752..9c331b6 100644 --- a/src/polkitbackend/polkitbackendsessionmonitor.c +++ b/src/polkitbackend/polkitbackendsessionmonitor.c @@ -293,14 +293,15 @@ polkit_backend_session_monitor_get_user_for_subject (PolkitBackendSessionMonitor if (POLKIT_IS_UNIX_PROCESS (subject)) { - local_error = NULL; - uid = polkit_unix_process_get_owner (POLKIT_UNIX_PROCESS (subject), &local_error); - if (local_error != NULL) + uid = polkit_unix_process_get_uid (POLKIT_UNIX_PROCESS (subject)); + if ((gint) uid == -1) { - g_propagate_prefixed_error (error, local_error, "Error getting user for process: "); + g_set_error (error, + POLKIT_ERROR, + POLKIT_ERROR_FAILED, + "Unix process subject does not have uid set"); goto out; } - ret = polkit_unix_user_new (uid); } else if (POLKIT_IS_SYSTEM_BUS_NAME (subject)) |