Migrate tests to use pathlib.Path

The pip-specific Path implementation has been removed, and all its
usages replaced by pathlib.Path. The tmpdir and tmpdir_factory fixtures
are also removed, and all usages are replaced by tmp_path and
tmp_path_factory, which use pathlib.Path.

The pip() function now also accepts pathlib.Path so we don't need to put
str() everywhere. Path arguments are coerced with os.fspath() into str.

1 files changed, 4 insertions, 3 deletions

diff --git a/tools/protected_pip.py b/tools/protected_pip.py
index 671518029..48230719e 100644
--- a/tools/protected_pip.py
+++ b/tools/protected_pip.py
@@ -1,15 +1,16 @@
 import os
+import pathlib
 import shutil
 import subprocess
 import sys
 from glob import glob
-from typing import List
+from typing import Iterable, Union
 
 VIRTUAL_ENV = os.environ["VIRTUAL_ENV"]
 TOX_PIP_DIR = os.path.join(VIRTUAL_ENV, "pip")
 
 
-def pip(args: List[str]) -> None:
+def pip(args: Iterable[Union[str, pathlib.Path]]) -> None:
     # First things first, get a recent (stable) version of pip.
     if not os.path.exists(TOX_PIP_DIR):
         subprocess.check_call(
@@ -30,7 +31,7 @@ def pip(args: List[str]) -> None:
     pypath = pypath_env.split(os.pathsep) if pypath_env is not None else []
     pypath.insert(0, TOX_PIP_DIR)
     os.environ["PYTHONPATH"] = os.pathsep.join(pypath)
-    subprocess.check_call([sys.executable, "-m", "pip"] + args)
+    subprocess.check_call([sys.executable, "-m", "pip", *(os.fspath(a) for a in args)])
 
 
 if __name__ == "__main__":