summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorStéphane Bidoul <stephane.bidoul@gmail.com>2023-03-18 14:41:53 +0100
committerPradyun Gedam <pradyunsg@gmail.com>2023-03-27 11:55:20 +0100
commita38865597dcdb4f00187a95bbe98e861b78eceee (patch)
treef5415d3e8509fe5fc0477284612a9f7f3782efed /tests
parentb11e8e434368ce30e625052f482f8ab0b7d9ec44 (diff)
downloadpip-a38865597dcdb4f00187a95bbe98e861b78eceee.tar.gz
Update test_install_subprocess_output_handling
Diffstat (limited to 'tests')
-rw-r--r--tests/functional/test_install.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/tests/functional/test_install.py b/tests/functional/test_install.py
index ac1292ad7..1fa702a40 100644
--- a/tests/functional/test_install.py
+++ b/tests/functional/test_install.py
@@ -1515,12 +1515,18 @@ def test_install_subprocess_output_handling(
# If the install fails, then we *should* show the output... but only once,
# even if --verbose is given.
result = script.pip(*(args + ["--global-option=--fail"]), expect_error=True)
- assert 1 == result.stderr.count("I DIE, I DIE")
+ # This error is emitted 3 times:
+ # - by setup.py bdist_wheel
+ # - by setup.py clean
+ # - by setup.py install which is used as fallback when setup.py bdist_wheel failed
+ # Before, it failed only once because it attempted only setup.py install.
+ # TODO update this when we remove the last setup.py install code path.
+ assert 3 == result.stderr.count("I DIE, I DIE")
result = script.pip(
*(args + ["--global-option=--fail", "--verbose"]), expect_error=True
)
- assert 1 == result.stderr.count("I DIE, I DIE")
+ assert 3 == result.stderr.count("I DIE, I DIE")
def test_install_log(script: PipTestEnvironment, data: TestData, tmpdir: Path) -> None: