| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Related to GH-6701
|
|
|
|
|
|
| |
enabled
Closes GH-6675
|
|
|
|
|
|
| |
Closes GH-6289
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
|
|
|
|
|
|
|
| |
We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.
Of course, zend_bool is retained as an alias.
|
|
|
|
|
| |
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
|
| |
|
|
|
|
| |
Settling on using quoted string
|
|
|
|
| |
Closes GH-6075
|
|
|
|
|
|
| |
Closes GH-6011
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
|
|
|
|
|
|
|
|
| |
Return the original value. If we don't return the original value,
we need to own the zval, which we don't.
For clarity also switch things to work on a zend_string* value
instead of a zval*.
|
|
|
|
| |
At this point, the value has already been converted into a string.
|
| |
|
|
|
|
|
| |
Elevate this warning into an Error, as usual. Add a few checks
in places that were missing them.
|
|
|
|
| |
Closes GH-5958
|
|
|
|
| |
Co-authored-by: Thomas Weinert <thomas@weinert.info>
|
|
|
|
| |
Closes GH-5758
|
|
|
|
| |
Optional handler with the same semantics as the object handler.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Context: https://externals.io/message/108789
This essentially moves the functionality of SimpleXMLIterator into
SimpleXMLElement, and makes SimpleXMLIterator a no-op extension.
Ideally SimpleXMLElement would be an IteratorAggregate, whose
getIterator() method returns SimpleXMLIterator. However, because
SimpleXMLIterator extends SimpleXMLElement (and code depends on
this in non-trivial ways), this is not possible.
The only way to not keep SimpleXMLElement as a magic Traversable
(that implements neither Iterator nor IteratorAggregate) is to
move the SimpleXMLIterator functionality into it.
Closes GH-5234.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hash is used to check whether the arginfo file needs to be
regenerated. PHP-Parser will only be downloaded if this is actually
necessary.
This ensures that release artifacts will never try to regenerate
stubs and thus fetch PHP-Parser, as long as you do not modify any
files.
Closes GH-5739.
|
|
|
|
|
| |
Cloning of root elements has to preserve that property, so they require
some special treatment.
|
|
|
|
|
| |
For the common ZVAL_OBJ + GC_ADDREF pattern.
This mirrors the existing ZVAL_STR_COPY API.
|
|
|
|
| |
Closes GH-5673.
|
|
|
|
|
|
| |
These are no longer needed after https://wiki.php.net/rfc/always_enable_json
Closes GH-5637
|
| |
|
|\
| |
| |
| |
| | |
* PHP-7.4:
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
|
| | |
| | |
| | |
| | |
| | |
| | | |
Revert "Fix #61597: SXE properties may lack attributes and content"
This reverts commit 7c081db885756d7b176a55b90b8746f664d1e042.
|
| | |
| | |
| | |
| | |
| | | |
Converts ext/pcntl, ext/simplexml, ext/snmp, ext/soap, ext/sqlite3.
Closes GH-5421
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal functions.
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
|
| | |
| | |
| | |
| | | |
Closes GH-5312
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
To explicitly indicate that objects are uncomparable. For now
this has no functional difference from the usual 1 return value,
but makes intent clearer.
|
| | |
| | |
| | |
| | | |
Closes GH-5278
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit bb43a3822e42dbd15b1d416a166549d3980b379a.
After thinking about this a bit more, this is now going to be
a complete solution for the "readonly properties" case, for example:
unset($foo->readOnly->bar);
should also be legal and
$foo->readOnly['bar'] = 42;
should also be legal if $foo->readOnly is not an array but an
ArrayAccess object.
I think it may be better to distinguish better on the BP_VAR flag
level. Reverting for now.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
$a->b->c = 'd';
is now compiled the same way as
$b = $a->b;
$b->c = 'd';
That is, we perform a read fetch on $a->b, rather than a write
fetch.
This is possible, because PHP 8 removed auto-vivification support
for objects, so $a->b->c = 'd' may no longer modify $a->b proper
(i.e. not counting interior mutability of the object).
Closes GH-5250.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #61597: SXE properties may lack attributes and content
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #61597: SXE properties may lack attributes and content
|
| | |
| | |
| | |
| | |
| | | |
We must not treat a node as string if it has attributes, unless it is
an entity declaration which is always treated as string by simplexml.
|
| | |
| | |
| | |
| | | |
Closes GH-5240
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-5188
|
| | |
| | |
| | |
| | | |
Closes GH-5092
|
| | | |
|
| | |
| | |
| | |
| | | |
In preparation for GH-5074
|
| | | |
|
| | |
| | |
| | |
| | | |
Except for some bigger ones: reflection, sodium, spl
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We fix the most often occuring typos according to a recent codespell
report[1] in tests, code comments and documentation.
[1] <https://fossies.org/linux/test/php-src-master-f8f48ce.191129.tar.gz/codespell.html>.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove most of the `===DONE===` tags and its variations.
Keep `===DONE===` if the test output otherwise becomes empty.
Closes GH-4872.
|