| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Whether the pattern is needed depends on the used style. If no
pattern is needed, null is a more sensible value than an empty
string.
fixup
|
| |
|
|
|
|
| |
Closes GH-5758
|
| |
|
|
|
|
| |
Closes GH-4871.
|
|
|
|
| |
Closes GH-4732.
|
| |
|
|
|
|
|
| |
zpp will be throwing for these now, don't report them in addition to
that.
|
|
|
|
|
|
|
|
|
|
|
| |
Previously zend_parse_parameters (and FastZPP) would handle invalid
arguments depending on strict_types: With strict_types=1, a TypeError
is thrown, with strict_types=0 a warning is thrown and (usually) NULL
is returned. Additionally, some functions (constructors always and
other methods sometimes) opt-it to throwing regardless of strict_types.
This commit changes zpp to always generate a TypeError exception in
PHP 8.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.
A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.
This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.
With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.
Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.
|
| |
|
| |
|
|
|
|
| |
__construct, __destruct, __wakeup does not have return types defined.
|
|
|
|
|
| |
Drop the Z_OBJ(return_value) = NULL hack and return status code
from ctor function instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces a ZEND_PARSE_PARAMS_THROW flag for zpp, which forces to
report FAILURE errors using a TypeException instead of a Warning,
like it would happen in strict mode.
Adds a zend_parse_parameters_throw() convenience function, which
invokes zpp with this flag.
Converts all cases I could identify, where we currently have
throwing zpp usage in constructors and replaces them with this API.
Error handling is still replaced to EH_THROW in some cases to handle
other, domain-specific errors in constructors.
|
|
|
|
|
|
|
|
| |
Removed the corresponding core code.
Fixed ext/com_dotnet and ext/date.
Refactored ext/intl changes.
Improved ext/fileinfo and ext/pdo changes.
Fixed tests.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
The address of $this passed to drectly called internal constructor in execute_data->return_value.
Internal constructors should use ZEND_CTOR_MAKE_NULL() macro (insted of previous ZEND_NULL(EG(This))) to do the work.
This patch doesn't fix the problem for indirectly called constructors. e.g. parant::__construct().
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* PHP-5.4:
Fix handling of several uinitialized intl objects
Fix handling of several uinitialized intl objects
- Fix NEWS
- BFN
Conflicts:
ext/intl/dateformat/dateformat.c
|
| | |
|
|\ \
| |/
| |
| |
| |
| |
| |
| | |
* 5.4:
Fix test title and limit it to ICU >= 4.8
Remove executable bit from files
Limit test to ICU 49
Remove executable bit from files
|
| | |
|
|/
|
|
|
| |
The default locale is now requested to ICU when it's needed by using
intl_get_default_locale().
|
| |
|
|
|
|
|
|
|
| |
- Added arginfo
- Fixed WS
- Changed C++ comments to C comments
|
| |
|
| |
|
|
|