summaryrefslogtreecommitdiff
path: root/ext/ftp
Commit message (Collapse)AuthorAgeFilesLines
* Improve class entry generationMáté Kocsis2021-02-161-2/+1
| | | | Related to GH-6701
* Implicitly enable function entry generation when class entry generation is ↵Máté Kocsis2021-02-092-5/+2
| | | | | | enabled Closes GH-6675
* Generate class entries from stubs for another batch of extensionsMáté Kocsis2021-02-083-7/+28
| | | | Closes GH-6669
* Replace zend_bool uses with boolNikita Popov2021-01-152-6/+6
| | | | | | | We're starting to see a mix between uses of zend_bool and bool. Replace all usages with the standard bool type everywhere. Of course, zend_bool is retained as an alias.
* FTP: Disallow direct `FTPConnection` constructionAyesh Karunaratne2020-12-232-0/+21
| | | | | | | Similar to other resource to object migrations, `FTPConnection` class is not allowed to be constructed with `new FTPConnection`. Related to b4503fbf882e490f16d85915e83173bd1e414e84. Closes GH-6533.
* waitpid in ftp server testsNikita Popov2020-10-231-6/+5
| | | | | This is not relevant right now, but ensures consistent order if the tests are repeated.
* Fix pasv_port determinationNikita Popov2020-10-231-1/+1
| | | | | Apparently the ftp server is also used by ext/standard/tests/streams, and only that part actually uses pasv.
* Use ephemeral port in ftp testsNikita Popov2020-10-232-25/+13
| | | | And enable them to run in parallel.
* Remove unused pasv_listen() functionNikita Popov2020-10-221-30/+0
|
* Convert FTP resource to objectSara Golemon2020-10-216-398/+282
|
* Review parameter names in ext/ftpMáté Kocsis2020-10-022-60/+57
| | | | Closes GH-6254
* Consolidate the usage of "either" and "one of" in error messagesMáté Kocsis2020-09-203-4/+4
| | | | Closes GH-6173
* Remove some unnecessary HAVE_EXTNAME guardsNikita Popov2020-09-072-13/+1
| | | | | | | | A recurring pattern in old extension: Putting the whole source code behind HAVE_EXTNAME. This is pointless, as the code is only compiled if the extension is enabled. This removes a couple of them, but not all.
* Promote warnings to exceptions in ext/ftpMáté Kocsis2020-08-318-91/+129
| | | | Closes GH-6054
* Improve type declarations for Zend APIsGeorge Peter Banyard2020-08-281-1/+1
| | | | | | | | | Voidification of Zend API which always succeeded Use bool argument types instead of int for boolean arguments Use bool return type for functions which return true/false (1/0) Use zend_result return type for functions which return SUCCESS/FAILURE as they don't follow normal boolean semantics Closes GH-6002
* Add a bunch of missing argument types to stubsMáté Kocsis2020-08-032-6/+12
|
* Remove proto comments from C filesMax Semenik2020-07-062-164/+82
| | | | Closes GH-5758
* Include stub hash in generated arginfo filesNikita Popov2020-06-241-1/+2
| | | | | | | | | | | | The hash is used to check whether the arginfo file needs to be regenerated. PHP-Parser will only be downloaded if this is actually necessary. This ensures that release artifacts will never try to regenerate stubs and thus fetch PHP-Parser, as long as you do not modify any files. Closes GH-5739.
* Merge branch 'PHP-7.4'Christoph M. Becker2020-06-231-1/+4
|\ | | | | | | | | * PHP-7.4: Fix #55857: ftp_size on large files
| * Merge branch 'PHP-7.3' into PHP-7.4Christoph M. Becker2020-06-231-1/+4
| |\ | | | | | | | | | | | | * PHP-7.3: Fix #55857: ftp_size on large files
| | * Fix #55857: ftp_size on large filesChristoph M. Becker2020-06-231-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | `atol()` returns a `long` which is not the same as `zend_long` on LLP64; we use `ZEND_ATOL()` instead. There is no need for a new test case, since filesize_large.phpt already tests for that behavior; unfortunately, the FTP test suite relies on `pcntl_fork()` and therefore cannot be run on Windows.
| | * Merge branch 'PHP-7.2' into PHP-7.3Nikita Popov2019-07-151-1/+2
| | |\
| | | * Fix bug #77124Nikita Popov2019-07-151-1/+2
| | | | | | | | | | | | | | | | | | | | This is a backport of 6fcae63f614d1ed4aaeaff7b13a7a4627b1f1312 to PHP 7.2.
* | | | Fix [-Wundef] warning in FTP extensionGeorge Peter Banyard2020-05-163-7/+7
| | | |
* | | | Fix UNKNOWN default values in various extensionsMáté Kocsis2020-05-052-2/+2
| | | | | | | | | | | | | | | | Closes GH-5514
* | | | Store default parameter values of internal functions in arg infoMáté Kocsis2020-04-081-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes GH-5353. From now on, PHP will have reflection information about default values of parameters of internal functions. Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
* | | | Generate functions entries from stubs for another set of extensionsMáté Kocsis2020-04-054-81/+85
| | | | | | | | | | | | | | | | Closes GH-5351
* | | | Annotate function aliases in stubsMáté Kocsis2020-04-041-1/+4
| | | |
* | | | Add stubs for aliasesMáté Kocsis2020-02-183-1/+6
| | | | | | | | | | | | | | | | Closes GH-5187
* | | | Reindent phpt filesNikita Popov2020-02-031-524/+524
| | | |
* | | | Merge branch 'PHP-7.4'Nikita Popov2020-01-201-3/+4
|\ \ \ \ | |/ / / | | | | | | | | | | | | * PHP-7.4: Fix bug #79112: IMAP can't find OpenSSL during configure
| * | | Fix bug #79112: IMAP can't find OpenSSL during configureNikita Popov2020-01-201-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the check of PHP_OPENSSL inside SETUP_OPENSSL. It's the responsibility of the caller to determine whether they want to enable openssl or not. This makes SSL detection in IMAP work, which uses a different option. Additionally also clarify that --with-openssl-dir cannot actually be used to specify an OpenSSL directory -- these options just serve as a way to enable OpenSSL in extensions without also enabling the OpenSSL extension. They need to be renamed to something clearer in master. Closes GH-5091.
* | | | Make error messages more consistent by fixing capitalizationMáté Kocsis2020-01-173-4/+4
| | | | | | | | | | | | | | | | Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
* | | | Fix #78880: Final spelling fixesMáté Kocsis2020-01-162-3/+3
| | | |
* | | | Use RETURN_THROWS() after zend_fetch_resource*()Máté Kocsis2020-01-031-32/+32
| | | |
* | | | Use ZEND_THROWS() during ZPP in enchant, exif, fileinfo, filter, and FTP ↵Máté Kocsis2019-12-311-36/+36
| | | | | | | | | | | | | | | | extensions
* | | | Add union return types for function stubsMáté Kocsis2019-11-112-60/+34
| | | |
* | | | Remove mention of PHP major version in Copyright headersGabriel Caruso2019-09-254-8/+0
| | | | | | | | | | | | | | | | Closes GH-4732.
* | | | Add stubs for ext/ftpChristoph M. Becker2019-08-253-209/+341
| | | |
* | | | Remove some misleading RETURN_FALSENikita Popov2019-08-121-35/+35
| | | | | | | | | | | | | | | | | | | | | | | | These functions throw, so they can't return false. This is just a subset...
* | | | Merge branch 'PHP-7.4'Nikita Popov2019-06-251-1/+2
|\ \ \ \ | |/ / /
| * | | Fix SSL_CTX leak in ftp extensionNikita Popov2019-06-251-1/+2
| | | | | | | | | | | | | | | | | | | | SSL_CTX is a refcounted structure, which will be held by the SSL handle, so we can free it here.
* | | | Merge branch 'PHP-7.4'Nikita Popov2019-06-141-0/+2
|\ \ \ \ | |/ / /
| * | | Fix compilation without deprecated OpenSSL 1.1 APIsRosen Penev2019-06-141-0/+2
| | | |
* | | | Convert fetch_resource warnings into TypeErrorsNikita Popov2019-06-031-132/+199
| | | | | | | | | | | | | | | | | | | | More type checks that are not part of zpp and should generate a TypeError in PHP 8.
* | | | Merge branch 'PHP-7.4'Peter Kokot2019-05-121-2/+0
|\ \ \ \ | |/ / / | | | | | | | | | | | | * PHP-7.4: Normalize comments in *nix build system m4 files
| * | | Normalize comments in *nix build system m4 filesPeter Kokot2019-05-121-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Normalization include: - Use dnl for everything that can be ommitted when configure is built in favor of the shell comment character # which is visible in the output. - Line length normalized to 80 columns - Dots for most of the one line sentences - Macro definitions include similar pattern header comments now
| * | | Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function ↵Dmitry Stogov2019-04-241-1/+1
| | | | | | | | | | | | | | | | by reference
* | | | Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function ↵Dmitry Stogov2019-04-241-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | by reference
| * | | | Use ZEND_TRA_ASSIGN_REF_... macros for by reference arguments of internal ↵Dmitry Stogov2019-04-241-1/+1
| |/ / / | | | | | | | | | | | | functions.
View Lorry Controller Status