summaryrefslogtreecommitdiff
path: root/Zend/zend_multibyte.c
Commit message (Collapse)AuthorAgeFilesLines
* Improve type declarations for Zend APIsGeorge Peter Banyard2020-08-281-7/+7
| | | | | | | | | Voidification of Zend API which always succeeded Use bool argument types instead of int for boolean arguments Use bool return type for functions which return true/false (1/0) Use zend_result return type for functions which return SUCCESS/FAILURE as they don't follow normal boolean semantics Closes GH-6002
* Remove local variablesPeter Kokot2019-02-031-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the so called local variables defined per file basis for certain editors to properly show tab width, and similar settings. These are mainly used by Vim and Emacs editors yet with recent changes the once working definitions don't work anymore in Vim without custom plugins or additional configuration. Neither are these settings synced across the PHP code base. A simpler and better approach is EditorConfig and fixing code using some code style fixing tools in the future instead. This patch also removes the so called modelines for Vim. Modelines allow Vim editor specifically to set some editor configuration such as syntax highlighting, indentation style and tab width to be set in the first line or the last 5 lines per file basis. Since the php test files have syntax highlighting already set in most editors properly and EditorConfig takes care of the indentation settings, this patch removes these as well for the Vim 6.0 and newer versions. With the removal of local variables for certain editors such as Emacs and Vim, the footer is also probably not needed anymore when creating extensions using ext_skel.php script. Additionally, Vim modelines for setting php syntax and some editor settings has been removed from some *.phpt files. All these are mostly not relevant for phpt files neither work properly in the middle of the file.
* Adios, yearly copyright rangesZeev Suraski2019-01-301-1/+1
|
* Remove unused Git attributes identPeter Kokot2018-07-251-2/+0
| | | | | | | | | | | | | | | The $Id$ keywords were used in Subversion where they can be substituted with filename, last revision number change, last changed date, and last user who changed it. In Git this functionality is different and can be done with Git attribute ident. These need to be defined manually for each file in the .gitattributes file and are afterwards replaced with 40-character hexadecimal blob object name which is based only on the particular file contents. This patch simplifies handling of $Id$ keywords by removing them since they are not used anymore.
* year++Xinchen Hui2018-01-021-1/+1
|
* further sync for vim mode linesAnatol Belski2017-07-041-2/+2
|
* Update copyright headers to 2017Sammy Kaye Powers2017-01-021-1/+1
|
* Fixed the UTF-8 and long path support in the streams on Windows.Anatol Belski2016-06-201-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.
* bump year which is missed in rev 49493a2Xinchen Hui2016-01-021-1/+1
|
* bump yearXinchen Hui2015-01-151-1/+1
|
* trailing whitespace removalStanislav Malyshev2015-01-101-1/+1
|
* first shot remove TSRMLS_* thingsAnatol Belski2014-12-131-32/+32
|
* Fixed modeDmitry Stogov2014-08-141-0/+0
|
* Fixed compilation warningsDmitry Stogov2014-08-141-2/+2
|
* Refactor mbstring (incompleted)Xinchen Hui2014-03-241-1/+1
|
* Bump yearXinchen Hui2014-01-031-1/+1
|
* Fix assignment in dummy_encoding_list_parserNikita Popov2013-10-191-1/+1
|
* Happy New YearXinchen Hui2013-01-011-1/+1
|
* Use free instead of efreeXinchen Hui2012-05-211-1/+1
|
* - Year++Felipe Pena2012-01-011-1/+1
|
* Fixed bug #55552 (bad encoding not detected)Dmitry Stogov2011-09-141-6/+6
|
* Fix zend.multibyte oddities. Hope this will address all the known problems.Moriyoshi Koizumi2011-03-061-20/+0
|
* - Year++Felipe Pena2011-01-011-1/+1
|
* - Fix startup warnings.Moriyoshi Koizumi2010-12-241-1/+3
|
* - Fix a bug that the script gets wrongly converted into UTF-8 when the ↵Moriyoshi Koizumi2010-12-201-5/+1
| | | | script encoding is not GL-safe.
* WSMoriyoshi Koizumi2010-12-191-7/+7
|
* * Refactor zend_multibyte facility.Moriyoshi Koizumi2010-12-191-1131/+121
| | | | | Now mbstring.script_encoding is superseded by zend.script_encoding.
* Fixed startup errors if ext/exif is loaded without ext/mbstringDmitry Stogov2010-12-081-1/+2
|
* Removed compile time dependency from ext/mbstringDmitry Stogov2010-12-081-13/+43
|
* Added multibyte suppport by default. Previosly php had to be compiled with ↵Dmitry Stogov2010-11-241-3/+40
| | | | --enable-zend-multibyte. Now it can be enabled or disabled throug zend.multibyte directive in php.ini
* sed -i "s#1998-2009#1998-2010#g" **/*.c **/*.h **/*.phpSebastian Bergmann2010-01-051-1/+1
|
* - Add support for CP850 encoding (patch by Denis Giffeler)Moriyoshi Koizumi2009-03-181-0/+10
|
* - Typo.Moriyoshi Koizumi2009-03-181-2/+2
|
* - Add entries for the encodings that are already supported by mbstring butMoriyoshi Koizumi2009-03-181-0/+30
| | | | | not listed here.
* - staticise private symbols.Moriyoshi Koizumi2009-03-181-80/+80
|
* MFH: Bump copyright year, 3 of 3.Sebastian Bergmann2008-12-311-1/+1
|
* - Revived zend multibyteMoriyoshi Koizumi2008-07-241-46/+51
|
* MFH: Bump copyright year, 2 of 2.Sebastian Bergmann2007-12-311-1/+1
|
* MFH: Bump year.Sebastian Bergmann2007-01-011-1/+1
|
* - Update copyright notices to 2006Andi Gutmans2006-01-041-1/+1
|
* MFH: oopsfoobar2006-01-011-1/+1
|
* fix typofoobar2006-01-011-1/+1
|
* Fixed bug #35147 (__HALT_COMPILER() breaks with --enable-zend-multibyte)Dmitry Stogov2005-11-151-5/+7
|
* Bump up the yearfoobar2005-08-031-1/+1
|
* - Happy new year and PHP 5 for rest of the files too..foobar2004-01-081-1/+1
| | | | | # Should the LICENSE and Zend/LICENSE dates be updated too?
* - added script encoding support to Zend Engine 2.Masaki Fujimoto2003-08-111-0/+1133
| | | | | | | this enables ZE2 to gracefully parse scripts written in UTF-8 (with BOM), UTF-16, UTF-32, Shift_JIS, ISO-2022-JP etc... (when configured with '--enable-zend-multibyte' and '--enable-mbstring')
* - Add empty zend_multibyte.c to allow build with 4.3.0-dev.Andi Gutmans2002-05-261-0/+0