diff options
Diffstat (limited to 'Zend/zend_API.c')
| -rw-r--r-- | Zend/zend_API.c | 1722 |
1 files changed, 799 insertions, 923 deletions
diff --git a/Zend/zend_API.c b/Zend/zend_API.c index 553060e0a0..cc9275ead4 100644 --- a/Zend/zend_API.c +++ b/Zend/zend_API.c @@ -44,14 +44,14 @@ static zend_class_entry **class_cleanup_handlers; /* this function doesn't check for too many parameters */ ZEND_API int zend_get_parameters(int ht, int param_count, ...) /* {{{ */ { - void **p; + zval *p; int arg_count; va_list ptr; zval **param, *param_ptr; TSRMLS_FETCH(); p = zend_vm_stack_top(TSRMLS_C) - 1; - arg_count = (int)(zend_uintptr_t) *p; + arg_count = Z_LVAL_P(p); if (param_count>arg_count) { return FAILURE; @@ -61,17 +61,13 @@ ZEND_API int zend_get_parameters(int ht, int param_count, ...) /* {{{ */ while (param_count-->0) { param = va_arg(ptr, zval **); - param_ptr = *(p-arg_count); - if (!PZVAL_IS_REF(param_ptr) && Z_REFCOUNT_P(param_ptr) > 1) { - zval *new_tmp; - - ALLOC_ZVAL(new_tmp); - *new_tmp = *param_ptr; - zval_copy_ctor(new_tmp); - INIT_PZVAL(new_tmp); - param_ptr = new_tmp; - Z_DELREF_P((zval *) *(p-arg_count)); - *(p-arg_count) = param_ptr; + param_ptr = (p-arg_count); + if (!Z_ISREF_P(param_ptr) && Z_REFCOUNT_P(param_ptr) > 1) { + zval new_tmp; + + ZVAL_DUP(&new_tmp, param_ptr); + Z_DELREF_P(param_ptr); + ZVAL_COPY_VALUE(param_ptr, &new_tmp); } *param = param_ptr; arg_count--; @@ -82,33 +78,31 @@ ZEND_API int zend_get_parameters(int ht, int param_count, ...) /* {{{ */ } /* }}} */ -ZEND_API int _zend_get_parameters_array(int ht, int param_count, zval **argument_array TSRMLS_DC) /* {{{ */ +ZEND_API int _zend_get_parameters_array(int ht, int param_count, zval *argument_array TSRMLS_DC) /* {{{ */ { - void **p; + zval *p; int arg_count; zval *param_ptr; p = zend_vm_stack_top(TSRMLS_C) - 1; - arg_count = (int)(zend_uintptr_t) *p; + arg_count = Z_LVAL_P(p); if (param_count>arg_count) { return FAILURE; } while (param_count-->0) { - param_ptr = *(p-arg_count); - if (!PZVAL_IS_REF(param_ptr) && Z_REFCOUNT_P(param_ptr) > 1) { - zval *new_tmp; - - ALLOC_ZVAL(new_tmp); - *new_tmp = *param_ptr; - zval_copy_ctor(new_tmp); - INIT_PZVAL(new_tmp); - param_ptr = new_tmp; - Z_DELREF_P((zval *) *(p-arg_count)); - *(p-arg_count) = param_ptr; - } - *(argument_array++) = param_ptr; + param_ptr = (p-arg_count); + if (!Z_ISREF_P(param_ptr) && Z_REFCOUNT_P(param_ptr) > 1) { + zval new_tmp; + + ZVAL_DUP(&new_tmp, param_ptr); + Z_DELREF_P(param_ptr); + ZVAL_COPY_VALUE(argument_array, &new_tmp); + } else { + ZVAL_COPY_VALUE(argument_array, param_ptr); + } + argument_array++; arg_count--; } @@ -120,14 +114,14 @@ ZEND_API int _zend_get_parameters_array(int ht, int param_count, zval **argument /* this function doesn't check for too many parameters */ ZEND_API int zend_get_parameters_ex(int param_count, ...) /* {{{ */ { - void **p; + zval *p; int arg_count; va_list ptr; - zval ***param; + zval **param; TSRMLS_FETCH(); p = zend_vm_stack_top(TSRMLS_C) - 1; - arg_count = (int)(zend_uintptr_t) *p; + arg_count = Z_LVAL_P(p); if (param_count>arg_count) { return FAILURE; @@ -135,8 +129,8 @@ ZEND_API int zend_get_parameters_ex(int param_count, ...) /* {{{ */ va_start(ptr, param_count); while (param_count-->0) { - param = va_arg(ptr, zval ***); - *param = (zval **) p-(arg_count--); + param = va_arg(ptr, zval **); + *param = p-(arg_count--); } va_end(ptr); @@ -144,22 +138,23 @@ ZEND_API int zend_get_parameters_ex(int param_count, ...) /* {{{ */ } /* }}} */ -ZEND_API int _zend_get_parameters_array_ex(int param_count, zval ***argument_array TSRMLS_DC) /* {{{ */ +ZEND_API int _zend_get_parameters_array_ex(int param_count, zval *argument_array TSRMLS_DC) /* {{{ */ { - void **p; + zval *p; int arg_count; p = zend_vm_stack_top(TSRMLS_C) - 1; - arg_count = (int)(zend_uintptr_t) *p; + arg_count = Z_LVAL_P(p); if (param_count>arg_count) { return FAILURE; } while (param_count-->0) { - zval **value = (zval**)(p-arg_count); + zval *value = (p-arg_count); - *(argument_array++) = value; + ZVAL_COPY_VALUE(argument_array, value); + argument_array++; arg_count--; } @@ -169,20 +164,20 @@ ZEND_API int _zend_get_parameters_array_ex(int param_count, zval ***argument_arr ZEND_API int zend_copy_parameters_array(int param_count, zval *argument_array TSRMLS_DC) /* {{{ */ { - void **p; + zval *p; int arg_count; p = zend_vm_stack_top(TSRMLS_C) - 1; - arg_count = (int)(zend_uintptr_t) *p; + arg_count = Z_LVAL_P(p); if (param_count>arg_count) { return FAILURE; } while (param_count-->0) { - zval **param = (zval **) p-(arg_count--); - zval_add_ref(param); - add_next_index_zval(argument_array, *param); + zval *param = p-(arg_count--); + Z_ADDREF_P(param); + add_next_index_zval(argument_array, param); } return SUCCESS; @@ -244,65 +239,63 @@ ZEND_API zend_class_entry *zend_get_class_entry(const zval *zobject TSRMLS_DC) / /* }}} */ /* returns 1 if you need to copy result, 0 if it's already a copy */ -ZEND_API int zend_get_object_classname(const zval *object, const char **class_name, zend_uint *class_name_len TSRMLS_DC) /* {{{ */ +ZEND_API zend_string *zend_get_object_classname(const zval *object TSRMLS_DC) /* {{{ */ { - if (Z_OBJ_HT_P(object)->get_class_name == NULL || - Z_OBJ_HT_P(object)->get_class_name(object, class_name, class_name_len, 0 TSRMLS_CC) != SUCCESS) { - zend_class_entry *ce = Z_OBJCE_P(object); + zend_string *ret; - *class_name = ce->name; - *class_name_len = ce->name_length; - return 1; + if (Z_OBJ_HT_P(object)->get_class_name != NULL) { + ret = Z_OBJ_HT_P(object)->get_class_name(object, 0 TSRMLS_CC); + if (ret) { + return ret; + } } - return 0; + return Z_OBJCE_P(object)->name; } /* }}} */ -static int parse_arg_object_to_string(zval **arg, char **p, int *pl, int type TSRMLS_DC) /* {{{ */ +static int parse_arg_object_to_string(zval *arg, char **p, int *pl, int type TSRMLS_DC) /* {{{ */ { - if (Z_OBJ_HANDLER_PP(arg, cast_object)) { - zval *obj; - MAKE_STD_ZVAL(obj); - if (Z_OBJ_HANDLER_P(*arg, cast_object)(*arg, obj, type TSRMLS_CC) == SUCCESS) { + if (Z_OBJ_HANDLER_P(arg, cast_object)) { + zval obj; + if (Z_OBJ_HANDLER_P(arg, cast_object)(arg, &obj, type TSRMLS_CC) == SUCCESS) { zval_ptr_dtor(arg); - *arg = obj; - *pl = Z_STRLEN_PP(arg); - *p = Z_STRVAL_PP(arg); + ZVAL_COPY_VALUE(arg, &obj); + *pl = Z_STRLEN_P(arg); + *p = Z_STRVAL_P(arg); return SUCCESS; } - efree(obj); } /* Standard PHP objects */ - if (Z_OBJ_HT_PP(arg) == &std_object_handlers || !Z_OBJ_HANDLER_PP(arg, cast_object)) { + if (Z_OBJ_HT_P(arg) == &std_object_handlers || !Z_OBJ_HANDLER_P(arg, cast_object)) { SEPARATE_ZVAL_IF_NOT_REF(arg); - if (zend_std_cast_object_tostring(*arg, *arg, type TSRMLS_CC) == SUCCESS) { - *pl = Z_STRLEN_PP(arg); - *p = Z_STRVAL_PP(arg); + if (zend_std_cast_object_tostring(arg, arg, type TSRMLS_CC) == SUCCESS) { + *pl = Z_STRLEN_P(arg); + *p = Z_STRVAL_P(arg); return SUCCESS; } } - if (!Z_OBJ_HANDLER_PP(arg, cast_object) && Z_OBJ_HANDLER_PP(arg, get)) { + if (!Z_OBJ_HANDLER_P(arg, cast_object) && Z_OBJ_HANDLER_P(arg, get)) { int use_copy; - zval *z = Z_OBJ_HANDLER_PP(arg, get)(*arg TSRMLS_CC); + zval *z = Z_OBJ_HANDLER_P(arg, get)(arg TSRMLS_CC); Z_ADDREF_P(z); if(Z_TYPE_P(z) != IS_OBJECT) { - zval_dtor(*arg); - Z_TYPE_P(*arg) = IS_NULL; - zend_make_printable_zval(z, *arg, &use_copy); + zval_dtor(arg); + Z_TYPE_P(arg) = IS_NULL; + zend_make_printable_zval(z, arg, &use_copy); if (!use_copy) { - ZVAL_ZVAL(*arg, z, 1, 1); + ZVAL_ZVAL(arg, z, 1, 1); } - *pl = Z_STRLEN_PP(arg); - *p = Z_STRVAL_PP(arg); + *pl = Z_STRLEN_P(arg); + *p = Z_STRVAL_P(arg); return SUCCESS; } - zval_ptr_dtor(&z); + zval_ptr_dtor(z); } return FAILURE; } /* }}} */ -static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, const char **spec, char **error, int *severity TSRMLS_DC) /* {{{ */ +static const char *zend_parse_arg_impl(int arg_num, zval *arg, va_list *va, const char **spec, char **error, int *severity TSRMLS_DC) /* {{{ */ { const char *spec_walk = *spec; char c = *spec_walk++; @@ -328,16 +321,16 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con if (check_null) { zend_bool *p = va_arg(*va, zend_bool *); - *p = (Z_TYPE_PP(arg) == IS_NULL); + *p = (Z_TYPE_P(arg) == IS_NULL); } - switch (Z_TYPE_PP(arg)) { + switch (Z_TYPE_P(arg)) { case IS_STRING: { double d; int type; - if ((type = is_numeric_string(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), p, &d, -1)) == 0) { + if ((type = is_numeric_string(Z_STRVAL_P(arg), Z_STRLEN_P(arg), p, &d, -1)) == 0) { return "long"; } else if (type == IS_DOUBLE) { if (c == 'L') { @@ -357,10 +350,10 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case IS_DOUBLE: if (c == 'L') { - if (Z_DVAL_PP(arg) > LONG_MAX) { + if (Z_DVAL_P(arg) > LONG_MAX) { *p = LONG_MAX; break; - } else if (Z_DVAL_PP(arg) < LONG_MIN) { + } else if (Z_DVAL_P(arg) < LONG_MIN) { *p = LONG_MIN; break; } @@ -369,7 +362,7 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case IS_LONG: case IS_BOOL: convert_to_long_ex(arg); - *p = Z_LVAL_PP(arg); + *p = Z_LVAL_P(arg); break; case IS_ARRAY: @@ -387,16 +380,16 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con if (check_null) { zend_bool *p = va_arg(*va, zend_bool *); - *p = (Z_TYPE_PP(arg) == IS_NULL); + *p = (Z_TYPE_P(arg) == IS_NULL); } - switch (Z_TYPE_PP(arg)) { + switch (Z_TYPE_P(arg)) { case IS_STRING: { long l; int type; - if ((type = is_numeric_string(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), &l, p, -1)) == 0) { + if ((type = is_numeric_string(Z_STRVAL_P(arg), Z_STRLEN_P(arg), &l, p, -1)) == 0) { return "double"; } else if (type == IS_LONG) { *p = (double) l; @@ -409,7 +402,7 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case IS_DOUBLE: case IS_BOOL: convert_to_double_ex(arg); - *p = Z_DVAL_PP(arg); + *p = Z_DVAL_P(arg); break; case IS_ARRAY: @@ -426,7 +419,7 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con { char **p = va_arg(*va, char **); int *pl = va_arg(*va, int *); - switch (Z_TYPE_PP(arg)) { + switch (Z_TYPE_P(arg)) { case IS_NULL: if (check_null) { *p = NULL; @@ -440,22 +433,22 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case IS_DOUBLE: case IS_BOOL: convert_to_string_ex(arg); - if (UNEXPECTED(Z_ISREF_PP(arg) != 0)) { + if (UNEXPECTED(Z_ISREF_P(arg) != 0)) { /* it's dangerous to return pointers to string buffer of referenced variable, because it can be clobbered throug magic callbacks */ SEPARATE_ZVAL(arg); } - *p = Z_STRVAL_PP(arg); - *pl = Z_STRLEN_PP(arg); - if (c == 'p' && CHECK_ZVAL_NULL_PATH(*arg)) { + *p = Z_STRVAL_P(arg); + *pl = Z_STRLEN_P(arg); + if (c == 'p' && CHECK_ZVAL_NULL_PATH(arg)) { return "a valid path"; } break; case IS_OBJECT: if (parse_arg_object_to_string(arg, p, pl, IS_STRING TSRMLS_CC) == SUCCESS) { - if (c == 'p' && CHECK_ZVAL_NULL_PATH(*arg)) { + if (c == 'p' && CHECK_ZVAL_NULL_PATH(arg)) { return "a valid path"; } break; @@ -469,23 +462,65 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con } break; + case 'S': + { + zend_string **str = va_arg(*va, zend_string **); + switch (Z_TYPE_P(arg)) { + case IS_NULL: + if (check_null) { + *str = NULL; + break; + } + /* break omitted intentionally */ + + case IS_STRING: + case IS_LONG: + case IS_DOUBLE: + case IS_BOOL: + convert_to_string_ex(arg); + if (UNEXPECTED(Z_ISREF_P(arg) != 0)) { + /* it's dangerous to return pointers to string + buffer of referenced variable, because it can + be clobbered throug magic callbacks */ + SEPARATE_ZVAL(arg); + } + *str = Z_STR_P(arg); + break; + + case IS_OBJECT: { + char *p; + int pl; + + if (parse_arg_object_to_string(arg, &p, &pl, IS_STRING TSRMLS_CC) == SUCCESS) { + *str = STR_INIT(p, pl, 0); + break; + } + } + case IS_ARRAY: + case IS_RESOURCE: + default: + return "string"; + } + } + break; + case 'b': { zend_bool *p = va_arg(*va, zend_bool *); if (check_null) { zend_bool *p = va_arg(*va, zend_bool *); - *p = (Z_TYPE_PP(arg) == IS_NULL); + *p = (Z_TYPE_P(arg) == IS_NULL); } - switch (Z_TYPE_PP(arg)) { + switch (Z_TYPE_P(arg)) { case IS_NULL: case IS_STRING: case IS_LONG: case IS_DOUBLE: case IS_BOOL: convert_to_boolean_ex(arg); - *p = Z_BVAL_PP(arg); + *p = Z_BVAL_P(arg); break; case IS_ARRAY: @@ -500,12 +535,12 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'r': { zval **p = va_arg(*va, zval **); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; break; } - if (Z_TYPE_PP(arg) == IS_RESOURCE) { - *p = *arg; + if (Z_TYPE_P(arg) == IS_RESOURCE) { + *p = arg; } else { return "resource"; } @@ -515,12 +550,12 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'a': { zval **p = va_arg(*va, zval **); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; break; } - if (Z_TYPE_PP(arg) == IS_ARRAY || (c == 'A' && Z_TYPE_PP(arg) == IS_OBJECT)) { - *p = *arg; + if (Z_TYPE_P(arg) == IS_ARRAY || (c == 'A' && Z_TYPE_P(arg) == IS_OBJECT)) { + *p = arg; } else { return "array"; } @@ -530,14 +565,14 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'h': { HashTable **p = va_arg(*va, HashTable **); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; break; } - if (Z_TYPE_PP(arg) == IS_ARRAY) { - *p = Z_ARRVAL_PP(arg); - } else if(c == 'H' && Z_TYPE_PP(arg) == IS_OBJECT) { - *p = HASH_OF(*arg); + if (Z_TYPE_P(arg) == IS_ARRAY) { + *p = Z_ARRVAL_P(arg); + } else if(c == 'H' && Z_TYPE_P(arg) == IS_OBJECT) { + *p = HASH_OF(arg); if(*p == NULL) { return "array"; } @@ -550,12 +585,12 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'o': { zval **p = va_arg(*va, zval **); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; break; } - if (Z_TYPE_PP(arg) == IS_OBJECT) { - *p = *arg; + if (Z_TYPE_P(arg) == IS_OBJECT) { + *p = arg; } else { return "object"; } @@ -567,16 +602,16 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con zval **p = va_arg(*va, zval **); zend_class_entry *ce = va_arg(*va, zend_class_entry *); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; break; } - if (Z_TYPE_PP(arg) == IS_OBJECT && - (!ce || instanceof_function(Z_OBJCE_PP(arg), ce TSRMLS_CC))) { - *p = *arg; + if (Z_TYPE_P(arg) == IS_OBJECT && + (!ce || instanceof_function(Z_OBJCE_P(arg), ce TSRMLS_CC))) { + *p = arg; } else { if (ce) { - return ce->name; + return ce->name->val; } else { return "object"; } @@ -586,30 +621,30 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'C': { - zend_class_entry **lookup, **pce = va_arg(*va, zend_class_entry **); + zend_class_entry *lookup, **pce = va_arg(*va, zend_class_entry **); zend_class_entry *ce_base = *pce; - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *pce = NULL; break; } convert_to_string_ex(arg); - if (zend_lookup_class(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), &lookup TSRMLS_CC) == FAILURE) { + if ((lookup = zend_lookup_class(Z_STR_P(arg) TSRMLS_CC)) == NULL) { *pce = NULL; } else { - *pce = *lookup; + *pce = lookup; } if (ce_base) { if ((!*pce || !instanceof_function(*pce, ce_base TSRMLS_CC))) { zend_spprintf(error, 0, "to be a class name derived from %s, '%s' given", - ce_base->name, Z_STRVAL_PP(arg)); + ce_base->name, Z_STRVAL_P(arg)); *pce = NULL; return ""; } } if (!*pce) { zend_spprintf(error, 0, "to be a valid class name, '%s' given", - Z_STRVAL_PP(arg)); + Z_STRVAL_P(arg)); return ""; } break; @@ -623,13 +658,13 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con zend_fcall_info_cache *fcc = va_arg(*va, zend_fcall_info_cache *); char *is_callable_error = NULL; - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { fci->size = 0; fcc->initialized = 0; break; } - if (zend_fcall_info_init(*arg, 0, fci, fcc, NULL, &is_callable_error TSRMLS_CC) == SUCCESS) { + if (zend_fcall_info_init(arg, 0, fci, fcc, NULL, &is_callable_error TSRMLS_CC) == SUCCESS) { if (is_callable_error) { *severity = E_STRICT; zend_spprintf(error, 0, "to be a valid callback, %s", is_callable_error); @@ -653,18 +688,7 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con case 'z': { zval **p = va_arg(*va, zval **); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { - *p = NULL; - } else { - *p = *arg; - } - } - break; - - case 'Z': - { - zval ***p = va_arg(*va, zval ***); - if (check_null && Z_TYPE_PP(arg) == IS_NULL) { + if (check_null && Z_TYPE_P(arg) == IS_NULL) { *p = NULL; } else { *p = arg; @@ -672,6 +696,8 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con } break; +//??? + case 'Z': default: return "unknown"; } @@ -682,7 +708,7 @@ static const char *zend_parse_arg_impl(int arg_num, zval **arg, va_list *va, con } /* }}} */ -static int zend_parse_arg(int arg_num, zval **arg, va_list *va, const char **spec, int quiet TSRMLS_DC) /* {{{ */ +static int zend_parse_arg(int arg_num, zval *arg, va_list *va, const char **spec, int quiet TSRMLS_DC) /* {{{ */ { const char *expected_type = NULL; char *error = NULL; @@ -701,7 +727,7 @@ static int zend_parse_arg(int arg_num, zval **arg, va_list *va, const char **spe } else { zend_error(severity, "%s%s%s() expects parameter %d to be %s, %s given", class_name, space, get_active_function_name(TSRMLS_C), arg_num, expected_type, - zend_zval_type_name(*arg)); + zend_zval_type_name(arg)); } } if (severity != E_STRICT) { @@ -713,7 +739,7 @@ static int zend_parse_arg(int arg_num, zval **arg, va_list *va, const char **spe } /* }}} */ -ZEND_API int zend_parse_parameter(int flags, int arg_num TSRMLS_DC, zval **arg, const char *spec, ...) +ZEND_API int zend_parse_parameter(int flags, int arg_num TSRMLS_DC, zval *arg, const char *spec, ...) { va_list va; int ret; @@ -733,11 +759,11 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, int min_num_args = -1; int max_num_args = 0; int post_varargs = 0; - zval **arg; + zval *arg; int arg_count; int quiet = flags & ZEND_PARSE_PARAMS_QUIET; zend_bool have_varargs = 0; - zval ****varargs = NULL; + zval ***varargs = NULL; int *n_varargs = NULL; for (spec_walk = type_spec; *spec_walk; spec_walk++) { @@ -751,6 +777,7 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, case 'C': case 'h': case 'f': case 'A': case 'H': case 'p': + case 'S': max_num_args++; break; @@ -768,11 +795,11 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, if (have_varargs) { if (!quiet) { zend_function *active_function = EG(current_execute_data)->function_state.function; - const char *class_name = active_function->common.scope ? active_function->common.scope->name : ""; + const char *class_name = active_function->common.scope ? active_function->common.scope->name->val : ""; zend_error(E_WARNING, "%s%s%s(): only one varargs specifier (* or +) is permitted", class_name, class_name[0] ? "::" : "", - active_function->common.function_name); + active_function->common.function_name->val); } return FAILURE; } @@ -788,11 +815,11 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, default: if (!quiet) { zend_function *active_function = EG(current_execute_data)->function_state.function; - const char *class_name = active_function->common.scope ? active_function->common.scope->name : ""; + const char *class_name = active_function->common.scope ? active_function->common.scope->name->val : ""; zend_error(E_WARNING, "%s%s%s(): bad type specifier while parsing parameters", class_name, class_name[0] ? "::" : "", - active_function->common.function_name); + active_function->common.function_name->val); } return FAILURE; } @@ -811,11 +838,11 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, if (num_args < min_num_args || (num_args > max_num_args && max_num_args > 0)) { if (!quiet) { zend_function *active_function = EG(current_execute_data)->function_state.function; - const char *class_name = active_function->common.scope ? active_function->common.scope->name : ""; + const char *class_name = active_function->common.scope ? active_function->common.scope->name->val : ""; zend_error(E_WARNING, "%s%s%s() expects %s %d parameter%s, %d given", class_name, class_name[0] ? "::" : "", - active_function->common.function_name, + active_function->common.function_name->val, min_num_args == max_num_args ? "exactly" : num_args < min_num_args ? "at least" : "at most", num_args < min_num_args ? min_num_args : max_num_args, (num_args < min_num_args ? min_num_args : max_num_args) == 1 ? "" : "s", @@ -824,7 +851,7 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, return FAILURE; } - arg_count = (int)(zend_uintptr_t) *(zend_vm_stack_top(TSRMLS_C) - 1); + arg_count = Z_LVAL_P(zend_vm_stack_top(TSRMLS_C) - 1); if (num_args > arg_count) { zend_error(E_WARNING, "%s(): could not obtain parameters for parsing", @@ -842,18 +869,18 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, int num_varargs = num_args + 1 - post_varargs; /* eat up the passed in storage even if it won't be filled in with varargs */ - varargs = va_arg(*va, zval ****); + varargs = va_arg(*va, zval ***); n_varargs = va_arg(*va, int *); type_spec++; if (num_varargs > 0) { int iv = 0; - zval **p = (zval **) (zend_vm_stack_top(TSRMLS_C) - 1 - (arg_count - i)); + zval *p = (zend_vm_stack_top(TSRMLS_C) - 1 - (arg_count - i)); *n_varargs = num_varargs; /* allocate space for array and store args */ - *varargs = safe_emalloc(num_varargs, sizeof(zval **), 0); + *varargs = safe_emalloc(num_varargs, sizeof(zval *), 0); while (num_varargs-- > 0) { (*varargs)[iv++] = p++; } @@ -868,7 +895,7 @@ static int zend_parse_va_args(int num_args, const char *type_spec, va_list *va, } } - arg = (zval **) (zend_vm_stack_top(TSRMLS_C) - 1 - (arg_count-i)); + arg = zend_vm_stack_top(TSRMLS_C) - 1 - (arg_count-i); if (zend_parse_arg(i+1, arg, va, &type_spec, quiet TSRMLS_CC) == FAILURE) { /* clean up varargs array if it was used */ @@ -954,7 +981,7 @@ ZEND_API int zend_parse_method_parameters(int num_args TSRMLS_DC, zval *this_ptr if (ce && !instanceof_function(Z_OBJCE_P(this_ptr), ce TSRMLS_CC)) { zend_error(E_CORE_ERROR, "%s::%s() must be derived from %s::%s", - ce->name, get_active_function_name(TSRMLS_C), Z_OBJCE_P(this_ptr)->name, get_active_function_name(TSRMLS_C)); + ce->name->val, get_active_function_name(TSRMLS_C), Z_OBJCE_P(this_ptr)->name->val, get_active_function_name(TSRMLS_C)); } retval = zend_parse_va_args(num_args, p, &va, 0 TSRMLS_CC); @@ -992,7 +1019,7 @@ ZEND_API int zend_parse_method_parameters_ex(int flags, int num_args TSRMLS_DC, if (ce && !instanceof_function(Z_OBJCE_P(this_ptr), ce TSRMLS_CC)) { if (!quiet) { zend_error(E_CORE_ERROR, "%s::%s() must be derived from %s::%s", - ce->name, get_active_function_name(TSRMLS_C), Z_OBJCE_P(this_ptr)->name, get_active_function_name(TSRMLS_C)); + ce->name->val, get_active_function_name(TSRMLS_C), Z_OBJCE_P(this_ptr)->name->val, get_active_function_name(TSRMLS_C)); } va_end(va); return FAILURE; @@ -1008,25 +1035,22 @@ ZEND_API int zend_parse_method_parameters_ex(int flags, int num_args TSRMLS_DC, /* Argument parsing API -- andrei */ ZEND_API int _array_init(zval *arg, uint size ZEND_FILE_LINE_DC) /* {{{ */ { - ALLOC_HASHTABLE_REL(Z_ARRVAL_P(arg)); - + ZVAL_NEW_ARR(arg); _zend_hash_init(Z_ARRVAL_P(arg), size, ZVAL_PTR_DTOR, 0 ZEND_FILE_LINE_RELAY_CC); - Z_TYPE_P(arg) = IS_ARRAY; return SUCCESS; } /* }}} */ -static int zend_merge_property(zval **value TSRMLS_DC, int num_args, va_list args, const zend_hash_key *hash_key) /* {{{ */ +static int zend_merge_property(zval *value TSRMLS_DC, int num_args, va_list args, const zend_hash_key *hash_key) /* {{{ */ { /* which name should a numeric property have ? */ - if (hash_key->nKeyLength) { + if (hash_key->key) { zval *obj = va_arg(args, zval *); zend_object_handlers *obj_ht = va_arg(args, zend_object_handlers *); - zval *member; + zval member; - MAKE_STD_ZVAL(member); - ZVAL_STRINGL(member, hash_key->arKey, hash_key->nKeyLength-1, 1); - obj_ht->write_property(obj, member, *value, 0 TSRMLS_CC); + ZVAL_STR(&member, STR_DUP(hash_key->key, 0)); + obj_ht->write_property(obj, &member, value, 0 TSRMLS_CC); zval_ptr_dtor(&member); } return ZEND_HASH_APPLY_KEEP; @@ -1051,9 +1075,9 @@ ZEND_API void zend_merge_properties(zval *obj, HashTable *properties, int destro } /* }}} */ -static int zval_update_class_constant(zval **pp, int is_static, int offset TSRMLS_DC) /* {{{ */ +static int zval_update_class_constant(zval *pp, int is_static, int offset TSRMLS_DC) /* {{{ */ { - if (IS_CONSTANT_TYPE(Z_TYPE_PP(pp))) { + if (IS_CONSTANT_TYPE(Z_TYPE_P(pp))) { zend_class_entry **scope = EG(in_execution)?&EG(scope):&CG(active_class_entry); if ((*scope)->parent) { @@ -1063,7 +1087,7 @@ static int zval_update_class_constant(zval **pp, int is_static, int offset TSRML do { for (zend_hash_internal_pointer_reset_ex(&ce->properties_info, &pos); - zend_hash_get_current_data_ex(&ce->properties_info, (void **) &prop_info, &pos) == SUCCESS; + (prop_info = zend_hash_get_current_data_ptr_ex(&ce->properties_info, &pos)) != NULL; zend_hash_move_forward_ex(&ce->properties_info, &pos)) { if (is_static == ((prop_info->flags & ZEND_ACC_STATIC) != 0) && offset == prop_info->offset) { @@ -1096,13 +1120,13 @@ ZEND_API void zend_update_class_constants(zend_class_entry *class_type TSRMLS_DC zend_hash_apply_with_argument(&class_type->constants_table, (apply_func_arg_t) zval_update_constant, (void*)1 TSRMLS_CC); for (i = 0; i < class_type->default_properties_count; i++) { - if (class_type->default_properties_table[i]) { + if (Z_TYPE(class_type->default_properties_table[i]) != IS_UNDEF) { zval_update_class_constant(&class_type->default_properties_table[i], 0, i TSRMLS_CC); } } if (!CE_STATIC_MEMBERS(class_type) && class_type->default_static_members_count) { - zval **p; + zval *p; if (class_type->parent) { zend_update_class_constants(class_type->parent TSRMLS_CC); @@ -1114,25 +1138,19 @@ ZEND_API void zend_update_class_constants(zend_class_entry *class_type TSRMLS_DC #endif for (i = 0; i < class_type->default_static_members_count; i++) { p = &class_type->default_static_members_table[i]; - if (Z_ISREF_PP(p) && + if (Z_ISREF_P(p) && class_type->parent && i < class_type->parent->default_static_members_count && - *p == class_type->parent->default_static_members_table[i] && - CE_STATIC_MEMBERS(class_type->parent)[i] + p == &class_type->parent->default_static_members_table[i] && + Z_TYPE(CE_STATIC_MEMBERS(class_type->parent)[i]) != IS_UNDEF ) { - zval *q = CE_STATIC_MEMBERS(class_type->parent)[i]; + zval *q = &CE_STATIC_MEMBERS(class_type->parent)[i]; + ZVAL_NEW_REF(q, q); + ZVAL_COPY_VALUE(&CE_STATIC_MEMBERS(class_type)[i], q); Z_ADDREF_P(q); - Z_SET_ISREF_P(q); - CE_STATIC_MEMBERS(class_type)[i] = q; } else { - zval *r; - - ALLOC_ZVAL(r); - *r = **p; - INIT_PZVAL(r); - zval_copy_ctor(r); - CE_STATIC_MEMBERS(class_type)[i] = r; + ZVAL_DUP(&CE_STATIC_MEMBERS(class_type)[i], p); } } } @@ -1152,15 +1170,15 @@ ZEND_API void object_properties_init(zend_object *object, zend_class_entry *clas int i; if (class_type->default_properties_count) { - object->properties_table = emalloc(sizeof(zval*) * class_type->default_properties_count); +//??? object->properties_table = emalloc(sizeof(zval*) * class_type->default_properties_count); for (i = 0; i < class_type->default_properties_count; i++) { - object->properties_table[i] = class_type->default_properties_table[i]; - if (class_type->default_properties_table[i]) { + ZVAL_COPY_VALUE(&object->properties_table[i], &class_type->default_properties_table[i]); + if (Z_REFCOUNTED(class_type->default_properties_table[i])) { #if ZTS ALLOC_ZVAL( object->properties_table[i]); MAKE_COPY_ZVAL(&class_type->default_properties_table[i], object->properties_table[i]); #else - Z_ADDREF_P(object->properties_table[i]); + Z_ADDREF(object->properties_table[i]); #endif } } @@ -1175,28 +1193,25 @@ ZEND_API void object_properties_init(zend_object *object, zend_class_entry *clas * calling zend_merge_properties(). */ ZEND_API int _object_and_properties_init(zval *arg, zend_class_entry *class_type, HashTable *properties ZEND_FILE_LINE_DC TSRMLS_DC) /* {{{ */ { - zend_object *object; - if (class_type->ce_flags & (ZEND_ACC_INTERFACE|ZEND_ACC_IMPLICIT_ABSTRACT_CLASS|ZEND_ACC_EXPLICIT_ABSTRACT_CLASS)) { char *what = (class_type->ce_flags & ZEND_ACC_INTERFACE) ? "interface" :((class_type->ce_flags & ZEND_ACC_TRAIT) == ZEND_ACC_TRAIT) ? "trait" : "abstract class"; - zend_error(E_ERROR, "Cannot instantiate %s %s", what, class_type->name); + zend_error(E_ERROR, "Cannot instantiate %s %s", what, class_type->name->val); } zend_update_class_constants(class_type TSRMLS_CC); - Z_TYPE_P(arg) = IS_OBJECT; if (class_type->create_object == NULL) { - Z_OBJVAL_P(arg) = zend_objects_new(&object, class_type TSRMLS_CC); + ZVAL_OBJ(arg, zend_objects_new(class_type TSRMLS_CC)); if (properties) { - object->properties = properties; - object->properties_table = NULL; + Z_OBJ_P(arg)->properties = properties; +//??? Z_OBJ_P(arg)->properties_table = NULL; } else { - object_properties_init(object, class_type); + object_properties_init(Z_OBJ_P(arg), class_type); } } else { - Z_OBJVAL_P(arg) = class_type->create_object(class_type TSRMLS_CC); + ZVAL_OBJ(arg, class_type->create_object(class_type TSRMLS_CC)); } return SUCCESS; } @@ -1223,365 +1238,361 @@ ZEND_API int add_assoc_function(zval *arg, const char *key, void (*function_ptr) ZEND_API int add_assoc_long_ex(zval *arg, const char *key, uint key_len, long n) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_LONG(tmp, n); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + + ZVAL_LONG(&tmp, n); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_null_ex(zval *arg, const char *key, uint key_len) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_NULL(tmp); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + + ZVAL_NULL(&tmp); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_bool_ex(zval *arg, const char *key, uint key_len, int b) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_BOOL(tmp, b); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + + ZVAL_BOOL(&tmp, b); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ -ZEND_API int add_assoc_resource_ex(zval *arg, const char *key, uint key_len, int r) /* {{{ */ +ZEND_API int add_assoc_resource_ex(zval *arg, const char *key, uint key_len, zend_resource *r) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_RESOURCE(tmp, r); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + + ZVAL_RES(&tmp, r); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_double_ex(zval *arg, const char *key, uint key_len, double d) /* {{{ */ { - zval *tmp; + zval *ret, tmp; + + ZVAL_DOUBLE(&tmp, d); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; +} +/* }}} */ - MAKE_STD_ZVAL(tmp); - ZVAL_DOUBLE(tmp, d); +ZEND_API int add_assoc_str_ex(zval *arg, const char *key, uint key_len, zend_string *str) /* {{{ */ +{ + zval *ret, tmp; - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_STR(&tmp, str); + STR_ADDREF(str); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_string_ex(zval *arg, const char *key, uint key_len, char *str, int duplicate) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_stringl_ex(zval *arg, const char *key, uint key_len, char *str, uint length, int duplicate) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), NULL); + zval *ret, tmp; + +//??? ZVAL_STRINGL(tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_assoc_zval_ex(zval *arg, const char *key, uint key_len, zval *value) /* {{{ */ { - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &value, sizeof(zval *), NULL); + zval *ret; + + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, value); + return ret ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_long(zval *arg, ulong index, long n) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_LONG(tmp, n); - - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_LONG(&tmp, n); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_null(zval *arg, ulong index) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_NULL(tmp); + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_NULL(&tmp); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_bool(zval *arg, ulong index, int b) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_BOOL(tmp, b); + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_BOOL(&tmp, b); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ -ZEND_API int add_index_resource(zval *arg, ulong index, int r) /* {{{ */ +ZEND_API int add_index_resource(zval *arg, ulong index, zend_resource *r) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_RESOURCE(tmp, r); - - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_RES(&tmp, r); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_double(zval *arg, ulong index, double d) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_DOUBLE(tmp, d); + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + ZVAL_DOUBLE(&tmp, d); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_string(zval *arg, ulong index, const char *str, int duplicate) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); - - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_stringl(zval *arg, ulong index, const char *str, uint length, int duplicate) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); +//??? ZVAL_STRINGL(tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), NULL); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_index_zval(zval *arg, ulong index, zval *value) /* {{{ */ { - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &value, sizeof(zval *), NULL); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, value) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_long(zval *arg, long n) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_LONG(tmp, n); + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); + ZVAL_LONG(&tmp, n); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_null(zval *arg) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_NULL(tmp); - - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); + ZVAL_NULL(&tmp); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_bool(zval *arg, int b) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_BOOL(tmp, b); + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); + ZVAL_BOOL(&tmp, b); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ -ZEND_API int add_next_index_resource(zval *arg, int r) /* {{{ */ +ZEND_API int add_next_index_resource(zval *arg, zend_resource *r) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_RESOURCE(tmp, r); + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); + ZVAL_RES(&tmp, r); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_double(zval *arg, double d) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_DOUBLE(tmp, d); + ZVAL_DOUBLE(&tmp, d); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; +} +/* }}} */ + +ZEND_API int add_next_index_str(zval *arg, zend_string *str) /* {{{ */ +{ + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); + ZVAL_STR(&tmp, STR_COPY(str)); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_string(zval *arg, const char *str, int duplicate) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); +//??? ZVAL_STRING(&tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_stringl(zval *arg, const char *str, uint length, int duplicate) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); + zval tmp; - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp, sizeof(zval *), NULL); +//??? ZVAL_STRINGL(&tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &tmp) ? SUCCESS : FAILURE; } /* }}} */ ZEND_API int add_next_index_zval(zval *arg, zval *value) /* {{{ */ { - return zend_hash_next_index_insert(Z_ARRVAL_P(arg), &value, sizeof(zval *), NULL); + return zend_hash_next_index_insert(Z_ARRVAL_P(arg), value) ? SUCCESS : FAILURE; } /* }}} */ -ZEND_API int add_get_assoc_string_ex(zval *arg, const char *key, uint key_len, const char *str, void **dest, int duplicate) /* {{{ */ +ZEND_API zval *add_get_assoc_string_ex(zval *arg, const char *key, uint key_len, const char *str, int duplicate) /* {{{ */ { - zval *tmp; + zval tmp, *ret; - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), dest); +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret; } /* }}} */ -ZEND_API int add_get_assoc_stringl_ex(zval *arg, const char *key, uint key_len, const char *str, uint length, void **dest, int duplicate) /* {{{ */ +ZEND_API zval *add_get_assoc_stringl_ex(zval *arg, const char *key, uint key_len, const char *str, uint length, int duplicate) /* {{{ */ { - zval *tmp; + zval tmp, *ret; - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); - - return zend_symtable_update(Z_ARRVAL_P(arg), key, key_len, (void *) &tmp, sizeof(zval *), dest); +//??? ZVAL_STRING(tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); + ret = zend_symtable_str_update(Z_ARRVAL_P(arg), key, key_len, &tmp); + return ret; } /* }}} */ -ZEND_API int add_get_index_long(zval *arg, ulong index, long l, void **dest) /* {{{ */ +ZEND_API zval *add_get_index_long(zval *arg, ulong index, long l) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_LONG(tmp, l); - - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), dest); + ZVAL_LONG(&tmp, l); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp); } /* }}} */ -ZEND_API int add_get_index_double(zval *arg, ulong index, double d, void **dest) /* {{{ */ +ZEND_API zval *add_get_index_double(zval *arg, ulong index, double d) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_DOUBLE(tmp, d); + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), dest); + ZVAL_DOUBLE(&tmp, d); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp); } /* }}} */ -ZEND_API int add_get_index_string(zval *arg, ulong index, const char *str, void **dest, int duplicate) /* {{{ */ +ZEND_API zval *add_get_index_str(zval *arg, ulong index, zend_string *str) /* {{{ */ { - zval *tmp; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), dest); +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STR(&tmp, STR_COPY(str)); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp); } /* }}} */ -ZEND_API int add_get_index_stringl(zval *arg, ulong index, const char *str, uint length, void **dest, int duplicate) /* {{{ */ +ZEND_API zval *add_get_index_string(zval *arg, ulong index, const char *str, int duplicate) /* {{{ */ { - zval *tmp; + zval tmp; - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp); +} +/* }}} */ + +ZEND_API zval *add_get_index_stringl(zval *arg, ulong index, const char *str, uint length, int duplicate) /* {{{ */ +{ + zval tmp; - return zend_hash_index_update(Z_ARRVAL_P(arg), index, (void *) &tmp, sizeof(zval *), dest); +//??? ZVAL_STRINGL(tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); + return zend_hash_index_update(Z_ARRVAL_P(arg), index, &tmp); } /* }}} */ ZEND_API int array_set_zval_key(HashTable *ht, zval *key, zval *value) /* {{{ */ { - int result; + zval *result; switch (Z_TYPE_P(key)) { case IS_STRING: - result = zend_symtable_update(ht, Z_STRVAL_P(key), Z_STRLEN_P(key) + 1, &value, sizeof(zval *), NULL); + result = zend_symtable_update(ht, Z_STR_P(key), value); break; case IS_NULL: - result = zend_symtable_update(ht, "", 1, &value, sizeof(zval *), NULL); + result = zend_symtable_update(ht, STR_EMPTY_ALLOC(), value); break; case IS_RESOURCE: zend_error(E_STRICT, "Resource ID#%ld used as offset, casting to integer (%ld)", Z_LVAL_P(key), Z_LVAL_P(key)); /* break missing intentionally */ case IS_BOOL: case IS_LONG: - result = zend_hash_index_update(ht, Z_LVAL_P(key), &value, sizeof(zval *), NULL); + result = zend_hash_index_update(ht, Z_LVAL_P(key), value); break; case IS_DOUBLE: - result = zend_hash_index_update(ht, zend_dval_to_lval(Z_DVAL_P(key)), &value, sizeof(zval *), NULL); + result = zend_hash_index_update(ht, zend_dval_to_lval(Z_DVAL_P(key)), value); break; default: zend_error(E_WARNING, "Illegal offset type"); - result = FAILURE; + result = NULL; } - if (result == SUCCESS) { - Z_ADDREF_P(value); + if (result) { + Z_ADDREF_P(result); + return SUCCESS; + } else { + return FAILURE; } - - return result; } /* }}} */ ZEND_API int add_property_long_ex(zval *arg, const char *key, uint key_len, long n TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; - - MAKE_STD_ZVAL(tmp); - ZVAL_LONG(tmp, n); + zval tmp; + zval z_key; - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); - - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); + ZVAL_LONG(&tmp, n); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1590,16 +1601,12 @@ ZEND_API int add_property_long_ex(zval *arg, const char *key, uint key_len, long ZEND_API int add_property_bool_ex(zval *arg, const char *key, uint key_len, int b TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; - - MAKE_STD_ZVAL(tmp); - ZVAL_BOOL(tmp, b); - - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); + zval tmp; + zval z_key; - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); + ZVAL_BOOL(&tmp, b); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1608,34 +1615,26 @@ ZEND_API int add_property_bool_ex(zval *arg, const char *key, uint key_len, int ZEND_API int add_property_null_ex(zval *arg, const char *key, uint key_len TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; + zval tmp; + zval z_key; - MAKE_STD_ZVAL(tmp); - ZVAL_NULL(tmp); - - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); - - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); + ZVAL_NULL(&tmp); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; } /* }}} */ -ZEND_API int add_property_resource_ex(zval *arg, const char *key, uint key_len, long n TSRMLS_DC) /* {{{ */ +ZEND_API int add_property_resource_ex(zval *arg, const char *key, uint key_len, zend_resource *r TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; - - MAKE_STD_ZVAL(tmp); - ZVAL_RESOURCE(tmp, n); - - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); + zval tmp; + zval z_key; - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); + ZVAL_RES(&tmp, r); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1644,16 +1643,12 @@ ZEND_API int add_property_resource_ex(zval *arg, const char *key, uint key_len, ZEND_API int add_property_double_ex(zval *arg, const char *key, uint key_len, double d TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; + zval tmp; + zval z_key; - MAKE_STD_ZVAL(tmp); - ZVAL_DOUBLE(tmp, d); - - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); - - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); + ZVAL_DOUBLE(&tmp, d); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1662,16 +1657,13 @@ ZEND_API int add_property_double_ex(zval *arg, const char *key, uint key_len, do ZEND_API int add_property_string_ex(zval *arg, const char *key, uint key_len, const char *str, int duplicate TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRING(tmp, str, duplicate); + zval tmp; + zval z_key; - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); - - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); +//??? ZVAL_STRING(tmp, str, duplicate); + ZVAL_STRING(&tmp, str); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1680,16 +1672,13 @@ ZEND_API int add_property_string_ex(zval *arg, const char *key, uint key_len, co ZEND_API int add_property_stringl_ex(zval *arg, const char *key, uint key_len, const char *str, uint length, int duplicate TSRMLS_DC) /* {{{ */ { - zval *tmp; - zval *z_key; - - MAKE_STD_ZVAL(tmp); - ZVAL_STRINGL(tmp, str, length, duplicate); + zval tmp; + zval z_key; - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); - - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, tmp, 0 TSRMLS_CC); +//??? ZVAL_STRINGL(tmp, str, length, duplicate); + ZVAL_STRINGL(&tmp, str, length); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, &tmp, 0 TSRMLS_CC); zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */ zval_ptr_dtor(&z_key); return SUCCESS; @@ -1698,12 +1687,10 @@ ZEND_API int add_property_stringl_ex(zval *arg, const char *key, uint key_len, c ZEND_API int add_property_zval_ex(zval *arg, const char *key, uint key_len, zval *value TSRMLS_DC) /* {{{ */ { - zval *z_key; - - MAKE_STD_ZVAL(z_key); - ZVAL_STRINGL(z_key, key, key_len-1, 1); + zval z_key; - Z_OBJ_HANDLER_P(arg, write_property)(arg, z_key, value, 0 TSRMLS_CC); + ZVAL_STRINGL(&z_key, key, key_len-1); + Z_OBJ_HANDLER_P(arg, write_property)(arg, &z_key, value, 0 TSRMLS_CC); zval_ptr_dtor(&z_key); return SUCCESS; } @@ -1712,7 +1699,7 @@ ZEND_API int add_property_zval_ex(zval *arg, const char *key, uint key_len, zval ZEND_API int zend_startup_module_ex(zend_module_entry *module TSRMLS_DC) /* {{{ */ { int name_len; - char *lcname; + zend_string *lcname; if (module->module_started) { return SUCCESS; @@ -1728,16 +1715,17 @@ ZEND_API int zend_startup_module_ex(zend_module_entry *module TSRMLS_DC) /* {{{ zend_module_entry *req_mod; name_len = strlen(dep->name); - lcname = zend_str_tolower_dup(dep->name, name_len); + lcname = STR_ALLOC(name_len, 0); + zend_str_tolower_copy(lcname->val, dep->name, name_len); - if (zend_hash_find(&module_registry, lcname, name_len+1, (void**)&req_mod) == FAILURE || !req_mod->module_started) { - efree(lcname); + if ((req_mod = zend_hash_find_ptr(&module_registry, lcname)) == NULL || !req_mod->module_started) { + STR_FREE(lcname); /* TODO: Check version relationship */ zend_error(E_CORE_WARNING, "Cannot load module '%s' because required module '%s' is not loaded", module->name, dep->name); module->module_started = 0; return FAILURE; } - efree(lcname); + STR_FREE(lcname); } ++dep; } @@ -1768,22 +1756,22 @@ ZEND_API int zend_startup_module_ex(zend_module_entry *module TSRMLS_DC) /* {{{ static void zend_sort_modules(void *base, size_t count, size_t siz, compare_func_t compare TSRMLS_DC) /* {{{ */ { - Bucket **b1 = base; - Bucket **b2; - Bucket **end = b1 + count; - Bucket *tmp; + Bucket *b1 = base; + Bucket *b2; + Bucket *end = b1 + count; + Bucket tmp; zend_module_entry *m, *r; while (b1 < end) { try_again: - m = (zend_module_entry*)(*b1)->pData; + m = (zend_module_entry*)Z_PTR(b1->val); if (!m->module_started && m->deps) { const zend_module_dep *dep = m->deps; while (dep->name) { if (dep->type == MODULE_DEP_REQUIRED || dep->type == MODULE_DEP_OPTIONAL) { b2 = b1 + 1; while (b2 < end) { - r = (zend_module_entry*)(*b2)->pData; + r = (zend_module_entry*)Z_PTR(b2->val); if (strcasecmp(dep->name, r->name) == 0) { tmp = *b1; *b1 = *b2; @@ -1813,7 +1801,7 @@ ZEND_API void zend_collect_module_handlers(TSRMLS_D) /* {{{ */ /* Collect extensions with request startup/shutdown handlers */ for (zend_hash_internal_pointer_reset_ex(&module_registry, &pos); - zend_hash_get_current_data_ex(&module_registry, (void *) &module, &pos) == SUCCESS; + (module = zend_hash_get_current_data_ptr_ex(&module_registry, &pos)) != NULL; zend_hash_move_forward_ex(&module_registry, &pos)) { if (module->request_startup_func) { startup_count++; @@ -1838,7 +1826,7 @@ ZEND_API void zend_collect_module_handlers(TSRMLS_D) /* {{{ */ startup_count = 0; for (zend_hash_internal_pointer_reset_ex(&module_registry, &pos); - zend_hash_get_current_data_ex(&module_registry, (void *) &module, &pos) == SUCCESS; + (module = zend_hash_get_current_data_ptr_ex(&module_registry, &pos)) != NULL; zend_hash_move_forward_ex(&module_registry, &pos)) { if (module->request_startup_func) { module_request_startup_handlers[startup_count++] = module; @@ -1853,7 +1841,7 @@ ZEND_API void zend_collect_module_handlers(TSRMLS_D) /* {{{ */ /* Collect internal classes with static members */ for (zend_hash_internal_pointer_reset_ex(CG(class_table), &pos); - zend_hash_get_current_data_ex(CG(class_table), (void *) &pce, &pos) == SUCCESS; + (pce = zend_hash_get_current_data_ptr_ex(CG(class_table), &pos)) != NULL; zend_hash_move_forward_ex(CG(class_table), &pos)) { if ((*pce)->type == ZEND_INTERNAL_CLASS && (*pce)->default_static_members_count > 0) { @@ -1868,7 +1856,7 @@ ZEND_API void zend_collect_module_handlers(TSRMLS_D) /* {{{ */ if (class_count) { for (zend_hash_internal_pointer_reset_ex(CG(class_table), &pos); - zend_hash_get_current_data_ex(CG(class_table), (void *) &pce, &pos) == SUCCESS; + (pce = zend_hash_get_current_data_ptr_ex(CG(class_table), &pos)) != NULL; zend_hash_move_forward_ex(CG(class_table), &pos)) { if ((*pce)->type == ZEND_INTERNAL_CLASS && (*pce)->default_static_members_count > 0) { @@ -1898,8 +1886,8 @@ ZEND_API void zend_destroy_modules(void) /* {{{ */ ZEND_API zend_module_entry* zend_register_module_ex(zend_module_entry *module TSRMLS_DC) /* {{{ */ { int name_len; - char *lcname; - zend_module_entry *module_ptr; + zend_string *lcname; +//??? zend_module_entry *module_ptr; if (!module) { return NULL; @@ -1916,30 +1904,32 @@ ZEND_API zend_module_entry* zend_register_module_ex(zend_module_entry *module TS while (dep->name) { if (dep->type == MODULE_DEP_CONFLICTS) { name_len = strlen(dep->name); - lcname = zend_str_tolower_dup(dep->name, name_len); + lcname = STR_ALLOC(name_len, 0); + zend_str_tolower_copy(lcname->val, dep->name, name_len); - if (zend_hash_exists(&module_registry, lcname, name_len+1)) { - efree(lcname); + if (zend_hash_exists(&module_registry, lcname)) { + STR_FREE(lcname); /* TODO: Check version relationship */ zend_error(E_CORE_WARNING, "Cannot load module '%s' because conflicting module '%s' is already loaded", module->name, dep->name); return NULL; } - efree(lcname); + STR_FREE(lcname); } ++dep; } } name_len = strlen(module->name); - lcname = zend_str_tolower_dup(module->name, name_len); + lcname = STR_ALLOC(name_len, 1); + zend_str_tolower_copy(lcname->val, module->name, name_len); - if (zend_hash_add(&module_registry, lcname, name_len+1, (void *)module, sizeof(zend_module_entry), (void**)&module_ptr)==FAILURE) { + if (zend_hash_add_mem(&module_registry, lcname, module, sizeof(zend_module_entry)) == NULL) { zend_error(E_CORE_WARNING, "Module '%s' already loaded", module->name); - efree(lcname); + STR_RELEASE(lcname); return NULL; } - efree(lcname); - module = module_ptr; + STR_RELEASE(lcname); +//??? module = module_ptr; EG(current_module) = module; if (module->functions && zend_register_functions(NULL, module->functions, NULL, module->type TSRMLS_CC)==FAILURE) { @@ -1968,56 +1958,56 @@ ZEND_API void zend_check_magic_method_implementation(const zend_class_entry *ce, /* we don't care if the function name is longer, in fact lowercasing only * the beginning of the name speeds up the check process */ - name_len = strlen(fptr->common.function_name); - zend_str_tolower_copy(lcname, fptr->common.function_name, MIN(name_len, sizeof(lcname)-1)); + name_len = fptr->common.function_name->len; + zend_str_tolower_copy(lcname, fptr->common.function_name->val, MIN(name_len, sizeof(lcname)-1)); lcname[sizeof(lcname)-1] = '\0'; /* zend_str_tolower_copy won't necessarily set the zero byte */ if (name_len == sizeof(ZEND_DESTRUCTOR_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_DESTRUCTOR_FUNC_NAME, sizeof(ZEND_DESTRUCTOR_FUNC_NAME) - 1) && fptr->common.num_args != 0) { - zend_error(error_type, "Destructor %s::%s() cannot take arguments", ce->name, ZEND_DESTRUCTOR_FUNC_NAME); + zend_error(error_type, "Destructor %s::%s() cannot take arguments", ce->name->val, ZEND_DESTRUCTOR_FUNC_NAME); } else if (name_len == sizeof(ZEND_CLONE_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_CLONE_FUNC_NAME, sizeof(ZEND_CLONE_FUNC_NAME) - 1) && fptr->common.num_args != 0) { - zend_error(error_type, "Method %s::%s() cannot accept any arguments", ce->name, ZEND_CLONE_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot accept any arguments", ce->name->val, ZEND_CLONE_FUNC_NAME); } else if (name_len == sizeof(ZEND_GET_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_GET_FUNC_NAME, sizeof(ZEND_GET_FUNC_NAME) - 1)) { if (fptr->common.num_args != 1) { - zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name, ZEND_GET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name->val, ZEND_GET_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_GET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_GET_FUNC_NAME); } } else if (name_len == sizeof(ZEND_SET_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_SET_FUNC_NAME, sizeof(ZEND_SET_FUNC_NAME) - 1)) { if (fptr->common.num_args != 2) { - zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name, ZEND_SET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name->val, ZEND_SET_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1) || ARG_SHOULD_BE_SENT_BY_REF(fptr, 2)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_SET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_SET_FUNC_NAME); } } else if (name_len == sizeof(ZEND_UNSET_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_UNSET_FUNC_NAME, sizeof(ZEND_UNSET_FUNC_NAME) - 1)) { if (fptr->common.num_args != 1) { - zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name, ZEND_UNSET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name->val, ZEND_UNSET_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_UNSET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_UNSET_FUNC_NAME); } } else if (name_len == sizeof(ZEND_ISSET_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_ISSET_FUNC_NAME, sizeof(ZEND_ISSET_FUNC_NAME) - 1)) { if (fptr->common.num_args != 1) { - zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name, ZEND_ISSET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 1 argument", ce->name->val, ZEND_ISSET_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_ISSET_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_ISSET_FUNC_NAME); } } else if (name_len == sizeof(ZEND_CALL_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_CALL_FUNC_NAME, sizeof(ZEND_CALL_FUNC_NAME) - 1)) { if (fptr->common.num_args != 2) { - zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name, ZEND_CALL_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name->val, ZEND_CALL_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1) || ARG_SHOULD_BE_SENT_BY_REF(fptr, 2)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_CALL_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_CALL_FUNC_NAME); } } else if (name_len == sizeof(ZEND_CALLSTATIC_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_CALLSTATIC_FUNC_NAME, sizeof(ZEND_CALLSTATIC_FUNC_NAME)-1) ) { if (fptr->common.num_args != 2) { - zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name, ZEND_CALLSTATIC_FUNC_NAME); + zend_error(error_type, "Method %s::%s() must take exactly 2 arguments", ce->name->val, ZEND_CALLSTATIC_FUNC_NAME); } else if (ARG_SHOULD_BE_SENT_BY_REF(fptr, 1) || ARG_SHOULD_BE_SENT_BY_REF(fptr, 2)) { - zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name, ZEND_CALLSTATIC_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments by reference", ce->name->val, ZEND_CALLSTATIC_FUNC_NAME); } } else if (name_len == sizeof(ZEND_TOSTRING_FUNC_NAME) - 1 && !memcmp(lcname, ZEND_TOSTRING_FUNC_NAME, sizeof(ZEND_TOSTRING_FUNC_NAME)-1) && fptr->common.num_args != 0 ) { - zend_error(error_type, "Method %s::%s() cannot take arguments", ce->name, ZEND_TOSTRING_FUNC_NAME); + zend_error(error_type, "Method %s::%s() cannot take arguments", ce->name->val, ZEND_TOSTRING_FUNC_NAME); } } /* }}} */ @@ -2032,11 +2022,10 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio HashTable *target_function_table = function_table; int error_type; zend_function *ctor = NULL, *dtor = NULL, *clone = NULL, *__get = NULL, *__set = NULL, *__unset = NULL, *__isset = NULL, *__call = NULL, *__callstatic = NULL, *__tostring = NULL; - const char *lowercase_name; + zend_string *lowercase_name; int fname_len; const char *lc_class_name = NULL; int class_name_len = 0; - zend_ulong hash; if (type==MODULE_PERSISTENT) { error_type = E_CORE_WARNING; @@ -2051,25 +2040,26 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio internal_function->module = EG(current_module); if (scope) { - class_name_len = strlen(scope->name); + class_name_len = scope->name->len; if ((lc_class_name = zend_memrchr(scope->name, '\\', class_name_len))) { ++lc_class_name; - class_name_len -= (lc_class_name - scope->name); + class_name_len -= (lc_class_name - scope->name->val); lc_class_name = zend_str_tolower_dup(lc_class_name, class_name_len); } else { - lc_class_name = zend_str_tolower_dup(scope->name, class_name_len); + lc_class_name = zend_str_tolower_dup(scope->name->val, class_name_len); } } while (ptr->fname) { + fname_len = strlen(ptr->fname); internal_function->handler = ptr->handler; - internal_function->function_name = (char*)ptr->fname; + internal_function->function_name = STR_INIT(ptr->fname, fname_len, 1); internal_function->scope = scope; internal_function->prototype = NULL; if (ptr->flags) { if (!(ptr->flags & ZEND_ACC_PPP_MASK)) { if (ptr->flags != ZEND_ACC_DEPRECATED || scope) { - zend_error(error_type, "Invalid access level for %s%s%s() - access must be exactly one of public, protected or private", scope ? scope->name : "", scope ? "::" : "", ptr->fname); + zend_error(error_type, "Invalid access level for %s%s%s() - access must be exactly one of public, protected or private", scope ? scope->name->val : "", scope ? "::" : "", ptr->fname); } internal_function->fn_flags = ZEND_ACC_PUBLIC | ptr->flags; } else { @@ -2112,29 +2102,29 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio } } if (ptr->flags & ZEND_ACC_STATIC && (!scope || !(scope->ce_flags & ZEND_ACC_INTERFACE))) { - zend_error(error_type, "Static function %s%s%s() cannot be abstract", scope ? scope->name : "", scope ? "::" : "", ptr->fname); + zend_error(error_type, "Static function %s%s%s() cannot be abstract", scope ? scope->name->val : "", scope ? "::" : "", ptr->fname); } } else { if (scope && (scope->ce_flags & ZEND_ACC_INTERFACE)) { efree((char*)lc_class_name); - zend_error(error_type, "Interface %s cannot contain non abstract method %s()", scope->name, ptr->fname); + zend_error(error_type, "Interface %s cannot contain non abstract method %s()", scope->name->val, ptr->fname); return FAILURE; } if (!internal_function->handler) { if (scope) { efree((char*)lc_class_name); } - zend_error(error_type, "Method %s%s%s() cannot be a NULL function", scope ? scope->name : "", scope ? "::" : "", ptr->fname); + zend_error(error_type, "Method %s%s%s() cannot be a NULL function", scope ? scope->name->val : "", scope ? "::" : "", ptr->fname); zend_unregister_functions(functions, count, target_function_table TSRMLS_CC); return FAILURE; } } - fname_len = strlen(ptr->fname); - lowercase_name = zend_new_interned_string(zend_str_tolower_dup(ptr->fname, fname_len), fname_len + 1, 1 TSRMLS_CC); - hash = str_hash(lowercase_name, fname_len); - if (zend_hash_quick_add(target_function_table, lowercase_name, fname_len+1, hash, &function, sizeof(zend_function), (void**)®_function) == FAILURE) { + lowercase_name = STR_ALLOC(fname_len, 1); + zend_str_tolower_copy(lowercase_name->val, ptr->fname, fname_len); + lowercase_name = zend_new_interned_string(lowercase_name TSRMLS_CC); + if ((reg_function = zend_hash_add_mem(target_function_table, lowercase_name, &function, sizeof(zend_function))) == NULL) { unload=1; - str_efree(lowercase_name); + STR_RELEASE(lowercase_name); break; } @@ -2162,7 +2152,7 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio } else if ((fname_len == sizeof(ZEND_DESTRUCTOR_FUNC_NAME)-1) && !memcmp(lowercase_name, ZEND_DESTRUCTOR_FUNC_NAME, sizeof(ZEND_DESTRUCTOR_FUNC_NAME) - 1)) { dtor = reg_function; if (internal_function->num_args) { - zend_error(error_type, "Destructor %s::%s() cannot take arguments", scope->name, ptr->fname); + zend_error(error_type, "Destructor %s::%s() cannot take arguments", scope->name->val, ptr->fname); } } else if ((fname_len == sizeof(ZEND_CLONE_FUNC_NAME)-1) && !memcmp(lowercase_name, ZEND_CLONE_FUNC_NAME, sizeof(ZEND_CLONE_FUNC_NAME) - 1)) { clone = reg_function; @@ -2189,7 +2179,7 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio } ptr++; count++; - str_efree(lowercase_name); + STR_RELEASE(lowercase_name); } if (unload) { /* before unloading, display all remaining bad function in the module */ if (scope) { @@ -2197,11 +2187,12 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio } while (ptr->fname) { fname_len = strlen(ptr->fname); - lowercase_name = zend_str_tolower_dup(ptr->fname, fname_len); - if (zend_hash_exists(target_function_table, lowercase_name, fname_len+1)) { - zend_error(error_type, "Function registration failed - duplicate name - %s%s%s", scope ? scope->name : "", scope ? "::" : "", ptr->fname); + lowercase_name = STR_ALLOC(fname_len, 0); + zend_str_tolower_copy(lowercase_name->val, ptr->fname, fname_len); + if (zend_hash_exists(target_function_table, lowercase_name)) { + zend_error(error_type, "Function registration failed - duplicate name - %s%s%s", scope ? scope->name->val : "", scope ? "::" : "", ptr->fname); } - efree((char*)lowercase_name); + STR_FREE(lowercase_name); ptr++; } zend_unregister_functions(functions, count, target_function_table TSRMLS_CC); @@ -2221,63 +2212,63 @@ ZEND_API int zend_register_functions(zend_class_entry *scope, const zend_functio if (ctor) { ctor->common.fn_flags |= ZEND_ACC_CTOR; if (ctor->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Constructor %s::%s() cannot be static", scope->name, ctor->common.function_name); + zend_error(error_type, "Constructor %s::%s() cannot be static", scope->name->val, ctor->common.function_name->val); } ctor->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (dtor) { dtor->common.fn_flags |= ZEND_ACC_DTOR; if (dtor->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Destructor %s::%s() cannot be static", scope->name, dtor->common.function_name); + zend_error(error_type, "Destructor %s::%s() cannot be static", scope->name->val, dtor->common.function_name->val); } dtor->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (clone) { clone->common.fn_flags |= ZEND_ACC_CLONE; if (clone->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Constructor %s::%s() cannot be static", scope->name, clone->common.function_name); + zend_error(error_type, "Constructor %s::%s() cannot be static", scope->name->val, clone->common.function_name->val); } clone->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__call) { if (__call->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __call->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __call->common.function_name->val); } __call->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__callstatic) { if (!(__callstatic->common.fn_flags & ZEND_ACC_STATIC)) { - zend_error(error_type, "Method %s::%s() must be static", scope->name, __callstatic->common.function_name); + zend_error(error_type, "Method %s::%s() must be static", scope->name->val, __callstatic->common.function_name->val); } __callstatic->common.fn_flags |= ZEND_ACC_STATIC; } if (__tostring) { if (__tostring->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __tostring->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __tostring->common.function_name->val); } __tostring->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__get) { if (__get->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __get->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __get->common.function_name->val); } __get->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__set) { if (__set->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __set->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __set->common.function_name->val); } __set->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__unset) { if (__unset->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __unset->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __unset->common.function_name->val); } __unset->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } if (__isset) { if (__isset->common.fn_flags & ZEND_ACC_STATIC) { - zend_error(error_type, "Method %s::%s() cannot be static", scope->name, __isset->common.function_name); + zend_error(error_type, "Method %s::%s() cannot be static", scope->name->val, __isset->common.function_name->val); } __isset->common.fn_flags &= ~ZEND_ACC_ALLOW_STATIC; } @@ -2295,6 +2286,8 @@ ZEND_API void zend_unregister_functions(const zend_function_entry *functions, in const zend_function_entry *ptr = functions; int i=0; HashTable *target_function_table = function_table; + zend_string *lowercase_name; + int fname_len; if (!target_function_table) { target_function_table = CG(function_table); @@ -2303,10 +2296,11 @@ ZEND_API void zend_unregister_functions(const zend_function_entry *functions, in if (count!=-1 && i>=count) { break; } -#if 0 - zend_printf("Unregistering %s()\n", ptr->fname); -#endif - zend_hash_del(target_function_table, ptr->fname, strlen(ptr->fname)+1); + fname_len = strlen(ptr->fname); + lowercase_name = STR_ALLOC(fname_len, 0); + zend_str_tolower_copy(lowercase_name->val, ptr->fname, fname_len); + zend_hash_del(target_function_table, lowercase_name); + STR_FREE(lowercase_name); ptr++; i++; } @@ -2326,7 +2320,8 @@ ZEND_API int zend_get_module_started(const char *module_name) /* {{{ */ { zend_module_entry *module; - return (zend_hash_find(&module_registry, module_name, strlen(module_name)+1, (void**)&module) == SUCCESS && module->module_started) ? SUCCESS : FAILURE; + module = zend_hash_str_find_ptr(&module_registry, module_name, strlen(module_name)); + return (module && module->module_started) ? SUCCESS : FAILURE; } /* }}} */ @@ -2495,8 +2490,7 @@ int zend_next_free_module(void) /* {{{ */ static zend_class_entry *do_register_internal_class(zend_class_entry *orig_class_entry, zend_uint ce_flags TSRMLS_DC) /* {{{ */ { zend_class_entry *class_entry = malloc(sizeof(zend_class_entry)); - char *lowercase_name = emalloc(orig_class_entry->name_length + 1); - zend_ulong hash; + zend_string *lowercase_name = STR_ALLOC(orig_class_entry->name->len, 1); *class_entry = *orig_class_entry; class_entry->type = ZEND_INTERNAL_CLASS; @@ -2508,11 +2502,10 @@ static zend_class_entry *do_register_internal_class(zend_class_entry *orig_class zend_register_functions(class_entry, class_entry->info.internal.builtin_functions, &class_entry->function_table, MODULE_PERSISTENT TSRMLS_CC); } - zend_str_tolower_copy(lowercase_name, orig_class_entry->name, class_entry->name_length); - lowercase_name = (char*)zend_new_interned_string(lowercase_name, class_entry->name_length + 1, 1 TSRMLS_CC); - hash = str_hash(lowercase_name, class_entry->name_length); - zend_hash_quick_update(CG(class_table), lowercase_name, class_entry->name_length+1, hash, &class_entry, sizeof(zend_class_entry *), NULL); - str_efree(lowercase_name); + zend_str_tolower_copy(lowercase_name->val, orig_class_entry->name->val, class_entry->name->len); + lowercase_name = zend_new_interned_string(lowercase_name TSRMLS_CC); + zend_hash_update_ptr(CG(class_table), lowercase_name, class_entry); + STR_RELEASE(lowercase_name); return class_entry; } /* }}} */ @@ -2522,19 +2515,10 @@ static zend_class_entry *do_register_internal_class(zend_class_entry *orig_class * If both parent_ce and parent_name are NULL it does a regular class registration * If parent_name is specified but not found NULL is returned */ -ZEND_API zend_class_entry *zend_register_internal_class_ex(zend_class_entry *class_entry, zend_class_entry *parent_ce, char *parent_name TSRMLS_DC) /* {{{ */ +ZEND_API zend_class_entry *zend_register_internal_class_ex(zend_class_entry *class_entry, zend_class_entry *parent_ce TSRMLS_DC) /* {{{ */ { zend_class_entry *register_class; - if (!parent_ce && parent_name) { - zend_class_entry **pce; - if (zend_hash_find(CG(class_table), parent_name, strlen(parent_name)+1, (void **) &pce)==FAILURE) { - return NULL; - } else { - parent_ce = *pce; - } - } - register_class = zend_register_internal_class(class_entry TSRMLS_CC); if (parent_ce) { @@ -2575,20 +2559,22 @@ ZEND_API zend_class_entry *zend_register_internal_interface(zend_class_entry *or ZEND_API int zend_register_class_alias_ex(const char *name, int name_len, zend_class_entry *ce TSRMLS_DC) /* {{{ */ { - char *lcname = zend_str_tolower_dup(name, name_len); - int ret; + zend_string *lcname; - if (lcname[0] == '\\') { - ret = zend_hash_add(CG(class_table), lcname+1, name_len, &ce, sizeof(zend_class_entry *), NULL); + if (name[0] == '\\') { + lcname = STR_ALLOC(name_len-1, 1); + zend_str_tolower_copy(lcname->val, name+1, name_len-1); } else { - ret = zend_hash_add(CG(class_table), lcname, name_len+1, &ce, sizeof(zend_class_entry *), NULL); + lcname = STR_ALLOC(name_len, 1); + zend_str_tolower_copy(lcname->val, name, name_len); } - - efree(lcname); - if (ret == SUCCESS) { + ce = zend_hash_add_ptr(CG(class_table), lcname, &ce); + STR_RELEASE(lcname); + if (ce) { ce->refcount++; + return SUCCESS; } - return ret; + return FAILURE; } /* }}} */ @@ -2599,13 +2585,15 @@ ZEND_API int zend_set_hash_symbol(zval *symbol, const char *name, int name_lengt if (num_symbol_tables <= 0) return FAILURE; - Z_SET_ISREF_TO_P(symbol, is_ref); + if (is_ref && Z_TYPE_P(symbol) != IS_REFERENCE) { + ZVAL_NEW_REF(symbol, symbol); + } va_start(symbol_table_list, num_symbol_tables); while (num_symbol_tables-- > 0) { symbol_table = va_arg(symbol_table_list, HashTable *); - zend_hash_update(symbol_table, name, name_length + 1, &symbol, sizeof(zval *), NULL); - zval_add_ref(&symbol); + zend_hash_str_update(symbol_table, name, name_length, symbol); + Z_ADDREF_P(symbol); } va_end(symbol_table_list); return SUCCESS; @@ -2629,7 +2617,10 @@ static zend_function_entry disabled_function[] = { ZEND_API int zend_disable_function(char *function_name, uint function_name_length TSRMLS_DC) /* {{{ */ { - if (zend_hash_del(CG(function_table), function_name, function_name_length+1)==FAILURE) { + int ret; + + ret = zend_hash_str_del(CG(function_table), function_name, function_name_length); + if (ret == FAILURE) { return FAILURE; } disabled_function[0].fname = function_name; @@ -2640,13 +2631,13 @@ ZEND_API int zend_disable_function(char *function_name, uint function_name_lengt #ifdef ZEND_WIN32 #pragma optimize("", off) #endif -static zend_object_value display_disabled_class(zend_class_entry *class_type TSRMLS_DC) /* {{{ */ +static zend_object *display_disabled_class(zend_class_entry *class_type TSRMLS_DC) /* {{{ */ { - zend_object_value retval; zend_object *intern; - retval = zend_objects_new(&intern, class_type TSRMLS_CC); - zend_error(E_WARNING, "%s() has been disabled for security reasons", class_type->name); - return retval; + + intern = zend_objects_new(class_type TSRMLS_CC); + zend_error(E_WARNING, "%s() has been disabled for security reasons", class_type->name->val); + return intern; } #ifdef ZEND_WIN32 #pragma optimize("", on) @@ -2659,35 +2650,42 @@ static const zend_function_entry disabled_class_new[] = { ZEND_API int zend_disable_class(char *class_name, uint class_name_length TSRMLS_DC) /* {{{ */ { - zend_class_entry **disabled_class; + zend_class_entry *disabled_class; + zend_string *key; - zend_str_tolower(class_name, class_name_length); - if (zend_hash_find(CG(class_table), class_name, class_name_length+1, (void **)&disabled_class)==FAILURE) { + key = STR_ALLOC(class_name_length, 0); + zend_str_tolower_copy(key->val, class_name, class_name_length); + disabled_class = zend_hash_find_ptr(CG(class_table), key); + if (!disabled_class) { return FAILURE; } - INIT_CLASS_ENTRY_INIT_METHODS((**disabled_class), disabled_class_new, NULL, NULL, NULL, NULL, NULL); - (*disabled_class)->create_object = display_disabled_class; - zend_hash_clean(&((*disabled_class)->function_table)); + INIT_CLASS_ENTRY_INIT_METHODS((*disabled_class), disabled_class_new, NULL, NULL, NULL, NULL, NULL); + disabled_class->create_object = display_disabled_class; + zend_hash_clean(&disabled_class->function_table); return SUCCESS; } /* }}} */ -static int zend_is_callable_check_class(const char *name, int name_len, zend_fcall_info_cache *fcc, int *strict_class, char **error TSRMLS_DC) /* {{{ */ +static int zend_is_callable_check_class(zend_string *name, zend_fcall_info_cache *fcc, int *strict_class, char **error TSRMLS_DC) /* {{{ */ { int ret = 0; - zend_class_entry **pce; - char *lcname = zend_str_tolower_dup(name, name_len); + zend_class_entry *ce; + int name_len = name->len; + zend_string *lcname; + + lcname = STR_ALLOC(name_len, 0); + zend_str_tolower_copy(lcname->val, name->val, name_len); *strict_class = 0; if (name_len == sizeof("self") - 1 && - !memcmp(lcname, "self", sizeof("self") - 1)) { + !memcmp(lcname->val, "self", sizeof("self") - 1)) { if (!EG(scope)) { if (error) *error = estrdup("cannot access self:: when no class scope is active"); } else { fcc->called_scope = EG(called_scope); fcc->calling_scope = EG(scope); if (!fcc->object_ptr) { - fcc->object_ptr = EG(This); + fcc->object_ptr = &EG(This); } ret = 1; } @@ -2701,7 +2699,7 @@ static int zend_is_callable_check_class(const char *name, int name_len, zend_fca fcc->called_scope = EG(called_scope); fcc->calling_scope = EG(scope)->parent; if (!fcc->object_ptr) { - fcc->object_ptr = EG(This); + fcc->object_ptr = &EG(This); } *strict_class = 1; ret = 1; @@ -2714,19 +2712,19 @@ static int zend_is_callable_check_class(const char *name, int name_len, zend_fca fcc->called_scope = EG(called_scope); fcc->calling_scope = EG(called_scope); if (!fcc->object_ptr) { - fcc->object_ptr = EG(This); + fcc->object_ptr = &EG(This); } *strict_class = 1; ret = 1; } - } else if (zend_lookup_class_ex(name, name_len, NULL, 1, &pce TSRMLS_CC) == SUCCESS) { + } else if ((ce = zend_lookup_class_ex(name, NULL, 1 TSRMLS_CC)) != NULL) { zend_class_entry *scope = EG(active_op_array) ? EG(active_op_array)->scope : NULL; - fcc->calling_scope = *pce; - if (scope && !fcc->object_ptr && EG(This) && - instanceof_function(Z_OBJCE_P(EG(This)), scope TSRMLS_CC) && + fcc->calling_scope = ce; + if (scope && !fcc->object_ptr && Z_TYPE(EG(This)) != IS_UNDEF && + instanceof_function(Z_OBJCE(EG(This)), scope TSRMLS_CC) && instanceof_function(scope, fcc->calling_scope TSRMLS_CC)) { - fcc->object_ptr = EG(This); + fcc->object_ptr = &EG(This); fcc->called_scope = Z_OBJCE_P(fcc->object_ptr); } else { fcc->called_scope = fcc->object_ptr ? Z_OBJCE_P(fcc->object_ptr) : fcc->calling_scope; @@ -2745,7 +2743,8 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca { zend_class_entry *ce_org = fcc->calling_scope; int retval = 0; - char *mname, *lmname; + zend_string *mname; + zend_string *lmname; const char *colon; int clen, mlen; zend_class_entry *last_scope; @@ -2762,19 +2761,20 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca if (!ce_org) { /* Skip leading \ */ if (Z_STRVAL_P(callable)[0] == '\\') { - mlen = Z_STRLEN_P(callable) - 1; - lmname = zend_str_tolower_dup(Z_STRVAL_P(callable) + 1, mlen); + lmname = STR_ALLOC(Z_STRLEN_P(callable) - 1, 0); + zend_str_tolower_copy(lmname->val, Z_STRVAL_P(callable) + 1, Z_STRLEN_P(callable) - 1); } else { - mlen = Z_STRLEN_P(callable); - lmname = zend_str_tolower_dup(Z_STRVAL_P(callable), mlen); + lmname = STR_ALLOC(Z_STRLEN_P(callable), 0); + zend_str_tolower_copy(lmname->val, Z_STRVAL_P(callable), Z_STRLEN_P(callable)); } /* Check if function with given name exists. * This may be a compound name that includes namespace name */ - if (zend_hash_find(EG(function_table), lmname, mlen+1, (void**)&fcc->function_handler) == SUCCESS) { - efree(lmname); + fcc->function_handler = zend_hash_find_ptr(EG(function_table), lmname); + if (fcc->function_handler != NULL) { + STR_FREE(lmname); return 1; } - efree(lmname); + STR_FREE(lmname); } /* Split name into class/namespace and method/function names */ @@ -2798,7 +2798,8 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca EG(scope) = ce_org; } - if (!zend_is_callable_check_class(Z_STRVAL_P(callable), clen, fcc, &strict_class, error TSRMLS_CC)) { +//??? if (!zend_is_callable_check_class(Z_STRVAL_P(callable), clen, fcc, &strict_class, error TSRMLS_CC)) { + if (!zend_is_callable_check_class(Z_STR_P(callable), fcc, &strict_class, error TSRMLS_CC)) { EG(scope) = last_scope; return 0; } @@ -2809,11 +2810,12 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca if (error) zend_spprintf(error, 0, "class '%s' is not a subclass of '%s'", ce_org->name, fcc->calling_scope->name); return 0; } - mname = Z_STRVAL_P(callable) + clen + 2; + mname = STR_INIT(Z_STRVAL_P(callable) + clen + 2, mlen, 0); } else if (ce_org) { /* Try to fetch find static method of given class. */ mlen = Z_STRLEN_P(callable); - mname = Z_STRVAL_P(callable); + mname = Z_STR_P(callable); + STR_ADDREF(mname); ftable = &ce_org->function_table; fcc->calling_scope = ce_org; } else { @@ -2824,23 +2826,24 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca return 0; } - lmname = zend_str_tolower_dup(mname, mlen); + lmname = STR_ALLOC(mlen, 0); + zend_str_tolower_copy(lmname->val, mname->val, mlen); if (strict_class && fcc->calling_scope && mlen == sizeof(ZEND_CONSTRUCTOR_FUNC_NAME)-1 && - !memcmp(lmname, ZEND_CONSTRUCTOR_FUNC_NAME, sizeof(ZEND_CONSTRUCTOR_FUNC_NAME) - 1)) { + !memcmp(lmname->val, ZEND_CONSTRUCTOR_FUNC_NAME, sizeof(ZEND_CONSTRUCTOR_FUNC_NAME) - 1)) { fcc->function_handler = fcc->calling_scope->constructor; if (fcc->function_handler) { retval = 1; } - } else if (zend_hash_find(ftable, lmname, mlen+1, (void**)&fcc->function_handler) == SUCCESS) { + } else if ((fcc->function_handler = zend_hash_find_ptr(ftable, lmname)) != NULL) { retval = 1; if ((fcc->function_handler->op_array.fn_flags & ZEND_ACC_CHANGED) && !strict_class && EG(scope) && instanceof_function(fcc->function_handler->common.scope, EG(scope) TSRMLS_CC)) { zend_function *priv_fbc; - if (zend_hash_find(&EG(scope)->function_table, lmname, mlen+1, (void **) &priv_fbc)==SUCCESS + if ((priv_fbc = zend_hash_find_ptr(&EG(scope)->function_table, lmname)) != NULL && priv_fbc->common.fn_flags & ZEND_ACC_PRIVATE && priv_fbc->common.scope == EG(scope)) { fcc->function_handler = priv_fbc; @@ -2851,7 +2854,7 @@ static int zend_is_callable_check_func(int check_flags, zval *callable, zend_fca ((fcc->object_ptr && fcc->calling_scope->__call) || (!fcc->object_ptr && fcc->calling_scope->__callstatic)))) { if (fcc->function_handler->op_array.fn_flags & ZEND_ACC_PRIVATE) { - if (!zend_check_private(fcc->function_handler, fcc->object_ptr ? Z_OBJCE_P(fcc->object_ptr) : EG(scope), lmname, mlen TSRMLS_CC)) { + if (!zend_check_private(fcc->function_handler, fcc->object_ptr ? Z_OBJCE_P(fcc->object_ptr) : EG(scope), lmname TSRMLS_CC)) { retval = 0; fcc->function_handler = NULL; goto get_function_via_handler; @@ -2876,11 +2879,12 @@ get_function_via_handler: fcc->function_handler->internal_function.num_args = 0; fcc->function_handler->internal_function.scope = ce_org; fcc->function_handler->internal_function.fn_flags = ZEND_ACC_CALL_VIA_HANDLER; - fcc->function_handler->internal_function.function_name = estrndup(mname, mlen); + fcc->function_handler->internal_function.function_name = mname; + STR_ADDREF(mname); call_via_handler = 1; retval = 1; } else if (Z_OBJ_HT_P(fcc->object_ptr)->get_method) { - fcc->function_handler = Z_OBJ_HT_P(fcc->object_ptr)->get_method(&fcc->object_ptr, mname, mlen, NULL TSRMLS_CC); + fcc->function_handler = Z_OBJ_HT_P(fcc->object_ptr)->get_method(fcc->object_ptr, mname, NULL TSRMLS_CC); if (fcc->function_handler) { if (strict_class && (!fcc->function_handler->common.scope || @@ -2899,17 +2903,17 @@ get_function_via_handler: } } else if (fcc->calling_scope) { if (fcc->calling_scope->get_static_method) { - fcc->function_handler = fcc->calling_scope->get_static_method(fcc->calling_scope, mname, mlen TSRMLS_CC); + fcc->function_handler = fcc->calling_scope->get_static_method(fcc->calling_scope, mname TSRMLS_CC); } else { - fcc->function_handler = zend_std_get_static_method(fcc->calling_scope, mname, mlen, NULL TSRMLS_CC); + fcc->function_handler = zend_std_get_static_method(fcc->calling_scope, mname, NULL TSRMLS_CC); } if (fcc->function_handler) { retval = 1; call_via_handler = (fcc->function_handler->common.fn_flags & ZEND_ACC_CALL_VIA_HANDLER) != 0; - if (call_via_handler && !fcc->object_ptr && EG(This) && - Z_OBJ_HT_P(EG(This))->get_class_entry && - instanceof_function(Z_OBJCE_P(EG(This)), fcc->calling_scope TSRMLS_CC)) { - fcc->object_ptr = EG(This); + if (call_via_handler && !fcc->object_ptr && Z_TYPE(EG(This)) != IS_UNDEF && + Z_OBJ_HT(EG(This))->get_class_entry && + instanceof_function(Z_OBJCE(EG(This)), fcc->calling_scope TSRMLS_CC)) { + fcc->object_ptr = &EG(This); } } } @@ -2922,7 +2926,7 @@ get_function_via_handler: zend_spprintf(error, 0, "cannot call abstract method %s::%s()", fcc->calling_scope->name, fcc->function_handler->common.function_name); retval = 0; } else { - zend_error(E_ERROR, "Cannot call abstract method %s::%s()", fcc->calling_scope->name, fcc->function_handler->common.function_name); + zend_error(E_ERROR, "Cannot call abstract method %s::%s()", fcc->calling_scope->name->val, fcc->function_handler->common.function_name->val); } } else if (!fcc->object_ptr && !(fcc->function_handler->common.fn_flags & ZEND_ACC_STATIC)) { int severity; @@ -2938,30 +2942,30 @@ get_function_via_handler: if ((check_flags & IS_CALLABLE_CHECK_IS_STATIC) != 0) { retval = 0; } - if (EG(This) && instanceof_function(Z_OBJCE_P(EG(This)), fcc->calling_scope TSRMLS_CC)) { - fcc->object_ptr = EG(This); + if (Z_TYPE(EG(This)) != IS_UNDEF && instanceof_function(Z_OBJCE(EG(This)), fcc->calling_scope TSRMLS_CC)) { + fcc->object_ptr = &EG(This); if (error) { - zend_spprintf(error, 0, "non-static method %s::%s() %s be called statically, assuming $this from compatible context %s", fcc->calling_scope->name, fcc->function_handler->common.function_name, verb, Z_OBJCE_P(EG(This))->name); + zend_spprintf(error, 0, "non-static method %s::%s() %s be called statically, assuming $this from compatible context %s", fcc->calling_scope->name->val, fcc->function_handler->common.function_name->val, verb, Z_OBJCE(EG(This))->name->val); if (severity == E_ERROR) { retval = 0; } } else if (retval) { - zend_error(severity, "Non-static method %s::%s() %s be called statically, assuming $this from compatible context %s", fcc->calling_scope->name, fcc->function_handler->common.function_name, verb, Z_OBJCE_P(EG(This))->name); + zend_error(severity, "Non-static method %s::%s() %s be called statically, assuming $this from compatible context %s", fcc->calling_scope->name->val, fcc->function_handler->common.function_name->val, verb, Z_OBJCE(EG(This))->name->val); } } else { if (error) { - zend_spprintf(error, 0, "non-static method %s::%s() %s be called statically", fcc->calling_scope->name, fcc->function_handler->common.function_name, verb); + zend_spprintf(error, 0, "non-static method %s::%s() %s be called statically", fcc->calling_scope->name->val, fcc->function_handler->common.function_name->val, verb); if (severity == E_ERROR) { retval = 0; } } else if (retval) { - zend_error(severity, "Non-static method %s::%s() %s be called statically", fcc->calling_scope->name, fcc->function_handler->common.function_name, verb); + zend_error(severity, "Non-static method %s::%s() %s be called statically", fcc->calling_scope->name->val, fcc->function_handler->common.function_name->val, verb); } } } if (retval && (check_flags & IS_CALLABLE_CHECK_NO_ACCESS) == 0) { if (fcc->function_handler->op_array.fn_flags & ZEND_ACC_PRIVATE) { - if (!zend_check_private(fcc->function_handler, fcc->object_ptr ? Z_OBJCE_P(fcc->object_ptr) : EG(scope), lmname, mlen TSRMLS_CC)) { + if (!zend_check_private(fcc->function_handler, fcc->object_ptr ? Z_OBJCE_P(fcc->object_ptr) : EG(scope), lmname TSRMLS_CC)) { if (error) { if (*error) { efree(*error); @@ -3031,11 +3035,11 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch if (object_ptr && Z_TYPE_P(object_ptr) != IS_OBJECT) { object_ptr = NULL; } - if (object_ptr && - (!EG(objects_store).object_buckets || - !EG(objects_store).object_buckets[Z_OBJ_HANDLE_P(object_ptr)].valid)) { - return 0; - } +//??? if (object_ptr && +//??? (!EG(objects_store).object_buckets || +//??? !EG(objects_store).object_buckets[Z_OBJ_HANDLE_P(object_ptr)].valid)) { +//??? return 0; +//??? } switch (Z_TYPE_P(callable)) { case IS_STRING: @@ -3045,10 +3049,10 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch if (callable_name) { char *ptr; - *callable_name_len = fcc->calling_scope->name_length + Z_STRLEN_P(callable) + sizeof("::") - 1; + *callable_name_len = fcc->calling_scope->name->len + Z_STRLEN_P(callable) + sizeof("::") - 1; ptr = *callable_name = emalloc(*callable_name_len + 1); - memcpy(ptr, fcc->calling_scope->name, fcc->calling_scope->name_length); - ptr += fcc->calling_scope->name_length; + memcpy(ptr, fcc->calling_scope->name, fcc->calling_scope->name->len); + ptr += fcc->calling_scope->name->len; memcpy(ptr, "::", sizeof("::") - 1); ptr += sizeof("::") - 1; memcpy(ptr, Z_STRVAL_P(callable), Z_STRLEN_P(callable) + 1); @@ -3078,60 +3082,60 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch case IS_ARRAY: { - zval **method = NULL; - zval **obj = NULL; + zval *method = NULL; + zval *obj = NULL; int strict_class = 0; if (zend_hash_num_elements(Z_ARRVAL_P(callable)) == 2) { - zend_hash_index_find(Z_ARRVAL_P(callable), 0, (void **) &obj); - zend_hash_index_find(Z_ARRVAL_P(callable), 1, (void **) &method); + obj = zend_hash_index_find(Z_ARRVAL_P(callable), 0); + method = zend_hash_index_find(Z_ARRVAL_P(callable), 1); } if (obj && method && - (Z_TYPE_PP(obj) == IS_OBJECT || - Z_TYPE_PP(obj) == IS_STRING) && - Z_TYPE_PP(method) == IS_STRING) { + (Z_TYPE_P(obj) == IS_OBJECT || + Z_TYPE_P(obj) == IS_STRING) && + Z_TYPE_P(method) == IS_STRING) { - if (Z_TYPE_PP(obj) == IS_STRING) { + if (Z_TYPE_P(obj) == IS_STRING) { if (callable_name) { char *ptr; - *callable_name_len = Z_STRLEN_PP(obj) + Z_STRLEN_PP(method) + sizeof("::") - 1; + *callable_name_len = Z_STRLEN_P(obj) + Z_STRLEN_P(method) + sizeof("::") - 1; ptr = *callable_name = emalloc(*callable_name_len + 1); - memcpy(ptr, Z_STRVAL_PP(obj), Z_STRLEN_PP(obj)); - ptr += Z_STRLEN_PP(obj); + memcpy(ptr, Z_STRVAL_P(obj), Z_STRLEN_P(obj)); + ptr += Z_STRLEN_P(obj); memcpy(ptr, "::", sizeof("::") - 1); ptr += sizeof("::") - 1; - memcpy(ptr, Z_STRVAL_PP(method), Z_STRLEN_PP(method) + 1); + memcpy(ptr, Z_STRVAL_P(method), Z_STRLEN_P(method) + 1); } if (check_flags & IS_CALLABLE_CHECK_SYNTAX_ONLY) { return 1; } - if (!zend_is_callable_check_class(Z_STRVAL_PP(obj), Z_STRLEN_PP(obj), fcc, &strict_class, error TSRMLS_CC)) { + if (!zend_is_callable_check_class(Z_STR_P(obj), fcc, &strict_class, error TSRMLS_CC)) { return 0; } } else { - if (!EG(objects_store).object_buckets || - !EG(objects_store).object_buckets[Z_OBJ_HANDLE_PP(obj)].valid) { - return 0; - } +//??? if (!EG(objects_store).object_buckets || +//??? !EG(objects_store).object_buckets[Z_OBJ_HANDLE_PP(obj)].valid) { +//??? return 0; +//??? } - fcc->calling_scope = Z_OBJCE_PP(obj); /* TBFixed: what if it's overloaded? */ + fcc->calling_scope = Z_OBJCE_P(obj); /* TBFixed: what if it's overloaded? */ - fcc->object_ptr = *obj; + fcc->object_ptr = obj; if (callable_name) { char *ptr; - *callable_name_len = fcc->calling_scope->name_length + Z_STRLEN_PP(method) + sizeof("::") - 1; + *callable_name_len = fcc->calling_scope->name->len + Z_STRLEN_P(method) + sizeof("::") - 1; ptr = *callable_name = emalloc(*callable_name_len + 1); - memcpy(ptr, fcc->calling_scope->name, fcc->calling_scope->name_length); - ptr += fcc->calling_scope->name_length; + memcpy(ptr, fcc->calling_scope->name, fcc->calling_scope->name->len); + ptr += fcc->calling_scope->name->len; memcpy(ptr, "::", sizeof("::") - 1); ptr += sizeof("::") - 1; - memcpy(ptr, Z_STRVAL_PP(method), Z_STRLEN_PP(method) + 1); + memcpy(ptr, Z_STRVAL_P(method), Z_STRLEN_P(method) + 1); } if (check_flags & IS_CALLABLE_CHECK_SYNTAX_ONLY) { @@ -3140,7 +3144,7 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch } } - ret = zend_is_callable_check_func(check_flags, *method, fcc, strict_class, error TSRMLS_CC); + ret = zend_is_callable_check_func(check_flags, method, fcc, strict_class, error TSRMLS_CC); if (fcc == &fcc_local && fcc->function_handler && ((fcc->function_handler->type == ZEND_INTERNAL_FUNCTION && @@ -3156,7 +3160,7 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch } else { if (zend_hash_num_elements(Z_ARRVAL_P(callable)) == 2) { - if (!obj || (Z_TYPE_PP(obj) != IS_STRING && Z_TYPE_PP(obj) != IS_OBJECT)) { + if (!obj || (Z_TYPE_P(obj) != IS_STRING && Z_TYPE_P(obj) != IS_OBJECT)) { if (error) zend_spprintf(error, 0, "first array member is not a valid class name or object"); } else { if (error) zend_spprintf(error, 0, "second array member is not a valid method"); @@ -3173,15 +3177,15 @@ ZEND_API zend_bool zend_is_callable_ex(zval *callable, zval *object_ptr, uint ch return 0; case IS_OBJECT: - if (Z_OBJ_HANDLER_P(callable, get_closure) && Z_OBJ_HANDLER_P(callable, get_closure)(callable, &fcc->calling_scope, &fcc->function_handler, &fcc->object_ptr TSRMLS_CC) == SUCCESS) { + if (Z_OBJ_HANDLER_P(callable, get_closure) && Z_OBJ_HANDLER_P(callable, get_closure)(callable, &fcc->calling_scope, &fcc->function_handler, fcc->object_ptr TSRMLS_CC) == SUCCESS) { fcc->called_scope = fcc->calling_scope; if (callable_name) { zend_class_entry *ce = Z_OBJCE_P(callable); /* TBFixed: what if it's overloaded? */ - *callable_name_len = ce->name_length + sizeof("::__invoke") - 1; + *callable_name_len = ce->name->len + sizeof("::__invoke") - 1; *callable_name = emalloc(*callable_name_len + 1); - memcpy(*callable_name, ce->name, ce->name_length); - memcpy((*callable_name) + ce->name_length, "::__invoke", sizeof("::__invoke")); + memcpy(*callable_name, ce->name, ce->name->len); + memcpy((*callable_name) + ce->name->len, "::__invoke", sizeof("::__invoke")); } return 1; } @@ -3217,8 +3221,8 @@ ZEND_API zend_bool zend_make_callable(zval *callable, char **callable_name TSRML if (Z_TYPE_P(callable) == IS_STRING && fcc.calling_scope) { zval_dtor(callable); array_init(callable); - add_next_index_string(callable, fcc.calling_scope->name, 1); - add_next_index_string(callable, fcc.function_handler->common.function_name, 1); + add_next_index_str(callable, fcc.calling_scope->name); + add_next_index_str(callable, fcc.function_handler->common.function_name); } if (fcc.function_handler && ((fcc.function_handler->type == ZEND_INTERNAL_FUNCTION && @@ -3245,8 +3249,8 @@ ZEND_API int zend_fcall_info_init(zval *callable, uint check_flags, zend_fcall_i fci->size = sizeof(*fci); fci->function_table = fcc->calling_scope ? &fcc->calling_scope->function_table : EG(function_table); fci->object_ptr = fcc->object_ptr; - fci->function_name = callable; - fci->retval_ptr_ptr = NULL; + ZVAL_COPY_VALUE(&fci->function_name, callable); + fci->retval = NULL; fci->param_count = 0; fci->params = NULL; fci->no_separation = 1; @@ -3268,7 +3272,7 @@ ZEND_API void zend_fcall_info_args_clear(zend_fcall_info *fci, int free_mem) /* } /* }}} */ -ZEND_API void zend_fcall_info_args_save(zend_fcall_info *fci, int *param_count, zval ****params) /* {{{ */ +ZEND_API void zend_fcall_info_args_save(zend_fcall_info *fci, int *param_count, zval **params) /* {{{ */ { *param_count = fci->param_count; *params = fci->params; @@ -3277,7 +3281,7 @@ ZEND_API void zend_fcall_info_args_save(zend_fcall_info *fci, int *param_count, } /* }}} */ -ZEND_API void zend_fcall_info_args_restore(zend_fcall_info *fci, int param_count, zval ***params) /* {{{ */ +ZEND_API void zend_fcall_info_args_restore(zend_fcall_info *fci, int param_count, zval *params) /* {{{ */ { zend_fcall_info_args_clear(fci, 1); fci->param_count = param_count; @@ -3288,7 +3292,7 @@ ZEND_API void zend_fcall_info_args_restore(zend_fcall_info *fci, int param_count ZEND_API int zend_fcall_info_args(zend_fcall_info *fci, zval *args TSRMLS_DC) /* {{{ */ { HashPosition pos; - zval **arg, ***params; + zval *arg, *params; zend_fcall_info_args_clear(fci, !args); @@ -3301,11 +3305,12 @@ ZEND_API int zend_fcall_info_args(zend_fcall_info *fci, zval *args TSRMLS_DC) /* } fci->param_count = zend_hash_num_elements(Z_ARRVAL_P(args)); - fci->params = params = (zval ***) erealloc(fci->params, fci->param_count * sizeof(zval **)); + fci->params = params = (zval *) erealloc(fci->params, fci->param_count * sizeof(zval)); zend_hash_internal_pointer_reset_ex(Z_ARRVAL_P(args), &pos); - while (zend_hash_get_current_data_ex(Z_ARRVAL_P(args), (void *) &arg, &pos) == SUCCESS) { - *params++ = arg; + while ((arg = zend_hash_get_current_data_ex(Z_ARRVAL_P(args), &pos)) != NULL) { + ZVAL_COPY_VALUE(params, arg); + params++; zend_hash_move_forward_ex(Z_ARRVAL_P(args), &pos); } @@ -3313,7 +3318,7 @@ ZEND_API int zend_fcall_info_args(zend_fcall_info *fci, zval *args TSRMLS_DC) /* } /* }}} */ -ZEND_API int zend_fcall_info_argp(zend_fcall_info *fci TSRMLS_DC, int argc, zval ***argv) /* {{{ */ +ZEND_API int zend_fcall_info_argp(zend_fcall_info *fci TSRMLS_DC, int argc, zval *argv) /* {{{ */ { int i; @@ -3325,10 +3330,10 @@ ZEND_API int zend_fcall_info_argp(zend_fcall_info *fci TSRMLS_DC, int argc, zval if (argc) { fci->param_count = argc; - fci->params = (zval ***) erealloc(fci->params, fci->param_count * sizeof(zval **)); + fci->params = (zval *) erealloc(fci->params, fci->param_count * sizeof(zval)); for (i = 0; i < argc; ++i) { - fci->params[i] = argv[i]; + ZVAL_COPY_VALUE(&fci->params[i], &argv[i]); } } @@ -3339,7 +3344,7 @@ ZEND_API int zend_fcall_info_argp(zend_fcall_info *fci TSRMLS_DC, int argc, zval ZEND_API int zend_fcall_info_argv(zend_fcall_info *fci TSRMLS_DC, int argc, va_list *argv) /* {{{ */ { int i; - zval **arg; + zval *arg; if (argc < 0) { return FAILURE; @@ -3349,11 +3354,11 @@ ZEND_API int zend_fcall_info_argv(zend_fcall_info *fci TSRMLS_DC, int argc, va_l if (argc) { fci->param_count = argc; - fci->params = (zval ***) erealloc(fci->params, fci->param_count * sizeof(zval **)); + fci->params = (zval *) erealloc(fci->params, fci->param_count * sizeof(zval)); for (i = 0; i < argc; ++i) { - arg = va_arg(*argv, zval **); - fci->params[i] = arg; + arg = va_arg(*argv, zval *); + ZVAL_COPY_VALUE(&fci->params[i], arg); } } @@ -3374,19 +3379,19 @@ ZEND_API int zend_fcall_info_argn(zend_fcall_info *fci TSRMLS_DC, int argc, ...) } /* }}} */ -ZEND_API int zend_fcall_info_call(zend_fcall_info *fci, zend_fcall_info_cache *fcc, zval **retval_ptr_ptr, zval *args TSRMLS_DC) /* {{{ */ +ZEND_API int zend_fcall_info_call(zend_fcall_info *fci, zend_fcall_info_cache *fcc, zval *retval_ptr, zval *args TSRMLS_DC) /* {{{ */ { - zval *retval, ***org_params = NULL; + zval retval, *org_params = NULL; int result, org_count = 0; - fci->retval_ptr_ptr = retval_ptr_ptr ? retval_ptr_ptr : &retval; + fci->retval = retval_ptr ? retval_ptr : &retval; if (args) { zend_fcall_info_args_save(fci, &org_count, &org_params); zend_fcall_info_args(fci, args TSRMLS_CC); } result = zend_call_function(fci, fcc TSRMLS_CC); - if (!retval_ptr_ptr && retval) { + if (!retval_ptr && Z_TYPE(retval) != IS_UNDEF) { zval_ptr_dtor(&retval); } if (args) { @@ -3398,54 +3403,50 @@ ZEND_API int zend_fcall_info_call(zend_fcall_info *fci, zend_fcall_info_cache *f ZEND_API const char *zend_get_module_version(const char *module_name) /* {{{ */ { - char *lname; + zend_string *lname; int name_len = strlen(module_name); zend_module_entry *module; - lname = zend_str_tolower_dup(module_name, name_len); - if (zend_hash_find(&module_registry, lname, name_len + 1, (void**)&module) == FAILURE) { - efree(lname); - return NULL; - } - efree(lname); - return module->version; + lname = STR_ALLOC(name_len, 0); + zend_str_tolower_copy(lname->val, module_name, name_len); + module = zend_hash_find_ptr(&module_registry, lname); + STR_FREE(lname); + return module ? module->version : NULL; } /* }}} */ -ZEND_API int zend_declare_property_ex(zend_class_entry *ce, const char *name, int name_length, zval *property, int access_type, const char *doc_comment, int doc_comment_len TSRMLS_DC) /* {{{ */ +ZEND_API int zend_declare_property_ex(zend_class_entry *ce, zend_string *name, zval *property, int access_type, zend_string *doc_comment TSRMLS_DC) /* {{{ */ { zend_property_info property_info, *property_info_ptr; - const char *interned_name; - ulong h = zend_get_hash_value(name, name_length+1); if (!(access_type & ZEND_ACC_PPP_MASK)) { access_type |= ZEND_ACC_PUBLIC; } if (access_type & ZEND_ACC_STATIC) { - if (zend_hash_quick_find(&ce->properties_info, name, name_length + 1, h, (void**)&property_info_ptr) == SUCCESS && + if ((property_info_ptr = zend_hash_find_ptr(&ce->properties_info, name)) != NULL && (property_info_ptr->flags & ZEND_ACC_STATIC) != 0) { property_info.offset = property_info_ptr->offset; zval_ptr_dtor(&ce->default_static_members_table[property_info.offset]); - zend_hash_quick_del(&ce->properties_info, name, name_length + 1, h); + zend_hash_del(&ce->properties_info, name); } else { property_info.offset = ce->default_static_members_count++; - ce->default_static_members_table = perealloc(ce->default_static_members_table, sizeof(zval*) * ce->default_static_members_count, ce->type == ZEND_INTERNAL_CLASS); + ce->default_static_members_table = perealloc(ce->default_static_members_table, sizeof(zval) * ce->default_static_members_count, ce->type == ZEND_INTERNAL_CLASS); } - ce->default_static_members_table[property_info.offset] = property; + ZVAL_COPY_VALUE(&ce->default_static_members_table[property_info.offset], property); if (ce->type == ZEND_USER_CLASS) { ce->static_members_table = ce->default_static_members_table; } } else { - if (zend_hash_quick_find(&ce->properties_info, name, name_length + 1, h, (void**)&property_info_ptr) == SUCCESS && + if ((property_info_ptr = zend_hash_find_ptr(&ce->properties_info, name)) != NULL && (property_info_ptr->flags & ZEND_ACC_STATIC) == 0) { property_info.offset = property_info_ptr->offset; zval_ptr_dtor(&ce->default_properties_table[property_info.offset]); - zend_hash_quick_del(&ce->properties_info, name, name_length + 1, h); + zend_hash_del(&ce->properties_info, name); } else { property_info.offset = ce->default_properties_count++; - ce->default_properties_table = perealloc(ce->default_properties_table, sizeof(zval*) * ce->default_properties_count, ce->type == ZEND_INTERNAL_CLASS); + ce->default_properties_table = perealloc(ce->default_properties_table, sizeof(zval) * ce->default_properties_count, ce->type == ZEND_INTERNAL_CLASS); } - ce->default_properties_table[property_info.offset] = property; + ZVAL_COPY_VALUE(&ce->default_properties_table[property_info.offset], property); } if (ce->type & ZEND_INTERNAL_CLASS) { switch(Z_TYPE_P(property)) { @@ -3464,49 +3465,32 @@ ZEND_API int zend_declare_property_ex(zend_class_entry *ce, const char *name, in char *priv_name; int priv_name_length; - zend_mangle_property_name(&priv_name, &priv_name_length, ce->name, ce->name_length, name, name_length, ce->type & ZEND_INTERNAL_CLASS); - property_info.name = priv_name; - property_info.name_length = priv_name_length; + zend_mangle_property_name(&priv_name, &priv_name_length, ce->name->val, ce->name->len, name->val, name->len, ce->type & ZEND_INTERNAL_CLASS); + property_info.name = STR_INIT(priv_name, priv_name_length, ce->type & ZEND_INTERNAL_CLASS); } break; case ZEND_ACC_PROTECTED: { char *prot_name; int prot_name_length; - zend_mangle_property_name(&prot_name, &prot_name_length, "*", 1, name, name_length, ce->type & ZEND_INTERNAL_CLASS); - property_info.name = prot_name; - property_info.name_length = prot_name_length; + zend_mangle_property_name(&prot_name, &prot_name_length, "*", 1, name->val, name->len, ce->type & ZEND_INTERNAL_CLASS); + property_info.name = STR_INIT(prot_name, prot_name_length, ce->type & ZEND_INTERNAL_CLASS); } break; case ZEND_ACC_PUBLIC: - if (IS_INTERNED(name)) { - property_info.name = (char*)name; - } else { - property_info.name = ce->type & ZEND_INTERNAL_CLASS ? zend_strndup(name, name_length) : estrndup(name, name_length); - } - property_info.name_length = name_length; + property_info.name = STR_COPY(name); break; } - interned_name = zend_new_interned_string(property_info.name, property_info.name_length+1, 0 TSRMLS_CC); - if (interned_name != property_info.name) { - if (ce->type == ZEND_USER_CLASS) { - efree((char*)property_info.name); - } else { - free((char*)property_info.name); - } - property_info.name = interned_name; - } + property_info.name = zend_new_interned_string(property_info.name TSRMLS_CC); property_info.flags = access_type; - property_info.h = (access_type & ZEND_ACC_PUBLIC) ? h : zend_get_hash_value(property_info.name, property_info.name_length+1); - property_info.doc_comment = doc_comment; - property_info.doc_comment_len = doc_comment_len; + property_info.doc_comment = doc_comment ? STR_COPY(doc_comment) : NULL; property_info.ce = ce; - zend_hash_quick_update(&ce->properties_info, name, name_length+1, h, &property_info, sizeof(zend_property_info), NULL); + zend_hash_update_mem(&ce->properties_info, name, &property_info, sizeof(zend_property_info)); return SUCCESS; } @@ -3514,181 +3498,116 @@ ZEND_API int zend_declare_property_ex(zend_class_entry *ce, const char *name, in ZEND_API int zend_declare_property(zend_class_entry *ce, const char *name, int name_length, zval *property, int access_type TSRMLS_DC) /* {{{ */ { - return zend_declare_property_ex(ce, name, name_length, property, access_type, NULL, 0 TSRMLS_CC); + zend_string *key = STR_INIT(name, name_length, ce->type & ZEND_INTERNAL_CLASS); + int ret = zend_declare_property_ex(ce, key, property, access_type, NULL TSRMLS_CC); + STR_RELEASE(key); + return ret; } /* }}} */ ZEND_API int zend_declare_property_null(zend_class_entry *ce, const char *name, int name_length, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - } else { - ALLOC_ZVAL(property); - } - INIT_ZVAL(*property); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_NULL(&property); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_property_bool(zend_class_entry *ce, const char *name, int name_length, long value, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - } else { - ALLOC_ZVAL(property); - } - INIT_PZVAL(property); - ZVAL_BOOL(property, value); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_BOOL(&property, value); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_property_long(zend_class_entry *ce, const char *name, int name_length, long value, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - } else { - ALLOC_ZVAL(property); - } - INIT_PZVAL(property); - ZVAL_LONG(property, value); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_LONG(&property, value); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_property_double(zend_class_entry *ce, const char *name, int name_length, double value, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - } else { - ALLOC_ZVAL(property); - } - INIT_PZVAL(property); - ZVAL_DOUBLE(property, value); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_DOUBLE(&property, value); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_property_string(zend_class_entry *ce, const char *name, int name_length, const char *value, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; - int len = strlen(value); + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - ZVAL_STRINGL(property, zend_strndup(value, len), len, 0); - } else { - ALLOC_ZVAL(property); - ZVAL_STRINGL(property, value, len, 1); - } - INIT_PZVAL(property); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_STR(&property, STR_INIT(value, strlen(value), ce->type & ZEND_INTERNAL_CLASS)); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_property_stringl(zend_class_entry *ce, const char *name, int name_length, const char *value, int value_len, int access_type TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(property); - ZVAL_STRINGL(property, zend_strndup(value, value_len), value_len, 0); - } else { - ALLOC_ZVAL(property); - ZVAL_STRINGL(property, value, value_len, 1); - } - INIT_PZVAL(property); - return zend_declare_property(ce, name, name_length, property, access_type TSRMLS_CC); + ZVAL_STR(&property, STR_INIT(value, value_len, ce->type & ZEND_INTERNAL_CLASS)); + return zend_declare_property(ce, name, name_length, &property, access_type TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_class_constant(zend_class_entry *ce, const char *name, size_t name_length, zval *value TSRMLS_DC) /* {{{ */ { - return zend_hash_update(&ce->constants_table, name, name_length+1, &value, sizeof(zval *), NULL); + return zend_hash_str_update(&ce->constants_table, name, name_length, value) ? + SUCCESS : FAILURE; } /* }}} */ ZEND_API int zend_declare_class_constant_null(zend_class_entry *ce, const char *name, size_t name_length TSRMLS_DC) /* {{{ */ { - zval *constant; + zval constant; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(constant); - } else { - ALLOC_ZVAL(constant); - } - ZVAL_NULL(constant); - INIT_PZVAL(constant); - return zend_declare_class_constant(ce, name, name_length, constant TSRMLS_CC); + ZVAL_NULL(&constant); + return zend_declare_class_constant(ce, name, name_length, &constant TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_class_constant_long(zend_class_entry *ce, const char *name, size_t name_length, long value TSRMLS_DC) /* {{{ */ { - zval *constant; + zval constant; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(constant); - } else { - ALLOC_ZVAL(constant); - } - ZVAL_LONG(constant, value); - INIT_PZVAL(constant); - return zend_declare_class_constant(ce, name, name_length, constant TSRMLS_CC); + ZVAL_LONG(&constant, value); + return zend_declare_class_constant(ce, name, name_length, &constant TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_class_constant_bool(zend_class_entry *ce, const char *name, size_t name_length, zend_bool value TSRMLS_DC) /* {{{ */ { - zval *constant; + zval constant; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(constant); - } else { - ALLOC_ZVAL(constant); - } - ZVAL_BOOL(constant, value); - INIT_PZVAL(constant); - return zend_declare_class_constant(ce, name, name_length, constant TSRMLS_CC); + ZVAL_BOOL(&constant, value); + return zend_declare_class_constant(ce, name, name_length, &constant TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_class_constant_double(zend_class_entry *ce, const char *name, size_t name_length, double value TSRMLS_DC) /* {{{ */ { - zval *constant; + zval constant; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(constant); - } else { - ALLOC_ZVAL(constant); - } - ZVAL_DOUBLE(constant, value); - INIT_PZVAL(constant); - return zend_declare_class_constant(ce, name, name_length, constant TSRMLS_CC); + ZVAL_DOUBLE(&constant, value); + return zend_declare_class_constant(ce, name, name_length, &constant TSRMLS_CC); } /* }}} */ ZEND_API int zend_declare_class_constant_stringl(zend_class_entry *ce, const char *name, size_t name_length, const char *value, size_t value_length TSRMLS_DC) /* {{{ */ { - zval *constant; + zval constant; - if (ce->type & ZEND_INTERNAL_CLASS) { - ALLOC_PERMANENT_ZVAL(constant); - ZVAL_STRINGL(constant, zend_strndup(value, value_length), value_length, 0); - } else { - ALLOC_ZVAL(constant); - ZVAL_STRINGL(constant, value, value_length, 1); - } - INIT_PZVAL(constant); - return zend_declare_class_constant(ce, name, name_length, constant TSRMLS_CC); + ZVAL_STR(&constant, STR_INIT(value, value_length, ce->type & ZEND_INTERNAL_CLASS)); + return zend_declare_class_constant(ce, name, name_length, &constant TSRMLS_CC); } /* }}} */ @@ -3700,22 +3619,17 @@ ZEND_API int zend_declare_class_constant_string(zend_class_entry *ce, const char ZEND_API void zend_update_property(zend_class_entry *scope, zval *object, const char *name, int name_length, zval *value TSRMLS_DC) /* {{{ */ { - zval *property; + zval property; zend_class_entry *old_scope = EG(scope); EG(scope) = scope; if (!Z_OBJ_HT_P(object)->write_property) { - const char *class_name; - zend_uint class_name_len; - - zend_get_object_classname(object, &class_name, &class_name_len TSRMLS_CC); - - zend_error(E_CORE_ERROR, "Property %s of class %s cannot be updated", name, class_name); + zend_string *class_name = zend_get_object_classname(object TSRMLS_CC); + zend_error(E_CORE_ERROR, "Property %s of class %s cannot be updated", name, class_name->val); } - MAKE_STD_ZVAL(property); - ZVAL_STRINGL(property, name, name_length, 1); - Z_OBJ_HT_P(object)->write_property(object, property, value, 0 TSRMLS_CC); + ZVAL_STRINGL(&property, name, name_length); + Z_OBJ_HT_P(object)->write_property(object, &property, value, 0 TSRMLS_CC); zval_ptr_dtor(&property); EG(scope) = old_scope; @@ -3724,105 +3638,91 @@ ZEND_API void zend_update_property(zend_class_entry *scope, zval *object, const ZEND_API void zend_update_property_null(zend_class_entry *scope, zval *object, const char *name, int name_length TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_NULL(tmp); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_NULL(&tmp); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API void zend_update_property_bool(zend_class_entry *scope, zval *object, const char *name, int name_length, long value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_BOOL(tmp, value); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_BOOL(&tmp, value); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API void zend_update_property_long(zend_class_entry *scope, zval *object, const char *name, int name_length, long value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_LONG(tmp, value); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_LONG(&tmp, value); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API void zend_update_property_double(zend_class_entry *scope, zval *object, const char *name, int name_length, double value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_DOUBLE(tmp, value); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_DOUBLE(&tmp, value); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API void zend_update_property_string(zend_class_entry *scope, zval *object, const char *name, int name_length, const char *value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_STRING(tmp, value, 1); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_STRING(&tmp, value); + Z_SET_REFCOUNT(tmp, 0); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API void zend_update_property_stringl(zend_class_entry *scope, zval *object, const char *name, int name_length, const char *value, int value_len TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_STRINGL(tmp, value, value_len, 1); - zend_update_property(scope, object, name, name_length, tmp TSRMLS_CC); + ZVAL_STRINGL(&tmp, value, value_len); + Z_SET_REFCOUNT(tmp, 0); + zend_update_property(scope, object, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property(zend_class_entry *scope, const char *name, int name_length, zval *value TSRMLS_DC) /* {{{ */ { - zval **property; + zval *property; zend_class_entry *old_scope = EG(scope); + zend_string *key = STR_INIT(name, name_length, 0); EG(scope) = scope; - property = zend_std_get_static_property(scope, name, name_length, 0, NULL TSRMLS_CC); + property = zend_std_get_static_property(scope, key, 0, NULL TSRMLS_CC); EG(scope) = old_scope; + STR_FREE(key); if (!property) { return FAILURE; } else { - if (*property != value) { - if (PZVAL_IS_REF(*property)) { - zval_dtor(*property); - Z_TYPE_PP(property) = Z_TYPE_P(value); - (*property)->value = value->value; + if (property != value) { + if (Z_ISREF_P(property)) { + zval_dtor(property); + ZVAL_COPY_VALUE(property, value); if (Z_REFCOUNT_P(value) > 0) { - zval_copy_ctor(*property); + zval_copy_ctor(property); } else { - efree(value); +//??? efree(value); } } else { - zval *garbage = *property; + zval garbage; + ZVAL_COPY_VALUE(&garbage, property); Z_ADDREF_P(value); - if (PZVAL_IS_REF(value)) { - SEPARATE_ZVAL(&value); + if (Z_ISREF_P(value)) { + SEPARATE_ZVAL(value); } - *property = value; + ZVAL_COPY_VALUE(property, value); zval_ptr_dtor(&garbage); } } @@ -3833,94 +3733,74 @@ ZEND_API int zend_update_static_property(zend_class_entry *scope, const char *na ZEND_API int zend_update_static_property_null(zend_class_entry *scope, const char *name, int name_length TSRMLS_DC) /* {{{ */ { - zval *tmp; - - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_NULL(tmp); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + zval tmp; + + ZVAL_NULL(&tmp); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property_bool(zend_class_entry *scope, const char *name, int name_length, long value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_BOOL(tmp, value); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + ZVAL_BOOL(&tmp, value); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property_long(zend_class_entry *scope, const char *name, int name_length, long value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_LONG(tmp, value); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + ZVAL_LONG(&tmp, value); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property_double(zend_class_entry *scope, const char *name, int name_length, double value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_DOUBLE(tmp, value); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + ZVAL_DOUBLE(&tmp, value); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property_string(zend_class_entry *scope, const char *name, int name_length, const char *value TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_STRING(tmp, value, 1); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + ZVAL_STRING(&tmp, value); + Z_SET_REFCOUNT(tmp, 0); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API int zend_update_static_property_stringl(zend_class_entry *scope, const char *name, int name_length, const char *value, int value_len TSRMLS_DC) /* {{{ */ { - zval *tmp; + zval tmp; - ALLOC_ZVAL(tmp); - Z_UNSET_ISREF_P(tmp); - Z_SET_REFCOUNT_P(tmp, 0); - ZVAL_STRINGL(tmp, value, value_len, 1); - return zend_update_static_property(scope, name, name_length, tmp TSRMLS_CC); + ZVAL_STRINGL(&tmp, value, value_len); + Z_SET_REFCOUNT(tmp, 0); + return zend_update_static_property(scope, name, name_length, &tmp TSRMLS_CC); } /* }}} */ ZEND_API zval *zend_read_property(zend_class_entry *scope, zval *object, const char *name, int name_length, zend_bool silent TSRMLS_DC) /* {{{ */ { - zval *property, *value; + zval property, *value; zend_class_entry *old_scope = EG(scope); EG(scope) = scope; if (!Z_OBJ_HT_P(object)->read_property) { - const char *class_name; - zend_uint class_name_len; - - zend_get_object_classname(object, &class_name, &class_name_len TSRMLS_CC); - zend_error(E_CORE_ERROR, "Property %s of class %s cannot be read", name, class_name); + zend_string *class_name = zend_get_object_classname(object TSRMLS_CC); + zend_error(E_CORE_ERROR, "Property %s of class %s cannot be read", name, class_name->val); } - MAKE_STD_ZVAL(property); - ZVAL_STRINGL(property, name, name_length, 1); - value = Z_OBJ_HT_P(object)->read_property(object, property, silent?BP_VAR_IS:BP_VAR_R, 0 TSRMLS_CC); + ZVAL_STRINGL(&property, name, name_length); + value = Z_OBJ_HT_P(object)->read_property(object, &property, silent?BP_VAR_IS:BP_VAR_R, 0 TSRMLS_CC); zval_ptr_dtor(&property); EG(scope) = old_scope; @@ -3930,14 +3810,16 @@ ZEND_API zval *zend_read_property(zend_class_entry *scope, zval *object, const c ZEND_API zval *zend_read_static_property(zend_class_entry *scope, const char *name, int name_length, zend_bool silent TSRMLS_DC) /* {{{ */ { - zval **property; + zval *property; zend_class_entry *old_scope = EG(scope); + zend_string *key = STR_INIT(name, name_length, 0); EG(scope) = scope; - property = zend_std_get_static_property(scope, name, name_length, silent, NULL TSRMLS_CC); + property = zend_std_get_static_property(scope, key, silent, NULL TSRMLS_CC); EG(scope) = old_scope; + STR_FREE(key); - return property?*property:NULL; + return property; } /* }}} */ @@ -3945,10 +3827,7 @@ ZEND_API void zend_save_error_handling(zend_error_handling *current TSRMLS_DC) / { current->handling = EG(error_handling); current->exception = EG(exception_class); - current->user_handler = EG(user_error_handler); - if (current->user_handler) { - Z_ADDREF_P(current->user_handler); - } + ZVAL_COPY(¤t->user_handler, &EG(user_error_handler)); } /* }}} */ @@ -3956,9 +3835,9 @@ ZEND_API void zend_replace_error_handling(zend_error_handling_t error_handling, { if (current) { zend_save_error_handling(current TSRMLS_CC); - if (error_handling != EH_NORMAL && EG(user_error_handler)) { + if (error_handling != EH_NORMAL && Z_TYPE(EG(user_error_handler)) != IS_UNDEF) { zval_ptr_dtor(&EG(user_error_handler)); - EG(user_error_handler) = NULL; + ZVAL_UNDEF(&EG(user_error_handler)); } } EG(error_handling) = error_handling; @@ -3970,27 +3849,26 @@ ZEND_API void zend_restore_error_handling(zend_error_handling *saved TSRMLS_DC) { EG(error_handling) = saved->handling; EG(exception_class) = saved->handling == EH_THROW ? saved->exception : NULL; - if (saved->user_handler && saved->user_handler != EG(user_error_handler)) { - if (EG(user_error_handler)) { - zval_ptr_dtor(&EG(user_error_handler)); - } - EG(user_error_handler) = saved->user_handler; - } else if (saved->user_handler) { - zval_ptr_dtor(&saved->user_handler); + if (Z_TYPE(saved->user_handler) != IS_UNDEF) { +//??? && saved->user_handler != EG(user_error_handler)) { + zval_ptr_dtor(&EG(user_error_handler)); + ZVAL_COPY_VALUE(&EG(user_error_handler), &saved->user_handler); +//??? } else if (saved->user_handler) { +//??? zval_ptr_dtor(&saved->user_handler); } - saved->user_handler = NULL; + ZVAL_UNDEF(&saved->user_handler); } /* }}} */ -ZEND_API const char* zend_find_alias_name(zend_class_entry *ce, const char *name, zend_uint len) /* {{{ */ +ZEND_API zend_string* zend_find_alias_name(zend_class_entry *ce, zend_string *name) /* {{{ */ { zend_trait_alias *alias, **alias_ptr; if ((alias_ptr = ce->trait_aliases)) { alias = *alias_ptr; while (alias) { - if (alias->alias_len == len && - !strncasecmp(name, alias->alias, alias->alias_len)) { + if (alias->alias->len == name->len && + !strncasecmp(name->val, alias->alias->val, alias->alias->len)) { return alias->alias; } alias_ptr++; @@ -4002,7 +3880,7 @@ ZEND_API const char* zend_find_alias_name(zend_class_entry *ce, const char *name } /* }}} */ -ZEND_API const char* zend_resolve_method_name(zend_class_entry *ce, zend_function *f) /* {{{ */ +ZEND_API zend_string *zend_resolve_method_name(zend_class_entry *ce, zend_function *f) /* {{{ */ { zend_function *func; HashPosition iterator; @@ -4017,21 +3895,19 @@ ZEND_API const char* zend_resolve_method_name(zend_class_entry *ce, zend_functio function_table = &ce->function_table; zend_hash_internal_pointer_reset_ex(function_table, &iterator); - while (zend_hash_get_current_data_ex(function_table, (void **)&func, &iterator) == SUCCESS) { + while ((func = zend_hash_get_current_data_ptr_ex(function_table, &iterator)) != NULL) { if (func == f) { - char *name; - uint len; + zend_string *name; ulong idx; - if (zend_hash_get_current_key_ex(function_table, &name, &len, &idx, 0, &iterator) != HASH_KEY_IS_STRING) { + if (zend_hash_get_current_key_ex(function_table, &name, &idx, 0, &iterator) != HASH_KEY_IS_STRING) { return f->common.function_name; } - --len; - if (len == strlen(f->common.function_name) && - !strncasecmp(name, f->common.function_name, len)) { + if (name->len == f->common.function_name->len && + !strncasecmp(name->val, f->common.function_name->val, f->common.function_name->len)) { return f->common.function_name; } - return zend_find_alias_name(f->common.scope, name, len); + return zend_find_alias_name(f->common.scope, name); } zend_hash_move_forward_ex(function_table, &iterator); } |