summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ext/phar/phar_object.c1
-rw-r--r--ext/phar/tests/bug69958.phpt2
2 files changed, 3 insertions, 0 deletions
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
index b080e65b07..46c3d7cb34 100644
--- a/ext/phar/phar_object.c
+++ b/ext/phar/phar_object.c
@@ -2129,6 +2129,7 @@ static zval *phar_rename_archive(phar_archive_data **sphar, char *ext, zend_bool
phar_destroy_phar_data(phar TSRMLS_CC);
*sphar = NULL;
phar = *pphar;
+ *sphar = NULL;
phar->refcount++;
newpath = oldpath;
goto its_ok;
diff --git a/ext/phar/tests/bug69958.phpt b/ext/phar/tests/bug69958.phpt
index d63b413c29..96f2198b14 100644
--- a/ext/phar/tests/bug69958.phpt
+++ b/ext/phar/tests/bug69958.phpt
@@ -1,5 +1,7 @@
--TEST--
Phar: bug #69958: Segfault in Phar::convertToData on invalid file
+--XFAIL--
+Still has memory leaks, see https://bugs.php.net/bug.php?id=70005
--SKIPIF--
<?php if (!extension_loaded("phar")) die("skip"); ?>
--FILE--