summaryrefslogtreecommitdiff
path: root/main/streams
diff options
context:
space:
mode:
authorliudaixiao <dinosaur.liu@gmail.com>2019-12-16 09:10:28 +0800
committerNikita Popov <nikita.ppv@gmail.com>2020-01-23 14:57:16 +0100
commit67421a780d670ea2eec8157c39f2682bb3cfb7dd (patch)
treed6387e34b7c03fb334176632b169411f16872311 /main/streams
parentf720fb1e21f374bf84f5f6ce295175f369bc1291 (diff)
downloadphp-git-67421a780d670ea2eec8157c39f2682bb3cfb7dd.tar.gz
Fixed bug #78902
Diffstat (limited to 'main/streams')
-rw-r--r--main/streams/streams.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/main/streams/streams.c b/main/streams/streams.c
index 705f3bc633..5daf4fe83d 100644
--- a/main/streams/streams.c
+++ b/main/streams/streams.c
@@ -577,8 +577,15 @@ PHPAPI void _php_stream_fill_read_buffer(php_stream *stream, size_t size)
* stream read buffer */
while (brig_inp->head) {
bucket = brig_inp->head;
- /* grow buffer to hold this bucket
- * TODO: this can fail for persistent streams */
+ /* reduce buffer memory consumption if possible, to avoid a realloc */
+ if (stream->readbuf && stream->readbuflen - stream->writepos < bucket->buflen) {
+ if (stream->writepos > stream->readpos) {
+ memmove(stream->readbuf, stream->readbuf + stream->readpos, stream->writepos - stream->readpos);
+ }
+ stream->writepos -= stream->readpos;
+ stream->readpos = 0;
+ }
+ /* grow buffer to hold this bucket */
if (stream->readbuflen - stream->writepos < bucket->buflen) {
stream->readbuflen += bucket->buflen;
stream->readbuf = perealloc(stream->readbuf, stream->readbuflen,