diff options
| author | Nikita Popov <nikic@php.net> | 2015-01-05 17:02:11 +0100 |
|---|---|---|
| committer | Nikita Popov <nikic@php.net> | 2015-01-05 17:02:11 +0100 |
| commit | 1266515e19cb30dab5c63df764d18233a234aba6 (patch) | |
| tree | bb8e7ddbb307ac184350736020d4f17ddc062845 /ext/standard/assert.c | |
| parent | 411980a8bcb713694efa7656b423f8e6b2b6de48 (diff) | |
| download | php-git-1266515e19cb30dab5c63df764d18233a234aba6.tar.gz | |
Fix uses of zval_add_ref and add comment on usage
zval_add_ref should be used as a copy ctor, after the value was
already copied.
In particular when used with hash insertions, it should be applied
to the return value of the insert function.
Diffstat (limited to 'ext/standard/assert.c')
| -rw-r--r-- | ext/standard/assert.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ext/standard/assert.c b/ext/standard/assert.c index a0a8569adb..032b937f17 100644 --- a/ext/standard/assert.c +++ b/ext/standard/assert.c @@ -325,11 +325,9 @@ PHP_FUNCTION(assert_options) } if (ac == 2) { zval_ptr_dtor(&ASSERTG(callback)); - ASSERTG(callback) = *value; - zval_add_ref(value); + ZVAL_COPY(&ASSERTG(callback), value); } return; - break; default: php_error_docref(NULL, E_WARNING, "Unknown value %pd", what); |