diff options
author | Nikita Popov <nikic@php.net> | 2015-04-02 18:52:32 +0200 |
---|---|---|
committer | Nikita Popov <nikic@php.net> | 2015-04-06 11:27:34 +0200 |
commit | 122d759618a42bff105971b923fbbb5be02e34b9 (patch) | |
tree | fd4487414ffa3f120c77b19b9eb7dc409659c57e /ext/reflection/tests/ReflectionFunction_construct.001.phpt | |
parent | 884b0365dbe718f667d048dbc3d1cd9d9f12ab84 (diff) | |
download | php-git-122d759618a42bff105971b923fbbb5be02e34b9.tar.gz |
Always throw TypeException on throwing zpp failures
Introduces a ZEND_PARSE_PARAMS_THROW flag for zpp, which forces to
report FAILURE errors using a TypeException instead of a Warning,
like it would happen in strict mode.
Adds a zend_parse_parameters_throw() convenience function, which
invokes zpp with this flag.
Converts all cases I could identify, where we currently have
throwing zpp usage in constructors and replaces them with this API.
Error handling is still replaced to EH_THROW in some cases to handle
other, domain-specific errors in constructors.
Diffstat (limited to 'ext/reflection/tests/ReflectionFunction_construct.001.phpt')
-rw-r--r-- | ext/reflection/tests/ReflectionFunction_construct.001.phpt | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/ext/reflection/tests/ReflectionFunction_construct.001.phpt b/ext/reflection/tests/ReflectionFunction_construct.001.phpt index 90259ac997..52db7c654d 100644 --- a/ext/reflection/tests/ReflectionFunction_construct.001.phpt +++ b/ext/reflection/tests/ReflectionFunction_construct.001.phpt @@ -9,31 +9,27 @@ Steve Seear <stevseea@php.net> try { $a = new ReflectionFunction(array(1, 2, 3)); echo "exception not thrown.".PHP_EOL; -} -catch(ReflectionException $re) { +} catch (TypeException $re) { echo "Ok - ".$re->getMessage().PHP_EOL; } try { $a = new ReflectionFunction('nonExistentFunction'); -} catch (Exception $e) { +} catch (ReflectionException $e) { echo $e->getMessage().PHP_EOL; } try { $a = new ReflectionFunction(); -} -catch(ReflectionException $re) { +} catch (TypeException $re) { echo "Ok - ".$re->getMessage().PHP_EOL; } try { $a = new ReflectionFunction(1, 2); -} -catch(ReflectionException $re) { +} catch (TypeException $re) { echo "Ok - ".$re->getMessage().PHP_EOL; } try { $a = new ReflectionFunction([]); -} -catch(ReflectionException $re) { +} catch (TypeException $re) { echo "Ok - ".$re->getMessage().PHP_EOL; } |