Revert "Avoid unused fstat() call"

This reverts commit 5a90dc77b8f244f603082aea022fadc0ce2c009c.

Let's try to go with the reverse direction here and actually trust
the reported size...

1 files changed, 46 insertions, 19 deletions

diff --git a/Zend/zend_stream.c b/Zend/zend_stream.c
index 2403800db7..cf1a3c107b 100644
--- a/Zend/zend_stream.c
+++ b/Zend/zend_stream.c
@@ -23,10 +23,6 @@
 #include "zend_compile.h"
 #include "zend_stream.h"
 
-#ifndef S_ISREG
-# define S_ISREG(m) 1
-#endif
-
 ZEND_DLIMPORT int isatty(int fd);
 
 static size_t zend_stream_stdio_reader(void *handle, char *buf, size_t len) /* {{{ */
@@ -41,6 +37,39 @@ static void zend_stream_stdio_closer(void *handle) /* {{{ */
 	}
 } /* }}} */
 
+static size_t zend_stream_stdio_fsizer(void *handle) /* {{{ */
+{
+	zend_stat_t buf;
+	if (handle && zend_fstat(fileno((FILE*)handle), &buf) == 0) {
+#ifdef S_ISREG
+		if (!S_ISREG(buf.st_mode)) {
+			return 0;
+		}
+#endif
+		return buf.st_size;
+	}
+	return 0;
+} /* }}} */
+
+static size_t zend_stream_fsize(zend_file_handle *file_handle) /* {{{ */
+{
+	zend_stat_t buf;
+
+	if (file_handle->type == ZEND_HANDLE_STREAM) {
+		return file_handle->handle.stream.fsizer(file_handle->handle.stream.handle);
+	}
+	if (file_handle->handle.fp && zend_fstat(fileno(file_handle->handle.fp), &buf) == 0) {
+#ifdef S_ISREG
+		if (!S_ISREG(buf.st_mode)) {
+			return 0;
+		}
+#endif
+		return buf.st_size;
+	}
+
+	return -1;
+} /* }}} */
+
 ZEND_API void zend_stream_init_fp(zend_file_handle *handle, FILE *fp, const char *filename) {
 	memset(handle, 0, sizeof(zend_file_handle));
 	handle->type = ZEND_HANDLE_FP;
@@ -96,7 +125,8 @@ static size_t zend_stream_read(zend_file_handle *file_handle, char *buf, size_t
 
 ZEND_API int zend_stream_fixup(zend_file_handle *file_handle, char **buf, size_t *len) /* {{{ */
 {
-	size_t size = 0;
+	size_t size;
+	zend_bool is_fp = 0;
 
 	if (file_handle->buf) {
 		*buf = file_handle->buf;
@@ -111,28 +141,25 @@ ZEND_API int zend_stream_fixup(zend_file_handle *file_handle, char **buf, size_t
 	}
 
 	if (file_handle->type == ZEND_HANDLE_FP) {
-		FILE *fp = file_handle->handle.fp;
-		int is_tty;
-		if (!fp) {
+		if (!file_handle->handle.fp) {
 			return FAILURE;
 		}
 
-		is_tty = isatty(fileno(fp));
-		if (!is_tty) {
-			zend_stat_t buf;
-			if (zend_fstat(fileno(fp), &buf) == 0 && S_ISREG(buf.st_mode)) {
-				size = buf.st_size;
-			}
-		}
-
+		is_fp = 1;
 		file_handle->type = ZEND_HANDLE_STREAM;
-		file_handle->handle.stream.handle = fp;
-		file_handle->handle.stream.isatty = is_tty;
+		file_handle->handle.stream.handle = file_handle->handle.fp;
+		file_handle->handle.stream.isatty = isatty(fileno((FILE *)file_handle->handle.stream.handle));
 		file_handle->handle.stream.reader = (zend_stream_reader_t)zend_stream_stdio_reader;
 		file_handle->handle.stream.closer = (zend_stream_closer_t)zend_stream_stdio_closer;
+		file_handle->handle.stream.fsizer = (zend_stream_fsizer_t)zend_stream_stdio_fsizer;
+	}
+
+	size = zend_stream_fsize(file_handle);
+	if (size == (size_t)-1) {
+		return FAILURE;
 	}
 
-	if (size) {
+	if (is_fp && !file_handle->handle.stream.isatty && size) {
 		file_handle->buf = *buf = safe_emalloc(1, size, ZEND_MMAP_AHEAD);
 		file_handle->len = zend_stream_read(file_handle, *buf, size);
 	} else {