diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2020-06-16 16:29:05 +0200 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2020-06-16 18:39:09 +0200 |
| commit | 92c4b0651368a4135f692af48f4716c96de4bd92 (patch) | |
| tree | 052276ba1af9bcf5fd113f9bf8d6d93075d69aa3 /Zend/zend_operators.c | |
| parent | 9ff3230c20f27ac35788aca72f16ff928a25f81b (diff) | |
| download | php-git-92c4b0651368a4135f692af48f4716c96de4bd92.tar.gz | |
Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)
Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds. This may be useful for other compilers as well.
[1] <https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019>
Diffstat (limited to 'Zend/zend_operators.c')
| -rw-r--r-- | Zend/zend_operators.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c index d07d228752..9fdc006e64 100644 --- a/Zend/zend_operators.c +++ b/Zend/zend_operators.c @@ -2089,7 +2089,7 @@ ZEND_API int ZEND_FASTCALL zend_compare(zval *op1, zval *op2) /* {{{ */ } else if (Z_TYPE_P(op2)==IS_ARRAY) { return -1; } else { - ZEND_ASSERT(0); + ZEND_UNREACHABLE(); zend_throw_error(NULL, "Unsupported operand types"); return 1; } |