diff options
author | Sammy Kaye Powers <sammyk@php.net> | 2020-09-24 12:57:43 -0700 |
---|---|---|
committer | Sammy Kaye Powers <sammyk@php.net> | 2020-09-25 11:46:15 -0700 |
commit | e42abeafeca245950ebc47c7312913e68262d40e (patch) | |
tree | bf62186a7ea10351ed31063a3bd2455fa7b978b4 /Zend/zend_observer.h | |
parent | a91cb2f48c275751df1ab0a3f9e9a28c200add77 (diff) | |
download | php-git-e42abeafeca245950ebc47c7312913e68262d40e.tar.gz |
Pass zend_execute_data instead of zend_function to fcall init
The motivation for this change is to prevent extensions from having to check executor globals for the current execute_data during function call init. A previous implementation of the observer API initialized the function call from runtime cache initialization before execute_data was allocated which is why zend_function was passed in.
But now that the observer API is implemented via opcode specialization, it makes sense to pass in the execute_data. This also keeps the API a bit more consistent for existing extensions that already hook zend_execute_ex.
Closes GH-6209
Diffstat (limited to 'Zend/zend_observer.h')
-rw-r--r-- | Zend/zend_observer.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Zend/zend_observer.h b/Zend/zend_observer.h index 246a3a61be..1d20306a17 100644 --- a/Zend/zend_observer.h +++ b/Zend/zend_observer.h @@ -50,7 +50,7 @@ typedef struct _zend_observer_fcall_handlers { } zend_observer_fcall_handlers; /* If the fn should not be observed then return {NULL, NULL} */ -typedef zend_observer_fcall_handlers (*zend_observer_fcall_init)(zend_function *func); +typedef zend_observer_fcall_handlers (*zend_observer_fcall_init)(zend_execute_data *execute_data); // Call during minit/startup ONLY ZEND_API void zend_observer_fcall_register(zend_observer_fcall_init); |