summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSriram Natarajan <srinatar@php.net>2010-01-05 19:25:23 +0000
committerSriram Natarajan <srinatar@php.net>2010-01-05 19:25:23 +0000
commit9a1251eae7b431e1454d528575720f8b29964bcb (patch)
tree08b43296e1beefa21f0d17f266a550765dd0c3c2
parent18946d2c913492b052f6d17517db06f4d3b37e47 (diff)
downloadphp-git-9a1251eae7b431e1454d528575720f8b29964bcb.tar.gz
- Addressing minor leak noticed while addressing bug #48590
-rw-r--r--ext/soap/php_http.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/ext/soap/php_http.c b/ext/soap/php_http.c
index 68643c9ae8..866fa418f5 100644
--- a/ext/soap/php_http.c
+++ b/ext/soap/php_http.c
@@ -764,9 +764,9 @@ try_again:
smart_str_0(&soap_headers);
err = php_stream_write(stream, soap_headers.c, soap_headers.len);
+ smart_str_free(&soap_headers);
if (err != soap_headers.len) {
if (request != buf) {efree(request);}
- smart_str_free(&soap_headers);
php_stream_close(stream);
if (client->url) {
php_url_free(client->url);
@@ -778,8 +778,6 @@ try_again:
smart_str_free(&soap_headers_z);
return FALSE;
}
- smart_str_free(&soap_headers);
-
} else {
add_soap_fault(this_ptr, "HTTP", "Failed to create stream??", NULL, NULL TSRMLS_CC);
smart_str_free(&soap_headers_z);
@@ -1034,8 +1032,8 @@ try_again:
phpurl = new_url;
if (--redirect_max < 1) {
- smart_str_free(&soap_headers_z);
add_soap_fault(this_ptr, "HTTP", "Redirection limit reached, aborting", NULL, NULL TSRMLS_CC);
+ smart_str_free(&soap_headers_z);
return FALSE;
}