summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierrick Charron <pierrick@php.net>2011-08-08 03:08:59 +0000
committerPierrick Charron <pierrick@php.net>2011-08-08 03:08:59 +0000
commit6ea19be48928d62dbffd3c5057671a220496c70c (patch)
treee6fca432ef9c808c45adb0c67335458bd9d012b1
parent8bae5e220e19e76b8643bdb9fc2b60ff194c5a2f (diff)
downloadphp-git-6ea19be48928d62dbffd3c5057671a220496c70c.tar.gz
Use snprintf and strncat to make the static analyzers happy
-rw-r--r--Zend/zend.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/Zend/zend.c b/Zend/zend.c
index b25bfd97e7..333ff693b4 100644
--- a/Zend/zend.c
+++ b/Zend/zend.c
@@ -870,7 +870,7 @@ void zend_append_version_info(const zend_extension *extension) /* {{{ */
char *new_info;
uint new_info_length;
- new_info_length = sizeof(" with v, by \n")
+ new_info_length = sizeof(" with v, , by \n")
+ strlen(extension->name)
+ strlen(extension->version)
+ strlen(extension->copyright)
@@ -878,10 +878,10 @@ void zend_append_version_info(const zend_extension *extension) /* {{{ */
new_info = (char *) malloc(new_info_length + 1);
- sprintf(new_info, " with %s v%s, %s, by %s\n", extension->name, extension->version, extension->copyright, extension->author);
+ snprintf(new_info, new_info_length, " with %s v%s, %s, by %s\n", extension->name, extension->version, extension->copyright, extension->author);
zend_version_info = (char *) realloc(zend_version_info, zend_version_info_length+new_info_length + 1);
- strcat(zend_version_info, new_info);
+ strncat(zend_version_info, new_info, new_info_length);
zend_version_info_length += new_info_length;
free(new_info);
}