summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2020-04-08 16:36:01 +0200
committerNikita Popov <nikita.ppv@gmail.com>2020-04-08 16:36:22 +0200
commit5317ea6d5753eb0d658fe81f815d17e304e9c804 (patch)
tree8d46e26beb49524cd1c5df953404a4725cefb9f2
parent73a0719f45782f843d2bd15ea22410390bc2de94 (diff)
downloadphp-git-5317ea6d5753eb0d658fe81f815d17e304e9c804.tar.gz
Make mysqli_poll test more deterministic
Handle errors appearing in different order.
-rw-r--r--ext/mysqli/tests/mysqli_poll_mixing_insert_select.phpt12
1 files changed, 7 insertions, 5 deletions
diff --git a/ext/mysqli/tests/mysqli_poll_mixing_insert_select.phpt b/ext/mysqli/tests/mysqli_poll_mixing_insert_select.phpt
index bfe780a9cd..0bafb2cc9b 100644
--- a/ext/mysqli/tests/mysqli_poll_mixing_insert_select.phpt
+++ b/ext/mysqli/tests/mysqli_poll_mixing_insert_select.phpt
@@ -106,7 +106,6 @@ if (!$IS_MYSQLND)
// either there is no result (no SELECT) or there is an error
if (mysqli_errno($link) > 0) {
$saved_errors[$thread_id] = mysqli_errno($link);
- printf("[003] '%s' caused %d\n", $links[$thread_id]['query'], mysqli_errno($link));
}
}
}
@@ -115,10 +114,13 @@ if (!$IS_MYSQLND)
// Checking if all lines are still usable
foreach ($links as $thread_id => $link) {
- if (isset($saved_errors[$thread_id]) &&
- $saved_errors[$thread_id] != mysqli_errno($link['link'])) {
- printf("[004] Error state not saved for query '%s', %d != %d\n", $link['query'],
- $saved_errors[$thread_id], mysqli_errno($link['link']));
+ if (isset($saved_errors[$thread_id])) {
+ printf("[003] '%s' caused %d\n",
+ $links[$thread_id]['query'], $saved_errors[$thread_id]);
+ if ($saved_errors[$thread_id] != mysqli_errno($link['link'])) {
+ printf("[004] Error state not saved for query '%s', %d != %d\n", $link['query'],
+ $saved_errors[$thread_id], mysqli_errno($link['link']));
+ }
}
if (!$res = mysqli_query($link['link'], 'SELECT * FROM test WHERE id = 100'))