diff options
| author | Harald Radi <phanto@php.net> | 2001-09-10 09:25:32 +0000 |
|---|---|---|
| committer | Harald Radi <phanto@php.net> | 2001-09-10 09:25:32 +0000 |
| commit | 21b9a2ca2a99432e31bb8eba62ce57b4db0ebbc4 (patch) | |
| tree | 26654676423e75fda19389b9070878645ad47394 | |
| parent | d1a2dbfd9dc005bb8b07ab63c7086978f71fd7c7 (diff) | |
| download | php-git-21b9a2ca2a99432e31bb8eba62ce57b4db0ebbc4.tar.gz | |
removed ->is_ref check, doesn't make sense and causes bugs
| -rw-r--r-- | ext/com/TODO | 16 | ||||
| -rw-r--r-- | ext/com/conversion.c | 2 | ||||
| -rw-r--r-- | ext/rpc/com/TODO | 16 | ||||
| -rw-r--r-- | ext/rpc/com/conversion.c | 2 |
4 files changed, 26 insertions, 10 deletions
diff --git a/ext/com/TODO b/ext/com/TODO index 3251b5da77..038df72a64 100644 --- a/ext/com/TODO +++ b/ext/com/TODO @@ -1,5 +1,5 @@ 1) Multi-dimenstional array support -2) IErrorInfo +-- done 2) IErrorInfo 3) WithEvents 4) Documentation (internal and user) and howtos 5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count) @@ -8,9 +8,17 @@ 8) Test suite (Needs test component) 9) reduce the need for VARIANT() 10) lets try if we are able to call non IDispatch - only Typelib components -11) IEnumVariant::Next() without parameter should only return an object, not an array with one element +-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element +12) VARIANT->value as lvalue -these seem to be done: +ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs +ad 4.) faq (i've collected a few questions from various lists) -2) 6) 11) +to be discussed: + +- dcom inporc issue +- mts support (getcontext) +- adsi support (ads* functions) +- winapi interface +- try serialisation support (if component implements IPersist) diff --git a/ext/com/conversion.c b/ext/com/conversion.c index 524888a37d..18ce7f17b8 100644 --- a/ext/com/conversion.c +++ b/ext/com/conversion.c @@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T } if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */ - type |= VT_BYREF; +// type |= VT_BYREF; } pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC); diff --git a/ext/rpc/com/TODO b/ext/rpc/com/TODO index 3251b5da77..038df72a64 100644 --- a/ext/rpc/com/TODO +++ b/ext/rpc/com/TODO @@ -1,5 +1,5 @@ 1) Multi-dimenstional array support -2) IErrorInfo +-- done 2) IErrorInfo 3) WithEvents 4) Documentation (internal and user) and howtos 5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count) @@ -8,9 +8,17 @@ 8) Test suite (Needs test component) 9) reduce the need for VARIANT() 10) lets try if we are able to call non IDispatch - only Typelib components -11) IEnumVariant::Next() without parameter should only return an object, not an array with one element +-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element +12) VARIANT->value as lvalue -these seem to be done: +ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs +ad 4.) faq (i've collected a few questions from various lists) -2) 6) 11) +to be discussed: + +- dcom inporc issue +- mts support (getcontext) +- adsi support (ads* functions) +- winapi interface +- try serialisation support (if component implements IPersist) diff --git a/ext/rpc/com/conversion.c b/ext/rpc/com/conversion.c index 524888a37d..18ce7f17b8 100644 --- a/ext/rpc/com/conversion.c +++ b/ext/rpc/com/conversion.c @@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T } if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */ - type |= VT_BYREF; +// type |= VT_BYREF; } pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC); |