summaryrefslogtreecommitdiff
path: root/sv.c
diff options
context:
space:
mode:
authorFather Chrysostomos <sprout@cpan.org>2011-12-03 09:36:38 -0800
committerFather Chrysostomos <sprout@cpan.org>2011-12-03 09:36:38 -0800
commit42932e1a33ce479972ea1398a41965265d8fb06b (patch)
treebbb25d5ef9a47754662ccaa7daea0930877be434 /sv.c
parentbdba49ad065980ae3ab85147a822d5b9098d33ca (diff)
downloadperl-42932e1a33ce479972ea1398a41965265d8fb06b.tar.gz
Remove SvTAINT from sv_sethek
This was copied from sv_usepvn_flags in commit 58b643af9. It is unnecessary, and probably incorrect, as heks are not tainted. Why sv_sethek used sv_usepvn_flags to begin with I don’t know, but I imagine it was for brevity’s sake. This code was ultimately derived from newSVhek, which doesn’t use sv_usepvn_flags. Because of that, and because it is now far enough removed from sv_usepvn_flags, I have removed the comment referring to it.
Diffstat (limited to 'sv.c')
-rw-r--r--sv.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/sv.c b/sv.c
index a2df6f5811..0aebda2f62 100644
--- a/sv.c
+++ b/sv.c
@@ -4583,13 +4583,9 @@ Perl_sv_sethek(pTHX_ register SV *const sv, const HEK *const hek)
return;
}
{
- /* Emulate what sv_usepvn_flags does; it can't be called
- directly, because it assumes that the data for the PV is at the
- start of a malloced block */
SV_CHECK_THINKFIRST_COW_DROP(sv);
SvUPGRADE(sv, SVt_PV);
SvPV_set(sv,(char *)HEK_KEY(share_hek_hek(hek)));
- SvTAINT(sv);
SvCUR_set(sv, HEK_LEN(hek));
SvLEN_set(sv, 0);
SvREADONLY_on(sv);