summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Fietkau <nbd@nbd.name>2017-11-06 11:11:49 +0100
committerFelix Fietkau <nbd@nbd.name>2017-11-06 11:23:51 +0100
commit69d6542848ed712a79dcba4965da4100e2804dd7 (patch)
tree2a9008e3cef8bef04a8068cc25ea0dbc0433fe54
parent7a49632ec93647187d5f87d9fdb6b3e81341d505 (diff)
downloadubox-69d6542848ed712a79dcba4965da4100e2804dd7.tar.gz
logd: only create pipe in stream mode
Signed-off-by: Felix Fietkau <nbd@nbd.name>
-rw-r--r--log/logd.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/log/logd.c b/log/logd.c
index 9b481cd..58abfad 100644
--- a/log/logd.c
+++ b/log/logd.c
@@ -103,13 +103,13 @@ read_log(struct ubus_context *ctx, struct ubus_object *obj,
stream = blobmsg_get_bool(tb[READ_STREAM]);
}
- if (pipe(fds) == -1) {
- fprintf(stderr, "logd: failed to create pipe: %s\n", strerror(errno));
- return -1;
- }
-
l = log_list(count, NULL);
if (stream) {
+ if (pipe(fds) == -1) {
+ fprintf(stderr, "logd: failed to create pipe: %s\n", strerror(errno));
+ return -1;
+ }
+
ubus_request_set_fd(ctx, req, fds[0]);
cl = calloc(1, sizeof(*cl));
cl->s.stream.notify_state = client_notify_state;