diff options
| author | Pravin Shelar <pshelar@nicira.com> | 2011-09-15 19:36:17 -0700 |
|---|---|---|
| committer | Pravin Shelar <pshelar@nicira.com> | 2011-09-15 19:36:17 -0700 |
| commit | f613a0d72c521ca3a4eeb2c29ac523f6fdf72667 (patch) | |
| tree | 40b7ff023ad2899dfe1d8e96cb1620ad0804c8c7 /m4 | |
| parent | 9197df76b46ff6fbe1f7a522961730ffc55a860d (diff) | |
| download | openvswitch-f613a0d72c521ca3a4eeb2c29ac523f6fdf72667.tar.gz | |
datapath: Always use generic stats for devices (vports)
Currently ovs is using device stats for Linux devices and count them
itself in other situations. This leads to overlap with hardware stats,
inconsistencies, etc. It's much better to just always count the packets
flowing through the switch and let userspace do any merging that it wants.
Following patch removes vport->get_stats() interface. vport-stat is changed
to use new `struct ovs_vport_stat` rather than rtnl_link_stats64.
Definitions of rtnl_link_stats64 is removed from OVS. dipf_port->stat is also
removed as aggregate stats are only available at netdev layer.
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
Diffstat (limited to 'm4')
| -rw-r--r-- | m4/openvswitch.m4 | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index 7aaf67a20..c59d5d4c1 100644 --- a/m4/openvswitch.m4 +++ b/m4/openvswitch.m4 @@ -46,25 +46,6 @@ AC_DEFUN([OVS_CHECK_NDEBUG], [ndebug=false]) AM_CONDITIONAL([NDEBUG], [test x$ndebug = xtrue])]) -dnl Checks for struct rtnl_link_stats64. -dnl -dnl (OVS checks for this structure in both kernel and userspace headers. This -dnl is not redundant, because the kernel and userspace builds have completely -dnl different include paths. It is possible for the kernel to have this -dnl structure but not userspace, and vice versa.) -AC_DEFUN([OVS_CHECK_RTNL_LINK_STATS64], - [AC_REQUIRE([OVS_CHECK_NETLINK]) - if test $HAVE_NETLINK = yes; then - AC_CHECK_MEMBER( - [struct rtnl_link_stats64.tx_packets], - [AC_DEFINE([HAVE_RTNL_LINK_STATS64], [1], - [Define to 1 if <linux/if_link.h> defines - struct rtnl_link_stats64.])], - [], [#include <sys/socket.h> /* Provides sa_family_t. */ -#include <linux/if_link.h> -]) - fi]) - dnl Checks for Netlink support. AC_DEFUN([OVS_CHECK_NETLINK], [AC_CHECK_HEADER([linux/netlink.h], |