End node request span when result event is sent

The node request span needs to be ended whenever we add a result event
to the pipeline. Before we only did that when iterating over the node
requests after we've won the nodepool election.

Change-Id: I0276d5498b243522540657352a733d663ae71918

1 files changed, 4 insertions, 4 deletions

diff --git a/zuul/nodepool.py b/zuul/nodepool.py
index 1118fe0c2..6a6afce58 100644
--- a/zuul/nodepool.py
+++ b/zuul/nodepool.py
@@ -84,6 +84,10 @@ class Nodepool(object):
             del self.election
 
     def _sendNodesProvisionedEvent(self, request):
+        tracing.endSavedSpan(request.span_info, attributes={
+            "request_id": request.id,
+            "state": request.state,
+        })
         tenant_name = request.tenant_name
         pipeline_name = request.pipeline_name
         event = model.NodesProvisionedEvent(request.id, request.build_set_uuid)
@@ -101,10 +105,6 @@ class Nodepool(object):
                     continue
                 if (request.state in {model.STATE_FULFILLED,
                                       model.STATE_FAILED}):
-                    tracing.endSavedSpan(request.span_info, attributes={
-                        "request_id": request.id,
-                        "state": request.state,
-                    })
                     self._sendNodesProvisionedEvent(request)
             # Now resume normal event processing.
             self.stop_watcher_event.wait()