summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "volume: Add 'volume qos set --no-property' option"HEADmasterZuul2023-05-179-25/+131
|\
| * volume: Add 'volume qos set --no-property' optionStephen Finucane2023-05-179-25/+131
| | | | | | | | | | | | | | | | | | Supporting "--no-property" option will apply user a convenient way to clean all properties of volume qos in a short command. The patch adds "--no-property" option in "volume qos set" command and update related test cases and docs. Change-Id: I1fb5b4f0a923bbf557a3af3f63809bde9e84ffd4
* | Merge "compute: Fix bug with start/stop server"Zuul2023-05-173-10/+50
|\ \
| * | compute: Fix bug with start/stop serverStephen Finucane2023-05-173-10/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A mistake was introduced during the conversion from novaclient to SDK in change I5ebfa6b2468d5f20b99ea0eab1aea9377be09b8c. Fix the issue and add functional tests to prevent it being reintroduced. Change-Id: I6b314eab31bcf452e88b8b6a239ac2e296497cb9 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Story: 2010750 Task: 48004
* | | Merge "Allow server rebuild --wait for SHUTOFF servers"Zuul2023-05-173-0/+105
|\ \ \
| * | | Allow server rebuild --wait for SHUTOFF serversPavlo Shchelokovskyy2023-05-173-0/+105
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently the command is waiting only for ACTIVE server status, but if the server was SHUTOFF before, it will be SHUTOFF after rebuild as well, so the command is stuck in waiting forever. Additionally, we now also pre-validate the server status on client side, and raise an error if the server to be rebuilt is not in ACTIVE, ERROR or SHUTOFF state. Change-Id: If90a4bbba9a7ecd972f8b594c52fee4f75a0ae5e Co-Authored-By: Oleksiy Molchanov <omolchanov@mirantis.com> Story: 2010751 Task: 48005
* | | Merge "Migrate 'volume revert' command to SDK"Zuul2023-05-173-24/+55
|\ \ \ | |_|/ |/| |
| * | Migrate 'volume revert' command to SDKwhoami-rajat2023-05-163-24/+55
| |/ | | | | | | | | | | | | This patch modifies the existing revert volume to snapshot call from cinderclient to SDK. Change-Id: Iaa9708ebae5d6ab3dfc73e4e2376af32ed098688
* | tests: Use SDK objects where expectedStephen Finucane2023-05-166-150/+133
| | | | | | | | | | | | | | | | | | We had not migrated a number of tests to use SDK objects instead of fake novaclient-like objects when migrating the commands themselves. Address this now. Change-Id: Ib0da07fd9d793968b111986bd36a6d4311469d4e Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | tests: Remove unnecessary nesting of compute resourcesStephen Finucane2023-05-1626-1282/+1132
| | | | | | | | | | Change-Id: I27326b8f2e0d84d3ef2c2fbdcb5c96a5ac1d79e4 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | tests: Reorder compute fakesStephen Finucane2023-05-161-71/+71
|/ | | | | | | This will make future changes slightly less complex. Change-Id: Ia69fd9d05796cce5ed48a8d12902cb54caec9779 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* pre-commit: Enable blackStephen Finucane2023-05-101-0/+5
| | | | | | | | Since our pep8 tox env now runs pre-commit, we can ensure that black styling will be maintained. Change-Id: Ifad1d67a83c4979b4f4de71de0124613d1133560 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Ignore black changesStephen Finucane2023-05-101-0/+12
| | | | | | | | | | Add a .git-blame-ignore-revs file to ignore the black changes. File was generated with the following command: git log --pretty=format:"%H # %s" --no-merges --grep='Blacken' Change-Id: I4c5c06a8d194cce4d490dc2b01040c68853451c2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken everything elseStephen Finucane2023-05-1012-190/+209
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I356643d06b2cd408ccaedfe02b858aea55388949 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.apiStephen Finucane2023-05-1010-162/+113
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I1df5bc4c35f02147fe5ac5b4073f0e01e7d51c2f Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstack.commonStephen Finucane2023-05-1029-566/+777
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: Ifcb3c798666d74d596b8ecb3d6d507f782de7ba5 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.imageStephen Finucane2023-05-1012-664/+623
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I6420ec6fd550903b03083b9b1f8391511913c86f Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.objectStephen Finucane2023-05-1011-281/+300
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I6658e76d7d1f93149f24fcab28d593195b37779f Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.identityStephen Finucane2023-05-10100-4011/+4901
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I2eeade1ce6653be8e9179ecc40105182c5ff5f16 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.networkStephen Finucane2023-05-10100-7636/+10507
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I8048746dbc2ef0cb582f68934734db4c1153d779 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.volumeStephen Finucane2023-05-1084-4438/+5339
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: Ic318617c67ab7ce6527f9016b759a1d4b0b80802 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Blacken openstackclient.computeStephen Finucane2023-05-1043-4154/+4902
| | | | | | | | | | Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: I9af45c062d179ab3dc2a5e969e1c467932753a2b Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Use pre-commit for 'pep8' tox target, bump versionsStephen Finucane2023-05-103-33/+12
| | | | | | | | | | | | | | We want to bump the versions of hacking, but doing so requires changes in two places: '.pre-commit-config.yaml' and 'tox.ini'. This is silly: we can simply use tox to handle pre-commit and leave all other dependencies to pre-commit. Do this, migrating bandit to pre-commit and bumping the other dependencies in the process. We remove the 'fast8' target and tool, since pre-commit is plenty fast here. Change-Id: Ifdc582ecc3b4479ea9ed9abcb16577c6e8b2f5c1 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Address pre-commit issuesStephen Finucane2023-05-108-53/+52
| | | | | | | | | We'd like to use pre-commit as our 'pep8' target. Before we do that, we need to address some issues that have crept in over the time since pre-commit was first added. Change-Id: I3bb383a00a44007eaa241e037e38aea16bd517b2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Merge "compute: Generate SSH keypairs ourselves"Zuul2023-05-046-63/+117
|\
| * compute: Generate SSH keypairs ourselvesStephen Finucane2023-05-026-63/+117
| | | | | | | | | | | | | | | | | | | | Starting with the 2.92 microversion, nova will no longer generate SSH keys. Avoid breaking users by generating keypairs ourselves using the cryptography library, which was already an indirect dependency through openstacksdk. Change-Id: I3ad2732f70854ab72da0947f00847351dda23944 Implements: blueprint keypair-generation-removal
* | Merge "Silence warnings from openstacksdk"Zuul2023-05-031-0/+5
|\ \ | |/ |/|
| * Silence warnings from openstacksdkStephen Finucane2023-04-111-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OSC has historically relied on project-specific clients like novaclient for library bindings. These did not support auto-negotiation of versions. Instead, users were advised to set the requested microversion to e.g. '2.latest' to opt into the latest API version supported by the client. We're slowly migrating everything to SDK which *does* support auto-negotiation (well, of sorts). This makes versions like '2.latest' unecessary and SDK correctly warns the user about this. You have a configured API_VERSION with 'latest' in it. In the context of openstacksdk this doesn't make any sense. Unfortunately, we have not yet migrated all commands to SDK, meaning we have a mix of SDK and legacy client-based commands. So long as there are any command using the legacy client, we can't insist on users removing this configuration. This makes the warning both annoying and something the user can't do anything about. We also don't want to remove the warning from SDK so instead we opt to filter it out, along with all other warnings from openstacksdk (which similarly a user can't do anything about). Change-Id: If8a7cf9bc876f84864d66f5aed5f2f61c5d0696a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | Merge "Migrate 'server event *' commands to SDK"Zuul2023-04-215-129/+234
|\ \
| * | Migrate 'server event *' commands to SDKHuda Irshad2023-04-205-129/+234
| | | | | | | | | | | | | | | | | | | | | | | | | | | This one is tricky since the ServerAction resources includes a nested ServerActionEvent resource which requires a custom formatter in order for things to render as expected. Change-Id: I3d24851303222af9efcee8d7e1565278b1018efd Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
* | | Fix pep issue in the network service providerArtem Goncharov2023-04-201-10/+16
|/ / | | | | | | | | | | | | | | pep gods started complaining (correctfully) about spacing in the old command. Apply `black -l 79` on the file to make it looking nice and passing checks. Change-Id: I716f6a1496fc552b32809c7eb744283f3a3cd5a4
* | Adding ``image import`` commandMridula Joshi2023-04-123-5/+6
|/ | | | Change-Id: I7254d30431894879c8bd20e2263d83b12c99d5c8
* compute: Migrate 'reboot server' to SDKStephen Finucane2023-04-043-14/+133
| | | | | Change-Id: Ibad4078f680d3b2615b9ca6f6c72c4fd28030b55 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Merge ""hypervisor list --matching" showed the wrong result"Zuul2023-04-042-12/+16
|\
| * "hypervisor list --matching" showed the wrong resultdevMuscle2023-03-262-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, using the "--matching" option shows empty results. Previously, the "--matching" option called the "find_hypervisor method", so we used to call the "hypervisor method" like any other "--limit, --marker" options. Depending on the nova api version, the api that is basically called is as follows 2.53 >= : /os-hypervisors/detail?hypervisor_hostname_pattern=$HOSTNAME 2.53 < : /os-hypervisors/{pattern}/search Hypervisor Type and Host IP are not returned when using microversion 2.52 or lower Co-authored-by: Jipyo Hong <hongsbien@naver.com> Co-authored-by: Jieon Lee <dlwldjs7544@naver.com> Co-authored-by: YoonSoo LIM <msdbtjd123@naver.com> story: 2010670 task: 47726 Change-Id: I7b47acf48def7d4c5f4b74e4dba1c23d8ac7abf2
* | Merge "Add an updated tips job running on py310"Zuul2023-04-041-0/+22
|\ \
| * | Add an updated tips job running on py310Dr. Jens Harbott2023-03-311-0/+22
| | | | | | | | | | | | Change-Id: Iadc32b4e8ea10561784208cdc8bf05ff3b3ca59d
* | | Merge "Remove unused helpers for legacy novaclient"Zuul2023-04-031-20/+0
|\ \ \
| * | | Remove unused helpers for legacy novaclientStephen Finucane2022-12-191-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | These are no longer used. Change-Id: I9514e98a5549130c12f3b785e90debf3437e6933 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "Switch server shelve, unshelve to SDK"Zuul2023-04-033-278/+245
|\ \ \ \ | |/ / /
| * | | Switch server shelve, unshelve to SDKStephen Finucane2022-12-193-278/+245
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This one is a little more complicated because we support waiting. Change-Id: I5bd65b44c23bfee1e0144dbd060563ecc3cfb942 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "compute: Switch server restore to SDK"Zuul2023-04-033-13/+13
|\ \ \ \ | |/ / / | | / / | |/ / |/| |
| * | compute: Switch server restore to SDKStephen Finucane2022-12-193-13/+13
| | | | | | | | | | | | | | | | | | Change-Id: I8df9711b736991c01136988aa06c8540d640f52f Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/868108
* | | Merge "Remove unnecessary 'self.methods'"Zuul2023-03-301-24/+4
|\ \ \ | |/ /
| * | Remove unnecessary 'self.methods'Stephen Finucane2022-12-191-24/+4
| | | | | | | | | | | | | | | | | | | | | This was used by 'run_method_with_servers', not the SDK-equivalent. Change-Id: Ia3333a95e406f430beb4f2cfb887e81ab7b72cfe Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "Switch server start, server stop to SDK"Zuul2023-03-303-45/+54
|\ \ \ | |/ /
| * | Switch server start, server stop to SDKThrivikram Mudunuri2022-12-193-45/+54
| | | | | | | | | | | | | | | | | | Switch the server start and server stop commands from novaclient to SDK. Change-Id: I5ebfa6b2468d5f20b99ea0eab1aea9377be09b8c
* | | Merge "Switch server lock, unlock to sdk"Zuul2023-03-303-87/+99
|\ \ \ | |/ /
| * | Switch server lock, unlock to sdksuneethravi2022-12-193-87/+99
| | | | | | | | | | | | | | | | | | | | | Switch server lock commands from novaclient to SDK. Change-Id: I042db99c9d7a0d8d207f8cdf69d786bd4fe904e7 Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/867890
* | | Merge "Show Network QoS rules one per line"Zuul2023-03-292-2/+13
|\ \ \
View Lorry Controller Status