diff options
author | Stephen Finucane <sfinucan@redhat.com> | 2022-12-14 11:37:00 +0000 |
---|---|---|
committer | Stephen Finucane <stephenfin@redhat.com> | 2023-05-16 16:55:08 +0000 |
commit | 31ae635ffe0a2c37ab2bda394d2b072d7e5acff9 (patch) | |
tree | 91dd1699ef0b44335d28b12efc4efb04efe84d55 /openstackclient/tests/unit/compute/v2/test_server_image.py | |
parent | 19be070204ae52e342ba2c18f6cc519d617230ab (diff) | |
download | python-openstackclient-31ae635ffe0a2c37ab2bda394d2b072d7e5acff9.tar.gz |
tests: Use SDK objects where expected
We had not migrated a number of tests to use SDK objects instead of fake
novaclient-like objects when migrating the commands themselves. Address
this now.
Change-Id: Ib0da07fd9d793968b111986bd36a6d4311469d4e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Diffstat (limited to 'openstackclient/tests/unit/compute/v2/test_server_image.py')
-rw-r--r-- | openstackclient/tests/unit/compute/v2/test_server_image.py | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/openstackclient/tests/unit/compute/v2/test_server_image.py b/openstackclient/tests/unit/compute/v2/test_server_image.py index f231be4c..cc1ee90a 100644 --- a/openstackclient/tests/unit/compute/v2/test_server_image.py +++ b/openstackclient/tests/unit/compute/v2/test_server_image.py @@ -23,7 +23,7 @@ from openstackclient.tests.unit.image.v2 import fakes as image_fakes class TestServerImage(compute_fakes.TestComputev2): def setUp(self): - super(TestServerImage, self).setUp() + super().setUp() # Get a shortcut to the compute client ServerManager Mock self.app.client_manager.sdk_connection = mock.Mock() @@ -37,13 +37,9 @@ class TestServerImage(compute_fakes.TestComputev2): # Set object attributes to be tested. Could be overwritten in subclass. self.attrs = {} - # Set object methods to be tested. Could be overwritten in subclass. - self.methods = {} - def setup_servers_mock(self, count): servers = compute_fakes.create_sdk_servers( attrs=self.attrs, - methods=self.methods, count=count, ) @@ -82,15 +78,11 @@ class TestServerImageCreate(TestServerImage): return datalist def setUp(self): - super(TestServerImageCreate, self).setUp() + super().setUp() # Get the command object to test self.cmd = server_image.CreateServerImage(self.app, None) - self.methods = { - 'create_image': None, - } - def setup_images_mock(self, count, servers=None): if servers: images = image_fakes.create_images( |