diff options
| author | Zuul <zuul@review.openstack.org> | 2017-12-13 02:57:49 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2017-12-13 02:57:49 +0000 |
| commit | 8c5f7555698491c3a0b44fe6c3fee50d0189f2d6 (patch) | |
| tree | a6e5270b96a25ca448adaea7f2349e3b6886b26a | |
| parent | 21b656ca4aa995530be474a8b9761b89f2ef93dd (diff) | |
| parent | 116526275d0953fda93c7ff8eacd8631c5af68d5 (diff) | |
| download | python-openstackclient-3.13.0.tar.gz | |
Merge "Send 'changes-since' instead of 'changes_since' query parameter"3.13.0
| -rw-r--r-- | openstackclient/compute/v2/server.py | 13 | ||||
| -rw-r--r-- | openstackclient/tests/unit/compute/v2/test_server.py | 4 | ||||
| -rw-r--r-- | releasenotes/notes/bug-1732216-b41bfedebff911e1.yaml | 5 |
3 files changed, 14 insertions, 8 deletions
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index 78c56788..c08f5cae 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -1056,17 +1056,18 @@ class ListServer(command.Lister): 'all_tenants': parsed_args.all_projects, 'user_id': user_id, 'deleted': parsed_args.deleted, - 'changes_since': parsed_args.changes_since, + 'changes-since': parsed_args.changes_since, } LOG.debug('search options: %s', search_opts) - if search_opts['changes_since']: + if search_opts['changes-since']: try: - timeutils.parse_isotime(search_opts['changes_since']) + timeutils.parse_isotime(search_opts['changes-since']) except ValueError: - raise exceptions.CommandError(_('Invalid changes-since value:' - ' %s') % search_opts['changes' - '_since']) + raise exceptions.CommandError( + _('Invalid changes-since value: %s') % + search_opts['changes-since'] + ) if parsed_args.long: columns = ( diff --git a/openstackclient/tests/unit/compute/v2/test_server.py b/openstackclient/tests/unit/compute/v2/test_server.py index 20b9532a..c4e125ba 100644 --- a/openstackclient/tests/unit/compute/v2/test_server.py +++ b/openstackclient/tests/unit/compute/v2/test_server.py @@ -1584,7 +1584,7 @@ class TestServerList(TestServer): 'all_tenants': False, 'user_id': None, 'deleted': False, - 'changes_since': None, + 'changes-since': None, } # Default params of the core function of the command in the case of no @@ -1791,7 +1791,7 @@ class TestServerList(TestServer): parsed_args = self.check_parser(self.cmd, arglist, verifylist) columns, data = self.cmd.take_action(parsed_args) - self.search_opts['changes_since'] = '2016-03-04T06:27:59Z' + self.search_opts['changes-since'] = '2016-03-04T06:27:59Z' self.search_opts['deleted'] = True self.servers_mock.list.assert_called_with(**self.kwargs) diff --git a/releasenotes/notes/bug-1732216-b41bfedebff911e1.yaml b/releasenotes/notes/bug-1732216-b41bfedebff911e1.yaml new file mode 100644 index 00000000..d792f25a --- /dev/null +++ b/releasenotes/notes/bug-1732216-b41bfedebff911e1.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fix the operation of the ``--changes-since`` option to the ``server list`` command. + [Bug `1732216 <https://bugs.launchpad.net/python-openstackclient/+bug/1732216>`_] |