summaryrefslogtreecommitdiff
path: root/HACKING.rst
diff options
context:
space:
mode:
authorTobias Diaz <tobias.deb@gmail.com>2016-08-23 17:13:24 +0200
committerSteve Martinelli <s.martinelli@gmail.com>2017-01-11 05:10:06 +0000
commita0c67b860b3c5ff6f5fbb0e406dcbc3fd7aa9f88 (patch)
tree76d4be9a9c006fc9e9c0ac42da1cc775e71a55fe /HACKING.rst
parenta71593b19e52bb4469432d682bacecfb80843d73 (diff)
downloadpython-keystoneclient-2.3.2.tar.gz
Only log application/json content typemitaka-eol2.3.2stable/mitaka
This is a combination of 2 commits. The first commit's message is: Prevent MemoryError when logging response bodies Response bodies are loaded into memory prior to being logged. Loading huge response bodies may result in a MemoryError. This patch proposes that only JSON and TEXT responses be logged, i.e when the Content-Type header is application/json or application/text. Responses that do not include or have a different Content-Type header will have their body omitted. This is a sort of backport of the fix for keystoneauth sessions, see I93b6fff73368c4f58bdebf8566c4948b50980cee Co-Authored-By: Samuel de Medeiros Queiroz <samueldmq@gmail.com> Closes-bug: 1616105 Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14 (cherry-picked from: 3e56e0d7e5e1a76d806a3bc1f6d5ef9070f95771) Only log application/json in session to start When whitelisting content types to debug print from session we chose application/json and application/text. application/text is not a real mime type, text is typically text/plain. Rather than guess at mime types only print application/json to start with, but make it easy for additional types to be added later. Adapted from keystoneauth: Ica5fee076cdab8b1d5167161d28af7313fad9477 Related-Bug: 1616105 Change-Id: Ieaa8fb3ea8d25e09b89498f23b70b18c0f6153f1 (cherry-picked from: 51d16fa344829aadf454faf5e0c4535a8f96a7c8)
Diffstat (limited to 'HACKING.rst')
0 files changed, 0 insertions, 0 deletions