summaryrefslogtreecommitdiff
path: root/glanceclient
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2015-04-09 13:10:10 +0000
committerGerrit Code Review <review@openstack.org>2015-04-09 13:10:10 +0000
commit287bf622615e1dd8fde1171945bf75cfd50930f9 (patch)
tree4339c1947af5c15f6878a2e32112eebd2fa3c851 /glanceclient
parent93569c61de8e70692e88eba05857a8683e0e94dd (diff)
parent2c08b40bf08a7dfbe8aa3a7b9a2648010b51330b (diff)
downloadpython-glanceclient-287bf622615e1dd8fde1171945bf75cfd50930f9.tar.gz
Merge "Validate tag name when filtering for images"
Diffstat (limited to 'glanceclient')
-rw-r--r--glanceclient/v2/images.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/glanceclient/v2/images.py b/glanceclient/v2/images.py
index 1719325..01ce40b 100644
--- a/glanceclient/v2/images.py
+++ b/glanceclient/v2/images.py
@@ -132,8 +132,10 @@ class Controller(object):
tags_url_params = []
for tag in tags:
- if isinstance(tag, six.string_types):
- tags_url_params.append({'tag': encodeutils.safe_encode(tag)})
+ if not isinstance(tag, six.string_types):
+ raise exc.HTTPBadRequest("Invalid tag value %s" % tag)
+
+ tags_url_params.append({'tag': encodeutils.safe_encode(tag)})
for param, value in six.iteritems(filters):
if isinstance(value, six.string_types):