summaryrefslogtreecommitdiff
path: root/ceilometerclient/v2
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2015-04-16 18:24:13 +0000
committerGerrit Code Review <review@openstack.org>2015-04-16 18:24:13 +0000
commit8bc06eb694933c91fb0a413332dddb5d0b5edef5 (patch)
tree394be0466d65863bf11f2829d2127e4eedd02007 /ceilometerclient/v2
parent62e3573fceb6c6120d8c14a761927c2979d9c132 (diff)
parent16880fcaebb9a950c7ad7ca17ff87b000645f2ac (diff)
downloadpython-ceilometerclient-8bc06eb694933c91fb0a413332dddb5d0b5edef5.tar.gz
Merge "print user friendly error message for alarm update time constraints"
Diffstat (limited to 'ceilometerclient/v2')
-rw-r--r--ceilometerclient/v2/alarms.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/ceilometerclient/v2/alarms.py b/ceilometerclient/v2/alarms.py
index 18cdbb0..a54183a 100644
--- a/ceilometerclient/v2/alarms.py
+++ b/ceilometerclient/v2/alarms.py
@@ -135,14 +135,15 @@ class AlarmManager(base.Manager):
updated_tcs = [dict(tc) for tc in existing_tcs]
for tc in new_tcs:
for i, old_tc in enumerate(updated_tcs):
- if old_tc['name'] == tc['name']: # if names match, merge
+ # if names match, merge
+ if old_tc['name'] == tc.get('name'):
utils.merge_nested_dict(updated_tcs[i], tc)
break
else:
updated_tcs.append(tc)
tcs_to_remove = kwargs.get('remove_time_constraints', [])
for tc in updated_tcs:
- if tc['name'] in tcs_to_remove:
+ if tc.get('name') in tcs_to_remove:
updated_tcs.remove(tc)
return updated_tcs