1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
|
# (c) Copyright 2015 - 2019 StorPool
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from os_brick import initiator
from unittest import mock
from nova.tests.unit.virt.libvirt.volume import test_volume
from nova.virt.libvirt.volume import storpool as vol_sp
test_attached = {}
class MockStorPoolExc(Exception):
def __init__(self, msg):
super(MockStorPoolExc, self).__init__(msg)
def storpoolVolumeName(vid):
return 'os--volume--{id}'.format(id=vid)
def storpoolVolumePath(vid):
return '/dev/storpool/' + storpoolVolumeName(vid)
class MockStorPoolConnector(object):
def __init__(self, inst):
self.inst = inst
def connect_volume(self, connection_info):
self.inst.assertIn('client_id', connection_info)
self.inst.assertIn('volume', connection_info)
self.inst.assertIn('access_mode', connection_info)
v = connection_info['volume']
if v in test_attached:
raise MockStorPoolExc('Duplicate volume attachment')
test_attached[v] = {
'info': connection_info,
'path': storpoolVolumePath(v)
}
return {'type': 'block', 'path': test_attached[v]['path']}
def disconnect_volume(self, connection_info, device_info, **kwargs):
self.inst.assertIn('client_id', connection_info)
self.inst.assertIn('volume', connection_info)
self.inst.assertIn('force', kwargs)
self.inst.assertEqual(self.inst.force, kwargs.get('force'))
v = connection_info['volume']
if v not in test_attached:
raise MockStorPoolExc('Unknown volume to detach')
self.inst.assertIs(test_attached[v]['info'], connection_info)
del test_attached[v]
def extend_volume(self, connection_info):
self.inst.assertIn('volume', connection_info)
self.inst.assertIn('real_size', connection_info)
v = connection_info['volume']
if v not in test_attached:
raise MockStorPoolExc('Extending a volume that is not attached')
return connection_info['real_size']
class MockStorPoolInitiator(object):
def __init__(self, inst):
self.inst = inst
def factory(self, proto, helper):
self.inst.assertEqual(proto, initiator.STORPOOL)
self.inst.assertIsNotNone(helper)
return MockStorPoolConnector(self.inst)
class LibvirtStorPoolVolumeDriverTestCase(
test_volume.LibvirtVolumeBaseTestCase):
def setUp(self):
super().setUp()
# This is for testing the force flag of disconnect_volume()
self.force = False
def mock_storpool(f):
def _config_inner_inner1(inst, *args, **kwargs):
@mock.patch(
'os_brick.initiator.connector.InitiatorConnector',
new=MockStorPoolInitiator(inst))
def _config_inner_inner2():
return f(inst, *args, **kwargs)
return _config_inner_inner2()
return _config_inner_inner1
def assertStorpoolAttached(self, names):
self.assertListEqual(sorted(test_attached.keys()), sorted(names))
def conn_info(self, volume_id):
return {
'data': {
'access_mode': 'rw',
'client_id': '1',
'volume': volume_id,
'real_size': 42 if volume_id == '1' else 616
}, 'serial': volume_id
}
@mock_storpool
def test_storpool_config(self):
libvirt_driver = vol_sp.LibvirtStorPoolVolumeDriver(self.fake_host)
ci = self.conn_info('1')
ci['data']['device_path'] = '/dev/storpool/something'
c = libvirt_driver.get_config(ci, self.disk_info)
self.assertEqual('block', c.source_type)
self.assertEqual('/dev/storpool/something', c.source_path)
self.assertEqual('native', c.driver_io)
@mock_storpool
def test_storpool_attach_detach_extend(self):
libvirt_driver = vol_sp.LibvirtStorPoolVolumeDriver(self.fake_host)
self.assertDictEqual({}, test_attached)
ci_1 = self.conn_info('1')
ci_2 = self.conn_info('2')
rs_1 = ci_1['data']['real_size']
rs_2 = ci_2['data']['real_size']
self.assertRaises(MockStorPoolExc,
libvirt_driver.extend_volume,
ci_1, mock.sentinel.instance, rs_1)
self.assertRaises(MockStorPoolExc,
libvirt_driver.extend_volume,
ci_2, mock.sentinel.instance, rs_2)
libvirt_driver.connect_volume(ci_1, mock.sentinel.instance)
self.assertStorpoolAttached(('1',))
ns_1 = libvirt_driver.extend_volume(ci_1, mock.sentinel.instance, rs_1)
self.assertEqual(ci_1['data']['real_size'], ns_1)
self.assertRaises(MockStorPoolExc,
libvirt_driver.extend_volume,
ci_2, mock.sentinel.instance, rs_2)
libvirt_driver.connect_volume(ci_2, mock.sentinel.instance)
self.assertStorpoolAttached(('1', '2'))
ns_1 = libvirt_driver.extend_volume(ci_1, mock.sentinel.instance, rs_1)
self.assertEqual(ci_1['data']['real_size'], ns_1)
ns_2 = libvirt_driver.extend_volume(ci_2, mock.sentinel.instance, rs_2)
self.assertEqual(ci_2['data']['real_size'], ns_2)
self.assertRaises(MockStorPoolExc,
libvirt_driver.connect_volume,
ci_2, mock.sentinel.instance)
libvirt_driver.disconnect_volume(ci_1, mock.sentinel.instance)
self.assertStorpoolAttached(('2',))
self.assertRaises(MockStorPoolExc,
libvirt_driver.disconnect_volume,
ci_1, mock.sentinel.instance)
self.assertRaises(MockStorPoolExc,
libvirt_driver.extend_volume,
ci_1, mock.sentinel.instance, rs_1)
libvirt_driver.disconnect_volume(ci_2, mock.sentinel.instance)
self.assertDictEqual({}, test_attached)
# Connect the volume again so we can detach it again
libvirt_driver.connect_volume(ci_2, mock.sentinel.instance)
# Verify force=True
self.force = True
libvirt_driver.disconnect_volume(
ci_2, mock.sentinel.instance, force=True)
|
