diff options
| author | Devananda van der Veen <devananda.vdv@gmail.com> | 2013-06-22 12:05:46 -0700 |
|---|---|---|
| committer | Devananda van der Veen <devananda.vdv@gmail.com> | 2013-07-02 03:11:24 -0700 |
| commit | f2b4419b9f5e01038adaae1d0ce856bd0ac9af5b (patch) | |
| tree | a61f8853b586565e0af61212e8508e44a47ccdca /HACKING.rst | |
| parent | 88531ada3934775398c555bfe713d4f36144ac38 (diff) | |
| download | nova-f2b4419b9f5e01038adaae1d0ce856bd0ac9af5b.tar.gz | |
Add HACKING check for db session param
Add a HACKING check to enforce that public db/api and db/sqlalchemy/api
methods to not accept a 'session' parameter.
This check is initially disabled, since it is failing ~24 times right
now, but will be enabled once bp/db-session-cleanup is complete.
Change-Id: Ib89eea58555032dd142d4e21e62d66e2726f0d06
Diffstat (limited to 'HACKING.rst')
| -rw-r--r-- | HACKING.rst | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/HACKING.rst b/HACKING.rst index 8ec767b7e9..dcf71e4537 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -9,7 +9,8 @@ Nova Specific Commandments --------------------------- - ``nova.db`` imports are not allowed in ``nova/virt/*`` - +- [N309] no db session in public API methods (disabled) + This enforces a guideline defined in ``nova.openstack.common.db.sqlalchemy.session`` Creating Unit Tests ------------------- |