summaryrefslogtreecommitdiff
path: root/HACKING.rst
diff options
context:
space:
mode:
authorBrian Waldon <bcwaldon@gmail.com>2012-06-28 10:28:29 -0700
committerBrian Waldon <bcwaldon@gmail.com>2012-07-02 19:36:48 -0700
commit211328fb50cc35af2dd08e514deb111fd0a036d2 (patch)
tree864cac64eccc0f869e31d2c43ed74b9dfcdb3731 /HACKING.rst
parentd9ca0ace90b855841f434e2ddde397c7a10df36d (diff)
downloadnova-211328fb50cc35af2dd08e514deb111fd0a036d2.tar.gz
Expand HACKING with commit message guidelines
Add a 'Commit Messages' section to HACKING describing how a commit message should be formed. Change-Id: I29b69022dfbdac09523eaa5cef3fc1a4550a7c5f
Diffstat (limited to 'HACKING.rst')
-rw-r--r--HACKING.rst21
1 files changed, 21 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst
index c85f5f3055..2ebc58927b 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -213,3 +213,24 @@ with the help of openstack-common's update.py script. See:
The copy of the code should never be directly modified here. Please
always update openstack-common first and then run the script to copy
the changes across.
+
+Commit Messages
+---------------
+Using a common format for commit messages will help keep our git history
+readable. Follow these guidelines:
+
+ First, provide a brief summary (limited to 50 chars).
+
+ The first line of the commit message should provide an accurate
+ description of the change, not just a reference to a bug or
+ blueprint. It must be followed by a single blank line.
+
+ Following your brief summary, provide a more detailed description of
+ the patch, manually wrapping the text at 72 characters. This
+ description should provide enough detail that one does not have to
+ refer to external resources to determine its high-level functionality.
+
+ Once you use 'git review', two lines will be appended to the commit
+ message: a blank line followed by a 'Change-Id'. This is important
+ to correlate this commit with a specific review in Gerrit, and it
+ should not be modified.