summaryrefslogtreecommitdiff
path: root/HACKING.rst
diff options
context:
space:
mode:
authorTatiana Ovchinnikova <t.v.ovtchinnikova@gmail.com>2014-09-25 16:13:02 +0400
committerTatiana Ovchinnikova <t.v.ovtchinnikova@gmail.com>2014-09-29 13:58:39 +0400
commitb47f226647243464b1af4a182390f1301d7e804a (patch)
treef22d299d68d327ec11a01d6d822783679c15c04f /HACKING.rst
parentcdad4940e7ecfe4a36416385e4c417880e6de54d (diff)
downloadhorizon-b47f226647243464b1af4a182390f1301d7e804a.tar.gz
Remove #noqa from django.conf.urls.include
We have one more import with #noqa: django.conf.urls.include that is also commonly used in urls.py module and could be included to the list of import exceptions. This change has also revealed one unused import. Change-Id: I47cc582340625aac87ab0242b147e11ef1d9b38e
Diffstat (limited to 'HACKING.rst')
-rw-r--r--HACKING.rst27
1 files changed, 3 insertions, 24 deletions
diff --git a/HACKING.rst b/HACKING.rst
index 96dbc31fc..7ac9b75bf 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -3,30 +3,9 @@ Horizon Style Commandments
- Step 1: Read the OpenStack Style Commandments
http://docs.openstack.org/developer/hacking/
-- Step 2: The following names can be imported directly, without triggering the
- "H302: import only modules" flake8 warning::
-
- collections.defaultdict,
- django.conf.settings,
- django.conf.urls.patterns,
- django.conf.urls.url,
- django.core.urlresolvers.reverse,
- django.core.urlresolvers.reverse_lazy,
- django.template.loader.render_to_string,
- django.test.utils.override_settings,
- django.utils.datastructures.SortedDict,
- django.utils.encoding.force_text,
- django.utils.html.conditional_escape,
- django.utils.html.escape,
- django.utils.http.urlencode,
- django.utils.safestring.mark_safe,
- django.utils.translation.npgettext_lazy,
- django.utils.translation.pgettext_lazy,
- django.utils.translation.ugettext_lazy,
- django.utils.translation.ungettext_lazy,
- operator.attrgetter,
- StringIO.StringIO
-
+- Step 2: Read [hacking] section in tox.ini to find the list of names which
+ can be imported directly without triggering the "H302: import only modules"
+ flake8 warning
- Step 3: Read on
Horizon Specific Commandments