tox respects upper-constraints.txt

This will force pip install to use the upper-constraints.txt specified
version of pip modules. When you don't do this, you are out on the
bleeding edge and become unstable everytime some python library in the
wide world changes in a way that you don't expect.

There are a few 'post' jobs as Andreas has mentioned on this review,
that have the install_command overridden (until that will be supported
in upstream infra).

This change has been inspired by
Ie1133e4c020106e8098685ba9125f84b356d8e0c , notes from jaegerandi in the
openstack/glance's tox.ini file and Ihar's python-neutronclient's fix
I33302cdcab980a42c39dc9ec1e430add459615ff

Change-Id: I1f8be8184683c9a3671f750ebaa87c38163c9795
Closes-Bug: 1563038

1 files changed, 10 insertions, 1 deletions

diff --git a/tox.ini b/tox.ini
index 9659dad..91bffd6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -6,7 +6,7 @@ skipsdist = True
 [testenv]
 setenv = VIRTUAL_ENV={envdir}
 usedevelop = True
-install_command = pip install --allow-all-external --allow-insecure netaddr -U {opts} {packages}
+install_command = {toxinidir}/tools/tox_install.sh -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} --allow-all-external --allow-insecure netaddr -U {opts} {packages}
 deps = -r{toxinidir}/requirements.txt
        -r{toxinidir}/test-requirements.txt
        .[s3,vmware,swift,cinder]
@@ -16,6 +16,9 @@ commands = ostestr --slowest {posargs}
 commands = python setup.py build_sphinx
 
 [testenv:releasenotes]
+# NOTE(nikhil): this target does not use constraints because upstream infra
+# does not yet support it. Once that's fixed, we can drop the install_command.
+install_command = pip install --allow-all-external --allow-insecure netaddr -U {opts} {packages}
 commands = sphinx-build -a -E -W -d releasenotes/build/.doctrees -b html releasenotes/source releasenotes/build/html
 
 [testenv:pep8]
@@ -23,10 +26,16 @@ commands =
   flake8 {posargs}
 
 [testenv:cover]
+# NOTE(nikhil): this target does not use constraints because upstream infra
+# does not yet support it. Once that's fixed, we can drop the install_command.
+install_command = pip install --allow-all-external --allow-insecure netaddr -U {opts} {packages}
 setenv = VIRTUAL_ENV={envdir}
 commands = python setup.py testr --coverage --testr-args='^(?!.*test.*coverage).*$'
 
 [testenv:venv]
+# NOTE(nikhil): this target does not use constraints because upstream infra
+# does not yet support it. Once that's fixed, we can drop the install_command.
+install_command = pip install --allow-all-external --allow-insecure netaddr -U {opts} {packages}
 commands = {posargs}
 
 [testenv:functional]