1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
# Copyright 2020 Red Hat, Inc.
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import socket
from unittest import mock
import uuid
from cinderclient.v3 import client as cinderclient
import glance_store
from glance_store._drivers import cinder
from oslo_config import cfg
from oslo_log import log as logging
from oslo_utils import strutils
from glance.common import wsgi
from glance.tests import functional
LOG = logging.getLogger(__name__)
CONF = cfg.CONF
class TestLegacyUpdateCinderStore(functional.SynchronousAPIBase):
def setUp(self):
super(TestLegacyUpdateCinderStore, self).setUp()
self.vol_id = uuid.uuid4()
self.volume = mock.MagicMock(
id=self.vol_id,
status='available',
size=1,
multiattach=False,
encrypted=False,
delete=mock.MagicMock(),
update_all_metadata=mock.MagicMock(),
update_readonly_flag=mock.MagicMock())
self.volume.manager = mock.MagicMock(get=lambda id: self.volume)
self.cinder_store_mock = mock.MagicMock(
attachments=mock.MagicMock(),
client=mock.MagicMock(), volumes=mock.MagicMock(
get=lambda v_id: mock.MagicMock(volume_type='fast'),
create=lambda size_gb, name, metadata, volume_type:
self.volume))
fake_ip = '127.0.0.1'
self.fake_socket_return = [[0, 1, 2, 3, [fake_ip]]]
def setup_stores(self):
pass
def setup_single_store(self):
glance_store.register_opts(CONF)
self.config(show_multiple_locations=True)
self.config(show_image_direct_url=True)
self.config(default_store='cinder', group='glance_store')
self.config(stores=['http', 'swift', 'cinder'], group='glance_store')
self.config(cinder_volume_type='fast', group='glance_store')
self.config(cinder_store_user_name='fake_user', group='glance_store')
self.config(cinder_store_password='fake_pass', group='glance_store')
self.config(cinder_store_project_name='fake_project',
group='glance_store')
self.config(cinder_store_auth_address='http://auth_addr',
group='glance_store')
glance_store.create_stores(CONF)
def unset_single_store(self):
glance_store.register_opts(CONF)
self.config(show_multiple_locations=True)
self.config(show_image_direct_url=True)
self.config(stores=[], group='glance_store')
self.config(cinder_volume_type='', group='glance_store')
self.config(cinder_store_user_name='', group='glance_store')
self.config(cinder_store_password='', group='glance_store')
self.config(cinder_store_project_name='', group='glance_store')
self.config(cinder_store_auth_address='', group='glance_store')
glance_store.create_stores(CONF)
@mock.patch.object(cinderclient, 'Client')
def setup_multiple_stores(self, mock_client):
"""Configures multiple backend stores.
This configures the API with two cinder stores (store1 and
store2) as well as a os_glance_staging_store for
imports.
"""
self.config(show_multiple_locations=True)
self.config(show_image_direct_url=True)
self.config(enabled_backends={'store1': 'cinder', 'store2': 'cinder'})
glance_store.register_store_opts(CONF,
reserved_stores=wsgi.RESERVED_STORES)
self.config(default_backend='store1',
group='glance_store')
self.config(cinder_volume_type='fast', group='store1')
self.config(cinder_store_user_name='fake_user', group='store1')
self.config(cinder_store_password='fake_pass', group='store1')
self.config(cinder_store_project_name='fake_project', group='store1')
self.config(cinder_store_auth_address='http://auth_addr',
group='store1')
self.config(cinder_volume_type='reliable', group='store2')
self.config(cinder_store_user_name='fake_user', group='store2')
self.config(cinder_store_password='fake_pass', group='store2')
self.config(cinder_store_project_name='fake_project', group='store2')
self.config(cinder_store_auth_address='http://auth_addr',
group='store2')
self.config(filesystem_store_datadir=self._store_dir('staging'),
group='os_glance_staging_store')
glance_store.create_multi_stores(CONF,
reserved_stores=wsgi.RESERVED_STORES)
glance_store.verify_store()
def _import_direct(self, image_id, stores):
"""Do an import of image_id to the given stores."""
body = {'method': {'name': 'glance-direct'},
'stores': stores,
'all_stores': False}
return self.api_post(
'/v2/images/%s/import' % image_id,
json=body)
def _mock_wait_volume_status(self, volume, status_transition,
status_expected):
volume.status = status_expected
return volume
@mock.patch.object(cinderclient, 'Client')
@mock.patch.object(cinder.Store, 'temporary_chown')
@mock.patch.object(cinder, 'connector')
@mock.patch.object(cinder, 'open')
@mock.patch('glance_store._drivers.cinder.Store._wait_volume_status')
@mock.patch.object(strutils, 'mask_dict_password')
@mock.patch.object(socket, 'getaddrinfo')
def test_create_image(self, mock_host_addr, mock_mask_pass, mock_wait,
mock_open, mock_connector, mock_chown, mocked_cc):
# setup multiple cinder stores
self.setup_multiple_stores()
self.start_server()
mocked_cc.return_value = self.cinder_store_mock
mock_wait.side_effect = self._mock_wait_volume_status
mock_host_addr.return_value = self.fake_socket_return
# create an image
image_id = self._create_and_import(stores=['store1'])
image = self.api_get('/v2/images/%s' % image_id).json
# verify image is created with new location url
self.assertEqual('cinder://store1/%s' % self.vol_id,
image['locations'][0]['url'])
self.assertEqual('store1', image['locations'][0]['metadata']['store'])
# NOTE(whoami-rajat): These are internals called by glance_store, so
# we want to make sure they got hit, but not be too strict about how.
mocked_cc.assert_called()
mock_open.assert_called()
mock_chown.assert_called()
mock_connector.get_connector_properties.assert_called()
@mock.patch.object(cinderclient, 'Client')
@mock.patch.object(cinder.Store, 'temporary_chown')
@mock.patch.object(cinder, 'connector')
@mock.patch.object(cinder, 'open')
@mock.patch('glance_store._drivers.cinder.Store._wait_volume_status')
@mock.patch.object(strutils, 'mask_dict_password')
@mock.patch.object(socket, 'getaddrinfo')
def test_migrate_image_after_upgrade(self, mock_host_addr, mock_mask_pass,
mock_wait, mock_open, mock_connector,
mock_chown, mocked_cc):
"""Test to check if an image is successfully migrated when we
upgrade from a single cinder store to multiple cinder stores.
"""
# setup single cinder store
self.setup_single_store()
self.start_server()
mocked_cc.return_value = self.cinder_store_mock
mock_wait.side_effect = self._mock_wait_volume_status
mock_host_addr.return_value = self.fake_socket_return
# create image in single store
image_id = self._create_and_import(stores=['store1'])
image = self.api_get('/v2/images/%s' % image_id).json
# check the location url is in old format
self.assertEqual('cinder://%s' % self.vol_id,
image['locations'][0]['url'])
self.unset_single_store()
# setup multiple cinder stores
self.setup_multiple_stores()
cinder.keystone_sc = mock.MagicMock()
# get the image to run lazy loading
image = self.api_get('/v2/images/%s' % image_id).json
# verify the image is updated to new format
self.assertEqual('cinder://store1/%s' % self.vol_id,
image['locations'][0]['url'])
self.assertEqual('store1', image['locations'][0]['metadata']['store'])
image = self.api_get('/v2/images/%s' % image_id).json
# verify the image location url is consistent
self.assertEqual('cinder://store1/%s' % self.vol_id,
image['locations'][0]['url'])
# NOTE(whoami-rajat): These are internals called by glance_store, so
# we want to make sure they got hit, but not be too strict about how.
mocked_cc.assert_called()
mock_open.assert_called()
mock_chown.assert_called()
mock_connector.get_connector_properties.assert_called()
@mock.patch.object(cinderclient, 'Client')
@mock.patch.object(cinder.Store, 'temporary_chown')
@mock.patch.object(cinder, 'connector')
@mock.patch.object(cinder, 'open')
@mock.patch('glance_store._drivers.cinder.Store._wait_volume_status')
@mock.patch.object(strutils, 'mask_dict_password')
@mock.patch.object(socket, 'getaddrinfo')
def test_migrate_image_after_upgrade_not_owner(self, mock_host_addr,
mock_mask_pass,
mock_wait, mock_open,
mock_connector,
mock_chown, mocked_cc):
"""Test to check if an image is successfully migrated when we upgrade
from a single cinder store to multiple cinder stores, and that
GETs from non-owners in the meantime are not interrupted.
"""
# setup single cinder store
self.setup_single_store()
self.start_server()
mocked_cc.return_value = self.cinder_store_mock
mock_wait.side_effect = self._mock_wait_volume_status
mock_host_addr.return_value = self.fake_socket_return
# create image in single store, owned by someone else
image_id = self._create_and_import(stores=['store1'],
extra={'visibility': 'public',
'owner': 'someoneelse'})
image = self.api_get('/v2/images/%s' % image_id).json
# check the location url is in old format
self.assertEqual('cinder://%s' % self.vol_id,
image['locations'][0]['url'])
self.unset_single_store()
# setup multiple cinder stores
self.setup_multiple_stores()
cinder.keystone_sc = mock.MagicMock()
# get the image to run lazy loading, but as a non-admin, non-owner
resp = self.api_get('/v2/images/%s' % image_id,
headers={'X-Roles': 'reader'})
image = resp.json
# verify the image is updated to new format
self.assertEqual('cinder://store1/%s' % self.vol_id,
image['locations'][0]['url'])
self.assertEqual('store1', image['locations'][0]['metadata']['store'])
image = self.api_get('/v2/images/%s' % image_id).json
# verify the image location url is consistent
self.assertEqual('cinder://store1/%s' % self.vol_id,
image['locations'][0]['url'])
# NOTE(whoami-rajat): These are internals called by glance_store, so
# we want to make sure they got hit, but not be too strict about how.
mocked_cc.assert_called()
mock_open.assert_called()
mock_chown.assert_called()
mock_connector.get_connector_properties.assert_called()
|
