summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsteve <steve>2012-03-12 16:32:19 +0000
committersteve <steve>2012-03-12 16:32:19 +0000
commit19c2e3148877af02bfa7efb5d7e7536eab778111 (patch)
tree70619c205661d0f57616521a14a30d55a8f234ed
parentcff3258dc810607224f155da353dd6a7e2695a64 (diff)
downloadopenssl-19c2e3148877af02bfa7efb5d7e7536eab778111.tar.gz
corrected fix to PR#2711 and also cover mime_param_cmp
-rw-r--r--crypto/asn1/asn_mime.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/crypto/asn1/asn_mime.c b/crypto/asn1/asn_mime.c
index 6d8a9bf90..54a704a96 100644
--- a/crypto/asn1/asn_mime.c
+++ b/crypto/asn1/asn_mime.c
@@ -862,9 +862,8 @@ static int mime_hdr_addparam(MIME_HEADER *mhdr, char *name, char *value)
static int mime_hdr_cmp(const MIME_HEADER * const *a,
const MIME_HEADER * const *b)
{
- if ((*a)->name == NULL || (*b)->name == NULL)
- return (*a)->name - (*b)->name < 0 ? -1 :
- (*a)->name - (*b)->name > 0 ? 1 : 0;
+ if (!(*a)->name || !(*b)->name)
+ return !!(*a)->name - !!(*b)->name;
return(strcmp((*a)->name, (*b)->name));
}
@@ -872,6 +871,8 @@ static int mime_hdr_cmp(const MIME_HEADER * const *a,
static int mime_param_cmp(const MIME_PARAM * const *a,
const MIME_PARAM * const *b)
{
+ if (!(*a)->param_name || !(*b)->param_name)
+ return !!(*a)->param_name - !!(*b)->param_name;
return(strcmp((*a)->param_name, (*b)->param_name));
}