diff options
| author | Pauli <ppzgs1@gmail.com> | 2021-03-19 09:19:08 +1000 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2021-03-26 08:46:01 +1000 |
| commit | b8cb90cdb68d81770e21417ca554954c92603675 (patch) | |
| tree | f9a29b74e0a20e85f13e3f5a39950e085bf865c4 /test | |
| parent | 0d2b8bd261bbebc8a1834d85ede0a2bd22c71851 (diff) | |
| download | openssl-new-b8cb90cdb68d81770e21417ca554954c92603675.tar.gz | |
test: fix coverity 1416888: unchecked return value
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14615)
Diffstat (limited to 'test')
| -rw-r--r-- | test/ssl_cert_table_internal_test.c | 33 |
1 files changed, 12 insertions, 21 deletions
diff --git a/test/ssl_cert_table_internal_test.c b/test/ssl_cert_table_internal_test.c index d6e93af5b6..fbf70e7405 100644 --- a/test/ssl_cert_table_internal_test.c +++ b/test/ssl_cert_table_internal_test.c @@ -43,27 +43,18 @@ static int do_test_cert_table(int nid, uint32_t amask, size_t idx, static int test_ssl_cert_table(void) { - TEST_size_t_eq(OSSL_NELEM(ssl_cert_info), SSL_PKEY_NUM); - if (!test_cert_table(EVP_PKEY_RSA, SSL_aRSA, SSL_PKEY_RSA)) - return 0; - if (!test_cert_table(EVP_PKEY_DSA, SSL_aDSS, SSL_PKEY_DSA_SIGN)) - return 0; - if (!test_cert_table(EVP_PKEY_EC, SSL_aECDSA, SSL_PKEY_ECC)) - return 0; - if (!test_cert_table(NID_id_GostR3410_2001, SSL_aGOST01, SSL_PKEY_GOST01)) - return 0; - if (!test_cert_table(NID_id_GostR3410_2012_256, SSL_aGOST12, - SSL_PKEY_GOST12_256)) - return 0; - if (!test_cert_table(NID_id_GostR3410_2012_512, SSL_aGOST12, - SSL_PKEY_GOST12_512)) - return 0; - if (!test_cert_table(EVP_PKEY_ED25519, SSL_aECDSA, SSL_PKEY_ED25519)) - return 0; - if (!test_cert_table(EVP_PKEY_ED448, SSL_aECDSA, SSL_PKEY_ED448)) - return 0; - - return 1; + return TEST_size_t_eq(OSSL_NELEM(ssl_cert_info), SSL_PKEY_NUM) + && test_cert_table(EVP_PKEY_RSA, SSL_aRSA, SSL_PKEY_RSA) + && test_cert_table(EVP_PKEY_DSA, SSL_aDSS, SSL_PKEY_DSA_SIGN) + && test_cert_table(EVP_PKEY_EC, SSL_aECDSA, SSL_PKEY_ECC) + && test_cert_table(NID_id_GostR3410_2001, SSL_aGOST01, + SSL_PKEY_GOST01) + && test_cert_table(NID_id_GostR3410_2012_256, SSL_aGOST12, + SSL_PKEY_GOST12_256) + && test_cert_table(NID_id_GostR3410_2012_512, SSL_aGOST12, + SSL_PKEY_GOST12_512) + && test_cert_table(EVP_PKEY_ED25519, SSL_aECDSA, SSL_PKEY_ED25519) + && test_cert_table(EVP_PKEY_ED448, SSL_aECDSA, SSL_PKEY_ED448); } int setup_tests(void) |